1
0
mirror of https://github.com/golang/go synced 2024-11-18 20:34:39 -07:00
go/internal
Pontus Leitzler 8d7dbee4c8 internal/lsp/source: support labeled statements when highlighting loops
When document.Highlight is called with the cursor on a loop statement or
branch statement, gopls doesn't look for labels. Placing the cursor at
the break statement below highlights the inner for loop:

Outer:
for {
    for {
        break Outer
    }
}

By making highlight label aware, and ensure that unlabeled "break" in
"switch"/"select" doesn't highlight the outer loop, this change fixes
loop highlighting.

Adding support for highlight of "switch" and "select" will be handled in
a separate CL.

Updates golang/go#39275

Change-Id: I7014aa7b0dfb1da871863ced611623be995f3944
Reviewed-on: https://go-review.googlesource.com/c/tools/+/236524
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
Run-TryBot: Rebecca Stambler <rstambler@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
2020-06-10 05:20:24 +00:00
..
analysisinternal internal/lsp: add goreturns like functionality as quickfix 2020-04-01 19:27:44 +00:00
apidiff
event internal/event: improve the logging of events 2020-05-11 17:49:55 +00:00
fakenet internal/fakenet: add a fake network connection 2020-05-27 14:27:59 +00:00
fastwalk internal/fastwalk: attempt Symlink tests on Windows 2020-05-21 21:19:27 +00:00
gocommand cmd/godoc: support automatic vendoring 2020-06-09 06:04:08 +00:00
gopathwalk internal: rationalize debug logging 2020-03-03 16:59:18 +00:00
imports cmd/godoc: support automatic vendoring 2020-06-09 06:04:08 +00:00
jsonrpc2 internal/jsonrpc2: change StreamServer to operate on Conn instead of Stream 2020-06-03 17:07:01 +00:00
lsp internal/lsp/source: support labeled statements when highlighting loops 2020-06-10 05:20:24 +00:00
memoize internal/lsp/debug: serve cache entry counts 2020-02-03 22:21:18 +00:00
packagesinternal go/packages: add a Module field to the Package struct 2020-05-19 14:27:18 +00:00
proxydir all: remove version-specific test files 2020-05-28 17:13:50 +00:00
span internal/span: handle URI escaping better 2020-02-18 20:59:02 +00:00
stack internal/stack: add the leak test 2020-05-27 14:25:42 +00:00
testenv all: replace build tags in tests with testenv helper 2020-05-27 18:32:53 +00:00
tool internal/tool: avoid editorialization 2020-03-05 14:01:59 +00:00
xcontext