Heschi Kreinick 72051f7961 internal/lsp: pass snapshot/view to memoize.Functions ... Due to the runtime's inability to collect cycles involving finalizers, we can't close over handles in memoize.Functions without causing memory leaks. Up until now we've dealt with that by closing over all the bits of the snapshot that we want, but it distorts the design of all the code used in the Functions. We can solve the problem another way: instead of closing over the snapshot/view, we can force the caller to pass it in. This is somewhat scary: there is no requirement that the argument matches the data that we're working with. But the reality is that this is not a new problem: the Function used to calculate a cache value is not necessarily the one that the caller expects. As long as the cache key fully identifies all the inputs to the Function, the output should be correct. And since the caller used the snapshot/view to calculate that cache key, it should always be safe to pass in that snapshot/view. If it's not, then we already had a bug. The Arg type in memoize is clumsy, but I thought it would be nice to have at least a little bit of type safety. I'm open to suggestions. Change-Id: I23f546638b0c66a4698620a986949087211f4762 Reviewed-on: https://go-review.googlesource.com/c/tools/+/244019 Reviewed-by: Robert Findley <rfindley@google.com> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-07-28 17:34:46 +00:00
..
code_lens.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
command.go	internal/lsp: support refactor.extract through commands	2020-07-27 19:25:51 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp: remove Ignore feature	2020-06-11 22:55:14 +00:00
completion_format.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
completion_literal.go	internal/telemetry: renaming to internal/event	2020-04-23 17:20:48 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer smart "append()" completions	2020-05-20 22:05:37 +00:00
completion.go	internal/lsp: support refactor.extract through commands	2020-07-27 19:25:51 +00:00
deep_completion.go	internal/lsp: use one context throughout completion	2020-04-06 16:51:37 +00:00
diagnostics.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
extract.go	internal/lsp: support return statements in extract function	2020-07-28 16:04:03 +00:00
folding_range.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
format_test.go	internal/lsp: handle bad formatting with CRLF line endings	2020-07-28 16:05:17 +00:00
format.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
highlight.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
hover.go	internal/lsp: fix hover link for embedded fields and methods	2020-07-27 15:46:26 +00:00
identifier.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
implementation.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
options.go	internal/lsp: support refactor.extract through commands	2020-07-27 19:25:51 +00:00
references.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
rename_check.go	internal/lsp: add changeMethods logic to rename check	2020-07-13 19:50:33 +00:00
rename.go	internal/lsp: add changeMethods logic to rename check	2020-07-13 19:50:33 +00:00
signature_help.go	internal/lsp/source: speed up completion candidate formatting	2020-07-01 04:11:22 +00:00
source_test.go	internal/lsp: fix hover for implicit type switch variable declarations	2020-07-24 02:27:22 +00:00
symbols.go	internal/lsp: use %w in error wrappers	2020-05-04 14:52:14 +00:00
types_format.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
util.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
view.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00
workspace_symbol.go	internal/lsp: pass snapshot/view to memoize.Functions	2020-07-28 17:34:46 +00:00