mirror of
https://github.com/golang/go
synced 2024-11-26 20:11:26 -07:00
6722d45631
1. On entry to a function, only zero the ambiguously live stack variables. Before, we were zeroing all stack variables containing pointers. The zeroing is pretty inefficient right now (issue 7624), but there are also too many stack variables detected as ambiguously live (issue 7345), and that must be addressed before deciding how to improve the zeroing code. (Changes in 5g/ggen.c, 6g/ggen.c, 8g/ggen.c, gc/pgen.c) Fixes #7647. 2. Make the regopt word-based liveness analysis preserve the whole-variable liveness property expected by the garbage collection bitmap liveness analysis. That is, if the regopt liveness decides that one word in a struct needs to be preserved, make sure it preserves the entire struct. This is particularly important for multiword values such as strings, slices, and interfaces, in which all the words need to be present in order to understand the meaning. (Changes in 5g/reg.c, 6g/reg.c, 8g/reg.c.) Fixes #7591. 3. Make the regopt word-based liveness analysis treat a variable as having its address taken - which makes it preserved across all future calls - whenever n->addrtaken is set, for consistency with the gc bitmap liveness analysis, even if there is no machine instruction actually taking the address. In this case n->addrtaken is incorrect (a nicer way to put it is overconservative), and ideally there would be no such cases, but they can happen and the two analyses need to agree. (Changes in 5g/reg.c, 6g/reg.c, 8g/reg.c; test in bug484.go.) Fixes crashes found by turning off "zero everything" in step 1. 4. Remove spurious VARDEF annotations. As the comment in gc/pgen.c explains, the VARDEF must immediately precede the initialization. It cannot be too early, and it cannot be too late. In particular, if a function call sits between the VARDEF and the actual machine instructions doing the initialization, the variable will be treated as live during that function call even though it is uninitialized, leading to problems. (Changes in gc/gen.c; test in live.go.) Fixes crashes found by turning off "zero everything" in step 1. 5. Do not treat loading the address of a wide value as a signal that the value must be initialized. Instead depend on the existence of a VARDEF or the first actual read/write of a word in the value. If the load is in order to pass the address to a function that does the actual initialization, treating the load as an implicit VARDEF causes the same problems as described in step 4. The alternative is to arrange to zero every such value before passing it to the real initialization function, but this is a much easier and more efficient change. (Changes in gc/plive.c.) Fixes crashes found by turning off "zero everything" in step 1. 6. Treat wide input parameters with their address taken as initialized on entry to the function. Otherwise they look "ambiguously live" and we will try to emit code to zero them. (Changes in gc/plive.c.) Fixes crashes found by turning off "zero everything" in step 1. 7. An array of length 0 has no pointers, even if the element type does. Without this change, the zeroing code complains when asked to clear a 0-length array. (Changes in gc/reflect.c.) LGTM=khr R=khr CC=golang-codereviews https://golang.org/cl/80160044 |
||
|---|---|---|
| .. | ||
| bench | ||
| bugs | ||
| chan | ||
| ddd2.dir | ||
| dwarf | ||
| fixedbugs | ||
| import2.dir | ||
| import4.dir | ||
| interface | ||
| ken | ||
| method4.dir | ||
| safe | ||
| stress | ||
| syntax | ||
| 64bit.go | ||
| 235.go | ||
| alias1.go | ||
| alias.go | ||
| append.go | ||
| args.go | ||
| assign1.go | ||
| assign.go | ||
| bigalg.go | ||
| bigmap.go | ||
| blank1.go | ||
| blank.go | ||
| bom.go | ||
| bombad.go | ||
| bounds.go | ||
| chancap.go | ||
| char_lit1.go | ||
| char_lit.go | ||
| closedchan.go | ||
| closure.go | ||
| cmp6.go | ||
| cmp.go | ||
| cmplx.go | ||
| cmplxdivide1.go | ||
| cmplxdivide.c | ||
| cmplxdivide.go | ||
| complit1.go | ||
| complit.go | ||
| compos.go | ||
| const1.go | ||
| const2.go | ||
| const3.go | ||
| const4.go | ||
| const5.go | ||
| const6.go | ||
| const.go | ||
| convert1.go | ||
| convert3.go | ||
| convert.go | ||
| convlit1.go | ||
| convlit.go | ||
| convT2X.go | ||
| copy.go | ||
| crlf.go | ||
| ddd1.go | ||
| ddd2.go | ||
| ddd.go | ||
| decl.go | ||
| declbad.go | ||
| defer.go | ||
| deferfin.go | ||
| deferprint.go | ||
| deferprint.out | ||
| divide.go | ||
| divmod.go | ||
| empty.go | ||
| env.go | ||
| eof1.go | ||
| eof.go | ||
| errchk | ||
| escape2.go | ||
| escape3.go | ||
| escape4.go | ||
| escape5.go | ||
| escape.go | ||
| float_lit.go | ||
| floatcmp.go | ||
| for.go | ||
| func1.go | ||
| func2.go | ||
| func3.go | ||
| func4.go | ||
| func5.go | ||
| func6.go | ||
| func7.go | ||
| func8.go | ||
| func.go | ||
| funcdup2.go | ||
| funcdup.go | ||
| gc1.go | ||
| gc2.go | ||
| gc.go | ||
| gcstring.go | ||
| golden.out | ||
| goprint.go | ||
| goprint.out | ||
| goto.go | ||
| helloworld.go | ||
| helloworld.out | ||
| if.go | ||
| import1.go | ||
| import2.go | ||
| import4.go | ||
| import5.go | ||
| import.go | ||
| index0.go | ||
| index1.go | ||
| index2.go | ||
| index.go | ||
| indirect1.go | ||
| indirect.go | ||
| init1.go | ||
| init.go | ||
| initcomma.go | ||
| initialize.go | ||
| initializerr.go | ||
| int_lit.go | ||
| intcvt.go | ||
| iota.go | ||
| label1.go | ||
| label.go | ||
| linkx.go | ||
| literal.go | ||
| live1.go | ||
| live.go | ||
| mallocfin.go | ||
| map1.go | ||
| map.go | ||
| mapnan.go | ||
| method1.go | ||
| method2.go | ||
| method3.go | ||
| method4.go | ||
| method5.go | ||
| method.go | ||
| named1.go | ||
| named.go | ||
| nil.go | ||
| nilcheck.go | ||
| nilptr2.go | ||
| nilptr3.go | ||
| nilptr4.go | ||
| nilptr.go | ||
| nul1.go | ||
| parentype.go | ||
| peano.go | ||
| printbig.go | ||
| printbig.out | ||
| range.go | ||
| recover1.go | ||
| recover2.go | ||
| recover3.go | ||
| recover.go | ||
| rename1.go | ||
| rename.go | ||
| reorder2.go | ||
| reorder.go | ||
| return.go | ||
| rotate0.go | ||
| rotate1.go | ||
| rotate2.go | ||
| rotate3.go | ||
| rotate.go | ||
| run | ||
| run.go | ||
| rune.go | ||
| runtime.go | ||
| shift1.go | ||
| shift2.go | ||
| sieve.go | ||
| sigchld.go | ||
| sigchld.out | ||
| simassign.go | ||
| sinit.go | ||
| sizeof.go | ||
| slice3.go | ||
| slice3err.go | ||
| solitaire.go | ||
| stack.go | ||
| string_lit.go | ||
| stringrange.go | ||
| struct0.go | ||
| switch3.go | ||
| switch4.go | ||
| switch.go | ||
| testlib | ||
| tinyfin.go | ||
| torture.go | ||
| turing.go | ||
| typecheck.go | ||
| typeswitch1.go | ||
| typeswitch2.go | ||
| typeswitch3.go | ||
| typeswitch.go | ||
| undef.go | ||
| utf.go | ||
| varerr.go | ||
| varinit.go | ||
| zerodivide.go | ||