1
0
mirror of https://github.com/golang/go synced 2024-10-01 08:18:32 -06:00
go/internal/lsp/source
Ian Cottrell 508f945e1a internal/lsp: change File.Read to a File.GetContent accessor
Like the previous change to the FIle interface, we treat Read as if it were an
accessor, we remember the content part but not the error part, and we may fill
it in asynchronously, so this change makes it explicit.
In the future we should probably trap the error in the read and push it back
through another channel though, it will be the root cause of later errors.

Change-Id: I3d374dd557178b4e8c5544813cd77f5c0faefe5b
Reviewed-on: https://go-review.googlesource.com/c/162403
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-02-14 04:36:41 +00:00
..
analysis.go internal/lsp: copy fact support from go/analysis/internal/checker.go 2019-02-12 19:58:15 +00:00
completion.go internal/lsp: remove error return values from interface "field" accessors 2019-02-13 21:58:50 +00:00
definition.go internal/lsp: remove error return values from interface "field" accessors 2019-02-13 21:58:50 +00:00
diagnostics.go internal/lsp: change File.Read to a File.GetContent accessor 2019-02-14 04:36:41 +00:00
format.go internal/lsp: change File.Read to a File.GetContent accessor 2019-02-14 04:36:41 +00:00
signature_help.go internal/lsp: remove error return values from interface "field" accessors 2019-02-13 21:58:50 +00:00
uri_test.go internal/lsp/source: avoid having build tagged files for uri 2018-12-17 19:55:17 +00:00
uri.go internal/lsp: add ranges to some diagnostics messages 2018-12-20 19:13:07 +00:00
view.go internal/lsp: change File.Read to a File.GetContent accessor 2019-02-14 04:36:41 +00:00