1
0
mirror of https://github.com/golang/go synced 2024-11-18 16:54:43 -07:00
go/internal/lsp
Ian Cottrell 508f945e1a internal/lsp: change File.Read to a File.GetContent accessor
Like the previous change to the FIle interface, we treat Read as if it were an
accessor, we remember the content part but not the error part, and we may fill
it in asynchronously, so this change makes it explicit.
In the future we should probably trap the error in the read and push it back
through another channel though, it will be the root cause of later errors.

Change-Id: I3d374dd557178b4e8c5544813cd77f5c0faefe5b
Reviewed-on: https://go-review.googlesource.com/c/162403
Run-TryBot: Ian Cottrell <iancottrell@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2019-02-14 04:36:41 +00:00
..
cache internal/lsp: change File.Read to a File.GetContent accessor 2019-02-14 04:36:41 +00:00
cmd internal/lsp: remove error return values from interface "field" accessors 2019-02-13 21:58:50 +00:00
diff internal/lsp/diff: fix bug that adds extra line to files on format 2019-02-13 04:28:36 +00:00
protocol internal/lsp: allow ExecuteCommandParams to be nil 2019-02-13 22:34:05 +00:00
source internal/lsp: change File.Read to a File.GetContent accessor 2019-02-14 04:36:41 +00:00
testdata internal/lsp/diff: fix bug that adds extra line to files on format 2019-02-13 04:28:36 +00:00
completion.go internal/lsp: add additional tests for completion 2018-12-19 22:27:14 +00:00
diagnostics.go internal/lsp: connect basic analysis functionality 2019-02-06 21:48:25 +00:00
format.go internal/lsp: change File.Read to a File.GetContent accessor 2019-02-14 04:36:41 +00:00
imports.go internal/lsp: change File.Read to a File.GetContent accessor 2019-02-14 04:36:41 +00:00
lsp110_test.go internal/lsp: add more testdata for completion and diagnostics 2018-11-20 06:06:34 +00:00
lsp_test.go internal/lsp: change File.Read to a File.GetContent accessor 2019-02-14 04:36:41 +00:00
position.go internal/lsp: remove error return values from interface "field" accessors 2019-02-13 21:58:50 +00:00
server.go internal/lsp: remove error return values from interface "field" accessors 2019-02-13 21:58:50 +00:00
signature_help.go internal/lsp: implement signature help 2018-11-13 20:09:34 +00:00