1
0
mirror of https://github.com/golang/go synced 2024-11-05 11:46:12 -07:00
go/internal/lsp/cache
Heschi Kreinick 4d1d9acccf internal/lsp/cache: fix parseKey
The FileIdentity struct mixes information about the file itself
(filename, hash) with information about the LSP references to that file
(session ID, version). When we create a cache key using it, we only want
the former, as returned by the String method. Otherwise we split the
cache whenever those irrelevant fields are different.

We also use FileIdentity as an element of diagnosticsKey, but I believe
that use is appropriate.

Change-Id: I094e00d2700e05778da635effbb69d0ebcb6726e
Reviewed-on: https://go-review.googlesource.com/c/tools/+/244020
Reviewed-by: Robert Findley <rfindley@google.com>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-07-28 17:34:57 +00:00
..
analysis.go internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
cache.go internal/lsp/cache: remove files from the memoize.Store 2020-07-28 17:34:34 +00:00
check.go internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
error_test.go internal/lsp: refactor error handling code in type-checking 2019-10-21 18:57:46 +00:00
errors.go internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
keys.go internal/lsp: decouple client and server debug 2020-06-11 13:49:48 +00:00
load.go internal/lsp: treat the module root as the workspace root, if available 2020-07-23 21:33:49 +00:00
mod_tidy.go internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
mod.go internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
os_darwin.go internal/lsp: add a mutex around the view's options 2020-04-02 16:41:49 +00:00
os_windows.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
parse.go internal/lsp/cache: fix parseKey 2020-07-28 17:34:57 +00:00
pkg.go internal/lsp: minimize PackageHandle interface 2020-07-28 17:34:24 +00:00
session.go internal/lsp: handle unknown revision in go.mod file 2020-07-21 21:40:18 +00:00
snapshot.go internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00
view_test.go internal/lsp/cache: validate workspace path case 2020-03-27 19:55:53 +00:00
view.go internal/lsp: pass snapshot/view to memoize.Functions 2020-07-28 17:34:46 +00:00