1
0
mirror of https://github.com/golang/go synced 2024-11-08 12:06:18 -07:00
go/src
Matthew Dempsky 497ea0610e cmd/compile: allow inlining of "for" loops
We already allow inlining "if" and "goto" statements, so we might as
well allow "for" loops too. The majority of frontend support is
already there too.

The critical missing feature at the moment is that inlining doesn't
properly reassociate OLABEL nodes with their control statement (e.g.,
OFOR) after inlining. This eventually causes SSA construction to fail.

As a workaround, this CL only enables inlining for unlabeled "for"
loops. It's left to a (yet unplanned) future CL to add support for
labeled "for" loops.

The increased opportunity for inlining leads to a small growth in
binary size. For example:

$ size go.old go.new
   text	   data	    bss	    dec	    hex	filename
9740163	 320064	 230656	10290883	 9d06c3	go.old
9793399	 320064	 230656	10344119	 9dd6b7	go.new

Updates #14768.
Fixes #41474.

Change-Id: I827db0b2b9d9fa2934db05caf6baa463f0cd032a
Reviewed-on: https://go-review.googlesource.com/c/go/+/256459
Run-TryBot: Matthew Dempsky <mdempsky@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
Trust: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: David Chase <drchase@google.com>
Reviewed-by: Cuong Manh Le <cuong.manhle.vn@gmail.com>
2020-10-15 18:26:33 +00:00
..
archive
bufio
builtin
bytes
cmd cmd/compile: allow inlining of "for" loops 2020-10-15 18:26:33 +00:00
compress compress/flate: remove unneeded zeroing of bytes array in (*huffmanBitWriter).reset 2020-10-06 20:30:36 +00:00
container
context
crypto crypto/x509: add signature verification to CreateCertificate 2020-10-14 20:17:49 +00:00
database/sql
debug [dev.link] Merge branch 'master' into dev.link 2020-09-30 18:00:58 -04:00
encoding encoding/asn1: clarify use of SET suffix 2020-10-05 16:55:37 +00:00
errors
expvar
flag
fmt fmt: explain how Formatter interface affects verbs and flags 2020-10-13 19:15:53 +00:00
go token: more descriptive panics 2020-10-14 22:35:32 +00:00
hash hash/crc32: fix race between lazy Castagnoli init and Update/Write 2020-10-13 00:31:47 +00:00
html text/template: allow newlines inside action delimiters 2020-10-12 16:30:36 +00:00
image
index/suffixarray
internal internal/cpu: remove unused arm64 capabilities 2020-10-13 18:26:39 +00:00
io io: add a new ReadSeekCloser interface 2020-10-14 17:05:21 +00:00
log all: enable more tests on macOS/ARM64 2020-10-06 21:56:24 +00:00
math
mime syscall: remove dependency on io 2020-10-13 00:55:35 +00:00
net net/http: return 505 status for rejected protocol version 2020-10-14 18:05:16 +00:00
os os: call f.Close before t.Fatal to avoid vet unreachable code warnings 2020-10-12 09:28:40 +00:00
path path: avoid import of strings 2020-10-13 01:12:09 +00:00
plugin
reflect cmd/compile: split exported/non-exported methods for interface type 2020-10-09 02:14:32 +00:00
regexp
runtime runtime: remove debugCachedWork 2020-10-15 15:55:19 +00:00
sort sort: document requirements of Less relation 2020-10-14 19:35:59 +00:00
strconv
strings
sync sync: fix typo in pooldequeue 2020-10-14 13:38:41 +00:00
syscall syscall: remove stray TODO comment 2020-10-14 08:05:58 +00:00
testdata
testing
text text/template: allow newlines inside action delimiters 2020-10-12 16:30:36 +00:00
time lib/time, time, time/tzdata: use slim tz data format 2020-10-14 09:00:41 +00:00
unicode
unsafe
vendor src/go.mod, net/http: update bundled and latest golang.org/x/net 2020-09-30 18:47:07 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash src/buildall.bash: remove linux-386-387 target 2020-10-05 21:08:03 +00:00
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod src/go.mod, net/http: update bundled and latest golang.org/x/net 2020-09-30 18:47:07 +00:00
go.sum src/go.mod, net/http: update bundled and latest golang.org/x/net 2020-09-30 18:47:07 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.