48ec5122ff
They were in Do, which is the method that actually starts the build. However, we can already run these checks in Init, since we already have all the information necessary to do the checks. More importantly, some work happens between Init and Do, namely package loading. That may exit with an error, meaning that in some cases the user gets a confusing error instead of the correct one. For example, using a GOOS typo, before showed: $ GOOS=windwos go build can't load package: package p: build constraints exclude all Go files in ... And now: $ GOOS=windwos go build cmd/go: unsupported GOOS/GOARCH pair windwos/amd64 Also had to tweak TestGoEnv to modify GOOS as well as GOARCH. Otherwise, on windows this would result in the invalid GOOS/GOARCH pair windows/arm, which would error given that we now check that in non-build commands such as "go env". Fixes #21999. Change-Id: Iff9890dea472bff0179a9d703d6f698a0e3187c1 Reviewed-on: https://go-review.googlesource.com/65656 Run-TryBot: Daniel Martí <mvdan@mvdan.cc> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: David Crawshaw <crawshaw@golang.org> |
||
|---|---|---|
| .github | ||
| api | ||
| doc | ||
| lib/time | ||
| misc | ||
| src | ||
| test | ||
| .gitattributes | ||
| .gitignore | ||
| AUTHORS | ||
| CONTRIBUTING.md | ||
| CONTRIBUTORS | ||
| favicon.ico | ||
| LICENSE | ||
| PATENTS | ||
| README.md | ||
| robots.txt | ||
The Go Programming Language
Go is an open source programming language that makes it easy to build simple, reliable, and efficient software.
Gopher image by Renee French, licensed under Creative Commons 3.0 Attributions license.
Our canonical Git repository is located at https://go.googlesource.com/go. There is a mirror of the repository at https://github.com/golang/go.
Unless otherwise noted, the Go source files are distributed under the BSD-style license found in the LICENSE file.
Download and Install
Binary Distributions
Official binary distributions are available at https://golang.org/dl/.
After downloading a binary release, visit https://golang.org/doc/install or load doc/install.html in your web browser for installation instructions.
Install From Source
If a binary distribution is not available for your combination of operating system and architecture, visit https://golang.org/doc/install/source or load doc/install-source.html in your web browser for source installation instructions.
Contributing
Go is the work of hundreds of contributors. We appreciate your help!
To contribute, please read the contribution guidelines: https://golang.org/doc/contribute.html
Note that the Go project does not use GitHub pull requests, and that we use the issue tracker for bug reports and proposals only. See https://golang.org/wiki/Questions for a list of places to ask questions about the Go language.