1
0
mirror of https://github.com/golang/go synced 2024-11-26 20:21:25 -07:00

cmd/compile: fix invalid switch case value panic

This is a regression introduced by myself in golang.org/cl/41852,
confirmed by the program that reproduces the crash that can be seen in
the added test.

Fixes #21988.

Change-Id: I18d5b2b3de63ced84db705b18490b00b16b59e02
Reviewed-on: https://go-review.googlesource.com/65655
Run-TryBot: Daniel Martí <mvdan@mvdan.cc>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Daniel Martí 2017-09-23 23:04:31 +01:00
parent 7739b8a97f
commit 24ca86f308
2 changed files with 22 additions and 0 deletions

View File

@ -610,6 +610,11 @@ func checkDupExprCases(exprname *Node, clauses []*Node) {
if ct := consttype(n); ct < 0 || ct == CTBOOL {
continue
}
// If the value has no type, we have
// already printed an error about it.
if n.Type == nil {
continue
}
val := n.Val().Interface()
prev, dup := seen[val]

View File

@ -0,0 +1,17 @@
// errorcheck
// Copyright 2017 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Issue 21988: panic on switch case with invalid value
package p
const X = Wrong(0) // ERROR "undefined: Wrong"
func _() {
switch 0 {
case X:
}
}