mirror of
https://github.com/golang/go
synced 2024-11-19 02:54:42 -07:00
46e9d8e060
It looks like the partial Commits are coming from the build breakages mails. If you have commit A newer than commit B, then there are two code paths depending on which reports its build result first. For slow development, B finishes before A is committed, so when A notices a failure it checks to see if B was okay. That code path seems to be okay. For submit of back-to-back changes, typically A finishes before B, so when B notices an okay it checks to see if A failed. That code path seems to zero the Commit for A while trying to set its FailNotificationSent to true. It does (did) succeed in setting FailNotificationSent to true, it just zeroed everything else. This CL adds code to refuse to do the datastore.Put to update FailNotificationSent if the Commit info is incomplete. It also tries to ignore Num=0 records, but that may not be as important anymore. LGTM=cmang R=cmang CC=golang-codereviews https://golang.org/cl/154080043 |
||
|---|---|---|
| .. | ||
| build | ||
| cache | ||
| key | ||
| static | ||
| app.yaml | ||
| cron.yaml | ||
| index.yaml | ||