1
0
mirror of https://github.com/golang/go synced 2024-11-18 17:04:41 -07:00
The Go programming language
Go to file
Russ Cox 46e9d8e060 dashboard/app: ignore, try not to create partial Commits
It looks like the partial Commits are coming from the build breakages mails.
If you have commit A newer than commit B, then there are two code
paths depending on which reports its build result first.
For slow development, B finishes before A is committed, so when
A notices a failure it checks to see if B was okay.
That code path seems to be okay.
For submit of back-to-back changes, typically A finishes before B,
so when B notices an okay it checks to see if A failed.
That code path seems to zero the Commit for A while
trying to set its FailNotificationSent to true.
It does (did) succeed in setting FailNotificationSent to true,
it just zeroed everything else.

This CL adds code to refuse to do the datastore.Put to
update FailNotificationSent if the Commit info is incomplete.

It also tries to ignore Num=0 records, but that may not be
as important anymore.

LGTM=cmang
R=cmang
CC=golang-codereviews
https://golang.org/cl/154080043
2014-10-07 15:37:31 -04:00
astutil go.tools/astutil: delete all matching imports in DeleteImport 2014-08-14 11:51:51 -07:00
blog go.tools/blog: strip prefix when serving static content 2013-11-08 13:28:32 +11:00
cmd cmd/vet: fix bug where incorrect exit code was returned 2014-10-02 10:33:35 -07:00
container/intsets container/intsets: add benchmark of AppendTo method. 2014-06-19 14:35:37 -04:00
cover go.tools/cover: split parsing code out from cmd/cover 2013-12-03 20:55:21 -08:00
dashboard dashboard/app: ignore, try not to create partial Commits 2014-10-07 15:37:31 -04:00
go go/types: use file not parse order for init order computation 2014-10-01 09:56:28 -07:00
godoc godoc/analysis: log one error per error package. 2014-09-16 16:24:52 -04:00
imports go.tools/imports: recognize exports in cgo files 2014-09-29 12:46:11 -07:00
oracle go.tools/*: replace $GOROOT/src/pkg with $GOROOT/src where appropriate. 2014-09-08 13:24:38 -04:00
playground go.tools/playground: return a better message for code starting with a shebang on non local mode 2014-08-01 15:04:49 -07:00
present go.tools/present: add support for figure captions 2014-07-15 08:23:16 -07:00
refactor refactor/rename: attempt to fix windows test, 2nd attempt. 2014-09-24 16:38:46 -04:00
.hgignore dashboard: add Cloud Storage upload support to create.go 2014-09-03 21:41:16 -07:00
AUTHORS go.empty: prototype for new subrepository 2012-01-25 14:45:13 -05:00
codereview.cfg codereview: switch defaultcc to golang-codereviews 2013-12-20 10:54:33 -05:00
CONTRIBUTORS go.empty: prototype for new subrepository 2012-01-25 14:45:13 -05:00
LICENSE LICENSE: add 2012-03-17 15:20:58 +11:00
PATENTS go.empty: add PATENTS file to the subrepo. 2012-04-16 11:24:04 +10:00
README go.tools/README: minor correction. 2013-10-29 13:20:58 -04:00

This subrepository holds the source for various packages and tools that support
the Go programming language.

Some of the tools, godoc and vet for example, are included in binary Go distributions.
Others, including the Go oracle and the test coverage tool, can be fetched with "go get".

Packages include a type-checker for Go and an implementation of the
Static Single Assignment form (SSA) representation for Go programs.

To submit changes to this repository, see http://golang.org/doc/contribute.html.