1
0
mirror of https://github.com/golang/go synced 2024-11-16 20:44:52 -07:00
go/src
Cuong Manh Le 375a1fba0e cmd/compile: better error message for invalid untyped nil conversion
In case of an invalid untyped nil conversion, the compiler's original
type checker leaves it to the caller to report a suitable error message.
But types2 does not, it always reports the invalid conversion.

CL 328053 made types2 report a better error message, and match the
original compiler behavior. But it ignored the case of untyped nil.

This CL adds that missing case, by checking whether the two operands can
be mixed when untyped nil is present.

Fixes #48784

Change-Id: Idc7d86eb0245aa18ca428e278f4416d6b3679058
Reviewed-on: https://go-review.googlesource.com/c/go/+/354049
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Reviewed-by: Robert Griesemer <gri@golang.org>
Reviewed-by: Robert Findley <rfindley@google.com>
TryBot-Result: Go Bot <gobot@golang.org>
2021-10-07 14:37:36 +00:00
..
archive all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
bufio
builtin
bytes strings,bytes: avoid allocations in Trim/TrimLeft/TrimRight 2021-10-06 22:42:28 +00:00
cmd cmd/compile: better error message for invalid untyped nil conversion 2021-10-07 14:37:36 +00:00
compress
constraints
container
context
crypto all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
database/sql
debug
embed
encoding all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
errors
expvar
flag
fmt
go go/types: implement copy for generic argument types 2021-10-07 03:41:40 +00:00
hash
html all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
image
index/suffixarray
internal internal/cpu: remove option to mark cpu features required 2021-10-06 18:44:56 +00:00
io
log
math
mime all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
net net/http: add Cookie.Valid method 2021-10-06 23:26:57 +00:00
os all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
path
plugin
reflect
regexp all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
runtime runtime,sync: using fastrandn instead of modulo reduction 2021-10-07 14:01:52 +00:00
sort
strconv all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
strings strings,bytes: avoid allocations in Trim/TrimLeft/TrimRight 2021-10-06 22:42:28 +00:00
sync runtime,sync: using fastrandn instead of modulo reduction 2021-10-07 14:01:52 +00:00
syscall all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
testdata
testing
text all: use bytes.Cut, strings.Cut 2021-10-06 15:53:04 +00:00
time time: fallback to slower TestTicker test after one failure 2021-10-06 23:01:01 +00:00
unicode unicode: add examples for the Is functions 2021-10-06 23:19:13 +00:00
unsafe
vendor all: update go.mod for golang.org/x/net 2021-10-06 20:21:49 +00:00
all.bash
all.bat
all.rc
bootstrap.bash
buildall.bash
clean.bash
clean.bat
clean.rc
cmp.bash
go.mod all: update go.mod for golang.org/x/net 2021-10-06 20:21:49 +00:00
go.sum all: update go.mod for golang.org/x/net 2021-10-06 20:21:49 +00:00
make.bash
make.bat
Make.dist
make.rc
race.bash
race.bat
README.vendor
run.bash
run.bat
run.rc

Vendoring in std and cmd
========================

The Go command maintains copies of external packages needed by the
standard library in the src/vendor and src/cmd/vendor directories.

In GOPATH mode, imports of vendored packages are resolved to these
directories following normal vendor directory logic
(see golang.org/s/go15vendor).

In module mode, std and cmd are modules (defined in src/go.mod and
src/cmd/go.mod). When a package outside std or cmd is imported
by a package inside std or cmd, the import path is interpreted
as if it had a "vendor/" prefix. For example, within "crypto/tls",
an import of "golang.org/x/crypto/cryptobyte" resolves to
"vendor/golang.org/x/crypto/cryptobyte". When a package with the
same path is imported from a package outside std or cmd, it will
be resolved normally. Consequently, a binary may be built with two
copies of a package at different versions if the package is
imported normally and vendored by the standard library.

Vendored packages are internally renamed with a "vendor/" prefix
to preserve the invariant that all packages have distinct paths.
This is necessary to avoid compiler and linker conflicts. Adding
a "vendor/" prefix also maintains the invariant that standard
library packages begin with a dotless path element.

The module requirements of std and cmd do not influence version
selection in other modules. They are only considered when running
module commands like 'go get' and 'go mod vendor' from a directory
in GOROOT/src.

Maintaining vendor directories
==============================

Before updating vendor directories, ensure that module mode is enabled.
Make sure GO111MODULE=off is not set ('on' or 'auto' should work).

Requirements may be added, updated, and removed with 'go get'.
The vendor directory may be updated with 'go mod vendor'.
A typical sequence might be:

    cd src
    go get -d golang.org/x/net@latest
    go mod tidy
    go mod vendor

Use caution when passing '-u' to 'go get'. The '-u' flag updates
modules providing all transitively imported packages, not only
the module providing the target package.

Note that 'go mod vendor' only copies packages that are transitively
imported by packages in the current module. If a new package is needed,
it should be imported before running 'go mod vendor'.