1
0
mirror of https://github.com/golang/go synced 2024-11-19 01:34:40 -07:00
go/cmd/vet
Rob Pike c333e7a7b6 go.tools/cmd/vet: fix go.tools build
TBR: gri

I cannot create an issue on the tracker for some reason, so here it is:
go vet contains this snippet:

        if types.IsAssignableTo(typ, errorType) || types.IsAssignableTo(typ, stringerType) {

It's getting the wrong answer: It claims

interface {
        f()
}

or even

interface {
        f() float64
}

matches the Error and Stringer interfaces. Both of them.  This causes a test failure:
$ go test code.google.com/p/go.tools/cmd/vet
BUG: errchk: testdata/print.go:124: missing expected error: '"for printf verb %s of wrong type"'
$
This worked until very recently.

R=gri
CC=golang-dev
https://golang.org/cl/12398043
2013-08-03 15:56:56 +10:00
..
testdata go.tools/cmd/vet: fix go.tools build 2013-08-03 15:56:56 +10:00
asmdecl.go go.tools: add go/types, ssa, and cmd/vet 2013-05-17 13:20:39 -07:00
assign.go go.tools: add go/types, ssa, and cmd/vet 2013-05-17 13:20:39 -07:00
atomic.go go.tools: add go/types, ssa, and cmd/vet 2013-05-17 13:20:39 -07:00
buildtag.go go.tools: add go/types, ssa, and cmd/vet 2013-05-17 13:20:39 -07:00
composite.go go.tools/cmd/vet: the composite test is about keys, not tags 2013-08-03 12:19:59 +10:00
deadcode.go go.tools: add go/types, ssa, and cmd/vet 2013-05-17 13:20:39 -07:00
doc.go go.tools/cmd/vet: the composite test is about keys, not tags 2013-08-03 12:19:59 +10:00
main.go go.tools/cmd/vet: the composite test is about keys, not tags 2013-08-03 12:19:59 +10:00
method.go go.tools: add go/types, ssa, and cmd/vet 2013-05-17 13:20:39 -07:00
print.go go.tools/cmd/vet: fix error message 2013-07-18 16:56:01 -07:00
rangeloop.go go.tools: add go/types, ssa, and cmd/vet 2013-05-17 13:20:39 -07:00
shadow.go go.tools/cmd/vet: add check for shadowed variables 2013-06-21 11:27:53 -07:00
structtag.go go.tools: add go/types, ssa, and cmd/vet 2013-05-17 13:20:39 -07:00
types.go go.tools/cmd/vet: the composite test is about keys, not tags 2013-08-03 12:19:59 +10:00
vet_test.go go.tools/cmd/vet: add check for shadowed variables 2013-06-21 11:27:53 -07:00