Heschi Kreinick 0a46fa39b0 internal/lsp/source: propose loaded unimported package names first ... When proposing unimported package members, we start with packages loaded in-memory first, for three reasons: we know that they're fast, they're fully typed, and they're probably pretty relevant. I hadn't bothered doing that for package names, because the first two reasons aren't very relevant. But the third still is -- loaded packages are a pretty good approximation for in module scope, etc. With this change we do package names the same as members, so relevance should be about as good. Not perfect, but nobody's complained much yet. Fair bit of copy-and-paste, but I don't want to extend the getAllCandidates abstraction outside of the imports package yet. Updates #38104. Change-Id: Ia479181607dff898baee3cd6aa84d1ab61715d19 Reviewed-on: https://go-review.googlesource.com/c/tools/+/226559 Run-TryBot: Heschi Kreinick <heschi@google.com> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Rebecca Stambler <rstambler@golang.org>		2020-04-02 17:48:25 +00:00
..
code_lens.go	x/tools/gopls: run go generate through CodeLens	2020-03-17 04:34:34 +00:00
comment_test.go	internal/lsp: convert comments to markdown before sending to client	2019-10-04 18:35:38 +00:00
comment.go	internal/lsp: fix errors found by staticcheck	2020-03-19 19:20:54 +00:00
completion_builtin.go	internal/lsp/source: untangle completion type comparison	2020-02-24 18:12:40 +00:00
completion_format.go	internal/lsp: avoid logging context cancellation	2020-03-31 01:46:33 +00:00
completion_keywords.go	internal/lsp/source: offer loop keyword completions in range stmt	2020-03-12 04:57:24 +00:00
completion_labels.go	internal/lsp: sort by label after score	2019-12-30 21:11:21 +00:00
completion_literal.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
completion_snippet.go	internal/lsp: merge completion options into source.Options	2020-01-13 20:09:44 +00:00
completion_statements.go	internal/lsp/source: offer completion "if err != nil { return err }"	2020-03-10 21:06:53 +00:00
completion.go	internal/lsp/source: propose loaded unimported package names first	2020-04-02 17:48:25 +00:00
deep_completion.go	internal/lsp/source: prefer unexported and non-func candidates	2020-03-23 21:07:25 +00:00
diagnostics.go	internal/lsp: temporarily disable type error analyzers by default	2020-04-02 16:54:32 +00:00
folding_range.go	internal/lsp/cache: add file contents to ParseGoHandle	2020-02-13 05:05:14 +00:00
format_test.go	internal/lsp/source: trim file very carefully	2020-01-17 20:34:13 +00:00
format.go	internal/lsp: refactor and propagate errors from code actions	2020-03-31 20:20:46 +00:00
highlight.go	internal/lsp: avoid logging context cancellation	2020-03-31 01:46:33 +00:00
hover.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
identifier.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
implementation.go	internal/lsp: refactor references/rename/implementations	2020-03-27 17:09:18 +00:00
options.go	internal/lsp: temporarily disable type error analyzers by default	2020-04-02 16:54:32 +00:00
references.go	internal/lsp: refactor references/rename/implementations	2020-03-27 17:09:18 +00:00
rename_check.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
rename.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
signature_help.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00
source_test.go	internal/lsp: temporarily disable type error analyzers by default	2020-04-02 16:54:32 +00:00
symbols.go	internal/lsp/source: remove unused parameters from functions	2020-03-27 18:57:18 +00:00
util.go	internal/lsp: add goreturns like functionality as quickfix	2020-04-01 19:27:44 +00:00
view.go	internal/lsp: temporarily disable type error analyzers by default	2020-04-02 16:54:32 +00:00
workspace_symbol.go	internal/lsp: migrate telemetry to using the event package	2020-03-12 03:59:16 +00:00