1
0
mirror of https://github.com/golang/go synced 2024-09-30 22:58:34 -06:00
go/internal/lsp
Heschi Kreinick 0a46fa39b0 internal/lsp/source: propose loaded unimported package names first
When proposing unimported package members, we start with packages loaded
in-memory first, for three reasons: we know that they're fast, they're
fully typed, and they're probably pretty relevant. I hadn't bothered
doing that for package names, because the first two reasons aren't very
relevant. But the third still is -- loaded packages are a pretty good
approximation for in module scope, etc.

With this change we do package names the same as members, so relevance
should be about as good. Not perfect, but nobody's complained much yet.

Fair bit of copy-and-paste, but I don't want to extend the
getAllCandidates abstraction outside of the imports package yet.

Updates #38104.

Change-Id: Ia479181607dff898baee3cd6aa84d1ab61715d19
Reviewed-on: https://go-review.googlesource.com/c/tools/+/226559
Run-TryBot: Heschi Kreinick <heschi@google.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Rebecca Stambler <rstambler@golang.org>
2020-04-02 17:48:25 +00:00
..
analysis internal/lsp: add goreturns like functionality as quickfix 2020-04-01 19:27:44 +00:00
browser internal/lsp: add version and bug commands 2019-05-11 04:16:02 +00:00
cache internal/lsp: temporarily disable type error analyzers by default 2020-04-02 16:54:32 +00:00
cmd internal/lsp: temporarily disable type error analyzers by default 2020-04-02 16:54:32 +00:00
debug internal/lsp: rewrite the stats using the newer telemetry features 2020-03-31 00:50:33 +00:00
diff internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
fake internal/lsp: add a reg test to test "go mod init" 2020-03-31 02:48:52 +00:00
fuzzy internal/lsp: fix errors found by staticcheck 2020-03-19 19:20:54 +00:00
helper internal/lsp: change to helper.go to output a formatted file 2020-01-31 20:35:38 +00:00
lsprpc internal/lsp: rewrite the stats using the newer telemetry features 2020-03-31 00:50:33 +00:00
mod internal/lsp: refactor and propagate errors from code actions 2020-03-31 20:20:46 +00:00
protocol internal/lsp: avoid logging context cancellation 2020-03-31 01:46:33 +00:00
regtest internal/lsp: add a reg test to test "go mod init" 2020-03-31 02:48:52 +00:00
snippet all: fix broken links to LSP specification 2019-10-02 18:32:53 +00:00
source internal/lsp/source: propose loaded unimported package names first 2020-04-02 17:48:25 +00:00
testdata internal/lsp/analysis: add quickfix for "no result values expected" 2020-03-27 18:57:59 +00:00
tests internal/lsp: temporarily disable type error analyzers by default 2020-04-02 16:54:32 +00:00
code_action.go internal/lsp: refactor and propagate errors from code actions 2020-03-31 20:20:46 +00:00
command.go x/tools/gopls: run go generate through CodeLens 2020-03-17 04:34:34 +00:00
completion_test.go internal/span,lsp: disambiguate URIs, DocumentURIs, and paths 2020-02-14 22:51:03 +00:00
completion.go internal/lsp: avoid logging context cancellation 2020-03-31 01:46:33 +00:00
definition.go internal/lsp/source: return location(s) for imported packages 2020-03-09 16:25:02 +00:00
diagnostics.go internal/lsp: add a reg test to test "go mod init" 2020-03-31 02:48:52 +00:00
folding_range.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
format.go internal/lsp: support textDocument/formatting for .mod extension 2020-03-06 13:51:27 +00:00
general.go internal/lsp: print view-specific environment 2020-03-24 20:15:47 +00:00
generate.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
highlight.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
hover.go internal/lsp: support textDocument/hover for .mod extension 2020-02-26 15:59:49 +00:00
implementation.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
link.go internal/lsp: avoid logging context cancellation 2020-03-31 01:46:33 +00:00
lsp_test.go internal/lsp: temporarily disable type error analyzers by default 2020-04-02 16:54:32 +00:00
references.go internal/lsp: refactor references/rename/implementations 2020-03-27 17:09:18 +00:00
rename.go internal/lsp: check for file URIs on LSP requests 2020-02-14 22:51:26 +00:00
reset_golden.sh internal/lsp: fix regeneration of golden files 2019-09-25 13:16:59 +00:00
server_gen.go x/tools/gopls: add support for $/progress functionality 2020-03-16 21:25:24 +00:00
server.go internal/lsp: stop showing workspace misconfiguration message 2020-03-24 18:23:14 +00:00
signature_help.go internal/telemetry: delete the event.TagOf method 2020-03-18 13:23:15 +00:00
symbols.go internal/lsp: move the telemetry package 2020-03-18 13:22:49 +00:00
text_synchronization.go internal/lsp: fix view rebuilding when go mod init runs 2020-03-30 17:42:33 +00:00
workspace_symbol.go internal/lsp: migrate telemetry to using the event package 2020-03-12 03:59:16 +00:00
workspace.go internal/lsp: generate boilerplate stubs for type Server 2020-01-24 14:41:51 +00:00