1
0
mirror of https://github.com/golang/go synced 2024-11-19 04:04:47 -07:00
Commit Graph

6445 Commits

Author SHA1 Message Date
Russ Cox
f481afae53 Make.pkg: remove .so before installing new one
On Linux, overwriting an mmap'ed file causes
all the MAP_PRIVATE pages to get refreshed
with the new content, even ones that have been
modified by the process that did the mmap.

One specific instance of this is that after the
dynamic linker has relocated a page from a .so,
overwriting the .so will un-relocate it, making
the next use of one of the no-longer-relocated
addresses incorrect and probably crash the
program.

Linux must go out of its way to break programs
in this way: the pages have already been copied
on write, so they're not shared with the file system
cache, and it trashes them anyway.  The manual
says the behavior when the file gets overwritten
is "undefined".  Removing before copy avoids the
undefined behavior.

R=iant
CC=golang-dev, msolo
https://golang.org/cl/2333045
2010-10-01 16:02:18 -04:00
Russ Cox
d4e6df98f4 arm: enable 9 more package tests
R=ken2
CC=golang-dev
https://golang.org/cl/2345041
2010-10-01 00:18:07 -04:00
Andrew Gerrand
03babfc626 Use Errorf where appropriate.
R=r, r2
CC=golang-dev
https://golang.org/cl/2308043
2010-10-01 14:14:18 +10:00
Andrew Gerrand
558477eeb1 fmt: add Errorf helper function
This crops up in a lot of places.
It's just a one-liner, but doesn't add any dependancies.
Seems worth it.

R=r, r2
CC=golang-dev
https://golang.org/cl/2344041
2010-10-01 14:04:55 +10:00
Ken Thompson
57858b70fb code gen error for
lv += f()
fixes asn1 and maybe more

R=rsc
CC=golang-dev
https://golang.org/cl/2341042
2010-09-30 18:02:38 -07:00
Russ Cox
52d619cfdf gc: bug308
confused by using isddd for both ONAME and OCALL

Fixes #1136.

R=ken2
CC=golang-dev
https://golang.org/cl/2314043
2010-09-30 15:05:01 -04:00
Russ Cox
779dfea487 gc: correct buffer size in sprint, add -L to show full paths
R=ken2
CC=golang-dev
https://golang.org/cl/2338041
2010-09-30 15:02:43 -04:00
Russ Cox
bee2d5b0ad gc, spec, tests: no auto-indirect of pointer to interface value
Implies no embedding of pointer to interface value either.

R=gri, iant, ken2, r, r2
CC=golang-dev
https://golang.org/cl/2289041
2010-09-30 14:59:41 -04:00
Russ Cox
6117652d8d libcgo: fix comment
R=r, r2
CC=golang-dev
https://golang.org/cl/2329042
2010-09-30 14:58:29 -04:00
Russ Cox
32b31342bd fix arm build on darwin leopard
TBR=r
CC=golang-dev
https://golang.org/cl/2333043
2010-09-30 14:48:33 -04:00
Russ Cox
7389ab8d21 runtime: serialize mcache allocation
Fixes racy regex-dna-parallel crashes.

R=r, r2
CC=golang-dev
https://golang.org/cl/2308042
2010-09-30 14:09:19 -04:00
Andrew Gerrand
f6a217827a tag release.2010-09-29
R=nigeltao, nigeltao_gnome
CC=golang-dev
https://golang.org/cl/2330041
2010-09-30 17:48:16 +10:00
Andrew Gerrand
ab5b4283f7 release.2010-09-29
R=golang-dev, nigeltao_gnome
CC=golang-dev
https://golang.org/cl/2329041
2010-09-30 17:33:07 +10:00
Andrew Gerrand
6b2c7ffbab doc: add to and consolidate non-english doc references
R=r, r2
CC=golang-dev
https://golang.org/cl/2315042
2010-09-30 13:43:09 +10:00
Stephen Ma
ae5cb2c581 http: fix http handler signature changes previously missed
R=adg, rsc
CC=golang-dev
https://golang.org/cl/2303041
2010-09-30 13:22:28 +10:00
Stephen Ma
a2332a32b8 doc: update http handler usage for new signature
R=adg, r2
CC=golang-dev
https://golang.org/cl/2302041
2010-09-30 13:19:33 +10:00
David Symonds
763cb8ad11 6prof: more accurate usage message.
R=r, r2
CC=golang-dev
https://golang.org/cl/2323042
2010-09-29 20:17:18 -07:00
Russ Cox
cf74232260 build: disable archive/zip on arm
R=adg
TBR=adg
CC=golang-dev
https://golang.org/cl/2326041
2010-09-29 23:11:00 -04:00
Andrew Gerrand
a00b98ec3f archive/zip: new package for reading ZIP files
R=rsc
CC=golang-dev
https://golang.org/cl/2125042
2010-09-30 11:59:46 +10:00
Andrew Gerrand
fdb9e68c4e misc/dashboard/builder: remove build files after benchmarking
R=r
CC=golang-dev
https://golang.org/cl/2270041
2010-09-30 11:59:36 +10:00
Andrew Gerrand
5ec55c5134 doc: faq updates part one
R=r, r2
CC=golang-dev
https://golang.org/cl/2301041
2010-09-30 11:23:39 +10:00
Robert Griesemer
686490ce17 install.html: minor sentence fix
R=r, r2
CC=golang-dev
https://golang.org/cl/2312041
2010-09-29 12:34:24 -07:00
Russ Cox
e642503d6f 6l, 8l: fix -K implementation
R=ken2
CC=golang-dev
https://golang.org/cl/2313041
2010-09-29 15:10:14 -04:00
Rob Pike
1edfb4cc75 Effective Go: update for new http interface.
R=rsc, stephenm
CC=golang-dev
https://golang.org/cl/2310041
2010-09-29 11:12:52 -07:00
Andrew Gerrand
4164d60cc2 doc: consolidate FAQs into a single file, go_faq.html
An entirely mechanical change, with these exceptions:
- removed 'stub questions' that reference the other FAQs
- removed "Why doesn't Go run on Windows yet?" - out of date

I will follow this CL with another that updates many of the
answers to make them more current.

R=r
CC=golang-dev
https://golang.org/cl/2300041
2010-09-29 16:52:22 +10:00
Stephen Ma
fd9a5d22c6 http: revised http Handler interface
R=rsc
CC=golang-dev
https://golang.org/cl/1993043
2010-09-29 14:30:12 +10:00
Russ Cox
ffdb855be1 build: clear custom variables like GREP_OPTIONS
Fixes #946.

R=r, r2
CC=golang-dev
https://golang.org/cl/2137048
2010-09-28 23:51:55 -04:00
Russ Cox
2f7a5b3379 arm: 10 more package tests pass
R=ken2
CC=golang-dev
https://golang.org/cl/2298041
2010-09-28 23:46:36 -04:00
Russ Cox
6a1ea00d59 gotest: leave _testmain.go for "make clean" to clean up
R=r, brainman
CC=golang-dev
https://golang.org/cl/2297041
2010-09-28 22:59:16 -04:00
Russ Cox
2278ef7e1a libcgo: don't build for NaCl
R=nigeltao
CC=golang-dev
https://golang.org/cl/2290041
2010-09-28 21:53:06 -04:00
Russ Cox
5b7e50a0aa runtime: fix freebsd build
TBR=r
CC=golang-dev
https://golang.org/cl/2296041
2010-09-28 21:37:12 -04:00
Ken Thompson
a2d2341e80 arm code gen error in unsign extend
R=rsc
CC=golang-dev
https://golang.org/cl/2295041
2010-09-28 18:12:46 -07:00
Russ Cox
81041369b2 runtime: fix build
On systems where the mmap succeeds
(e.g., sysctl -w vm.mmap_min_addr=0)
it changes the signal code delivered for a
nil fault from ``page not mapped'' to
``invalid permissions for page.''

TBR=r
CC=golang-dev
https://golang.org/cl/2294041
2010-09-28 20:50:00 -04:00
Russ Cox
649aab835f runtime: add mmap of null page just in case
R=r, iant, robert.swiecki, rsc1
CC=golang-dev
https://golang.org/cl/1904044
2010-09-28 20:30:01 -04:00
Russ Cox
9499856488 codereview: fix upload of hg copied file
Fixes #1134.

R=r, r2
CC=golang-dev
https://golang.org/cl/2264043
2010-09-28 20:29:20 -04:00
Robert Griesemer
5474e166bc go spec: clarifications for range clause
R=iant, r, rsc, rog
CC=golang-dev
https://golang.org/cl/2226047
2010-09-28 14:44:19 -07:00
Russ Cox
2ccbf83b32 6l, 8l: elfsetstring is only for .shstrtab
Was also recording for .dynstrtab which made the
table run out of space and would have caused confusion
if the ELF code tried to refer to any of the strings.

R=r
CC=golang-dev
https://golang.org/cl/2288041
2010-09-28 15:18:02 -04:00
Russ Cox
a400b0e7d7 json: do not write to unexported fields
Fixes #977.
Fixes #451.

R=r, r2
CC=golang-dev
https://golang.org/cl/2246049
2010-09-28 14:40:23 -04:00
Russ Cox
00ffd59c1a gc: fix reflect table method receiver
Fixes #451.
Fixes #770.

R=ken2
CC=golang-dev
https://golang.org/cl/2207045
2010-09-28 13:43:50 -04:00
Russ Cox
05cc83bf4e various: appease the ubuntu gcc monster
Silence warnings about not checking
return values from read and write system calls.

R=r, r2
CC=golang-dev
https://golang.org/cl/2258045
2010-09-28 13:00:13 -04:00
Russ Cox
ec13ed1fce gc: insert semicolon at EOF if needed
R=ken2, gri
CC=golang-dev
https://golang.org/cl/2208053
2010-09-28 10:35:02 -04:00
Charles L. Dorian
b233ac8f18 math: Fix off-by-one error in Ilogb and Logb.
Fixes #1141.

R=rsc
CC=adg, golang-dev
https://golang.org/cl/2194047
2010-09-28 10:15:21 -04:00
Robert Griesemer
0e66a13d10 go_spec: EOF may insert a semicolon
R=rsc, r, iant
CC=golang-dev
https://golang.org/cl/2266043
2010-09-27 18:59:11 -07:00
Brad Fitzpatrick
fbab1f1bad http: support HTTP/1.0 Keep-Alive
R=rsc, bradfitz1
CC=golang-dev
https://golang.org/cl/2261042
2010-09-27 21:55:04 -04:00
Russ Cox
5c3827cb9f http: correct escaping of different parts of URL
Fixes #1076.

R=adg
CC=golang-dev
https://golang.org/cl/2248045
2010-09-27 21:54:04 -04:00
Robert Griesemer
9ff4565e2b gofmt: stability improvement
There are a variety of token pairs that if printed
without separating blank may combine into a different
token sequence. Most of these (except for INT + .)
don't happen at the moment due to the spacing
introduced between expression operands. However, this
will prevent errors should the expression spacing
change.

R=rsc
CC=golang-dev
https://golang.org/cl/2207044
2010-09-27 15:03:15 -07:00
Robert Griesemer
20430f03bc go/scanner: treat EOF like a newline for purposes of semicolon insertion
R=rsc
CC=golang-dev
https://golang.org/cl/2216054
2010-09-27 12:39:55 -07:00
Rob Pike
b4e358d7e1 utf8.String: provide an Init method to avoid unnecessary allocation
when creating an array of Strings.

R=rsc
CC=golang-dev
https://golang.org/cl/2267046
2010-09-27 12:06:29 -07:00
Russ Cox
2d5e732c54 gc: eliminate duplicates in method table
Fixes #906.

R=ken2
CC=golang-dev
https://golang.org/cl/2279042
2010-09-27 14:09:10 -04:00
Russ Cox
7e92e1cbfa gc: fix non-canonical import error message
Fixes #1142.

R=ken2
CC=golang-dev
https://golang.org/cl/2218046
2010-09-27 12:59:26 -04:00