Russ Cox
ed62d27a52
template: two bug fixes / nits
...
* diagnose template not created with New
(current code just crashes)
* write []byte uninterpreted
(current code writes fmt format: "[65 65 65 65]")
R=r
CC=golang-dev
https://golang.org/cl/161075
2009-11-30 10:29:14 -08:00
Russ Cox
be32c6aaf5
codereview: allow editing of local CL description
...
between hg clpatch and hg submit.
R=r
https://golang.org/cl/162059
2009-11-30 10:28:48 -08:00
Russ Cox
1dc65e3aca
AUTHORS/CONTRIBUTORS: two more names
...
R=r, SnakE
CC=fhs, pts
https://golang.org/cl/162054
2009-11-30 10:28:31 -08:00
Fumitoshi Ukai
65112628dc
Fix example Makefile to avoid $GOROOT in case it has spaces.
...
R=rsc, sergio
https://golang.org/cl/162058
2009-11-29 21:22:05 -08:00
Russ Cox
be98bc488e
websocket: avoid $GOROOT in case it has spaces
...
Fixes #115 .
R=r, ukai, sergio
https://golang.org/cl/162057
2009-11-29 20:30:02 -08:00
Sergio Luis O. B. Correia
46892656c7
crypto/md4, exp/draw/x11: fix makefile to build when GOROOT has whitespaces
...
this is the exact same thing issue #115 is about. fix makefiles to use relative
path to work in the case we have whitespaces as part of GOROOT.
R=rsc
https://golang.org/cl/162055
2009-11-29 18:14:49 -08:00
Eden Li
354b100567
cgo: use C type void for opaque types if dwarf.Common().Type returns nothing
...
Ideally, the C name would come from the typedef or pointer that
references the Size<0 type, but we can't easily generate this without
performing a look-ahead to see if any referencing type will become opaque.
Fixes #334 .
Fixes #281 .
R=rsc
https://golang.org/cl/161056
2009-11-29 18:14:39 -08:00
Fumitoshi Ukai
f9f0184e13
Add WebSocket server framework hooked into http.
...
R=r, rsc
https://golang.org/cl/156071
2009-11-29 14:22:44 -08:00
Austin Clements
6e6125ffa4
Make comment-start/-end changes buffer-local instead of global.
...
Fixes #290 .
R=rsc
https://golang.org/cl/160070
2009-11-29 14:22:07 -08:00
Fumitoshi Ukai
770f3538c0
Add myself to CONTRIBUTORS
...
R=r, rsc
https://golang.org/cl/156070
2009-11-29 14:18:04 -08:00
Robert Griesemer
f3e0f214f8
Correct expression level for argument lists.
...
Fixes #352 .
R=rsc
https://golang.org/cl/161073
2009-11-29 14:11:52 -08:00
Rob Pike
b5358e0630
a few utf8 benchmarks. on my mac:
...
utf8_test.BenchmarkRuneCountTenASCIIChars 20000000 108 ns/op
utf8_test.BenchmarkRuneCountTenJapaneseChars 10000000 199 ns/op
utf8_test.BenchmarkEncodeASCIIRune 500000000 6 ns/op
utf8_test.BenchmarkEncodeJapaneseRune 100000000 10 ns/op
utf8_test.BenchmarkDecodeASCIIRune 100000000 13 ns/op
utf8_test.BenchmarkDecodeJapaneseRune 100000000 21 ns/op
R=gri
CC=golang-dev
https://golang.org/cl/161049
2009-11-25 13:30:30 -08:00
Rob Pike
773e77981d
rewrite RuneCountInString to use range.
...
R=gri
CC=golang-dev
https://golang.org/cl/160069
2009-11-25 11:39:34 -08:00
Nigel Tao
f65427a8be
Initial exp/draw/x11 implementation.
...
This provides an experimental X11 backend for the exp/draw interface.
It does not aim to provide a complete implementation of the X11 client protocol.
This works for me (Ubuntu Hardy 8.04, GOARCH=386). Your mileage my vary.
R=r, rsc, r1
CC=golang-dev
https://golang.org/cl/156109
2009-11-25 18:31:34 +11:00
Rob Pike
a0c55432f3
fix weird all.bash failures by running deps.bash before make clean runs in pkg directory.
...
before this change, if pkg/Make.deps is missing or broken, clean.bash fails and the build dies
but not until much later.
add freebsd to error message about valid values of $GOOS
TODO: would be nice if this process exited when an error occurred. subshells make it hard
R=rsc
CC=golang-dev
https://golang.org/cl/160065
2009-11-24 21:07:05 -08:00
Robert Griesemer
28f1914023
Handle presence of illegal semicolon after package clause better.
...
R=r, r1
https://golang.org/cl/157167
2009-11-24 17:34:08 -08:00
Robert Griesemer
a38ec58df0
Replace sort.Sort call with heapify algorithm in Init.
...
Fixed package comment.
Renamed some variables for symmetry, added more internal comments and more tests.
Fixes #304 .
R=rsc
https://golang.org/cl/157166
2009-11-24 17:20:13 -08:00
Russ Cox
b7c4314ecb
gc: correct type check for x, ok map assignment
...
Fixes #288 .
R=ken2
https://golang.org/cl/157162
2009-11-24 16:11:48 -08:00
Russ Cox
6c827cb412
make.bash: clear CDPATH to avoid output from cd
...
Fixes #306 .
R=r, r1
https://golang.org/cl/160060
2009-11-24 16:01:35 -08:00
Rob Pike
53ab6a0ad1
add freebsd to the list of os'es.
...
make the GOOS/GOARCH pair a table to avoid the confusion caused when it was of the form linux/386.
R=rsc
CC=golang-dev
https://golang.org/cl/160061
2009-11-24 16:00:19 -08:00
Ken Thompson
bd80b5a835
test case for large angles in trig functions
...
R=rsc
https://golang.org/cl/157160
2009-11-24 15:42:46 -08:00
Ken Thompson
b2bc1db9ac
bad sin/cos for large angles.
...
fixes #326 .
R=rsc
https://golang.org/cl/160059
2009-11-24 15:01:44 -08:00
Rob Pike
eb33c0bb35
timing log update for new version of chameneos
...
R=rsc
CC=golang-dev, rog
https://golang.org/cl/160054
2009-11-24 14:19:43 -08:00
Robert Griesemer
c6f8df0827
fix for broken build (built-in new was invisible due to a parameter called 'new')
...
R=iant
https://golang.org/cl/160057
2009-11-24 14:11:53 -08:00
Rob Pike
2cbeb1dbb1
change the rules for maintaining AUTHORS and CONTRIBUTORS files.
...
the current system is too painful, so instead let's just have the coders tell us the details.
we can update the files ourselves.
R=rsc, r1
CC=golang-dev
https://golang.org/cl/157158
2009-11-24 14:04:43 -08:00
Robert Griesemer
001a8b11ff
Change to container/vector interface:
...
- removed New(len int) in favor of new(Vector).Resize(len, cap)
- removed Init(len int) in favor of Resize(len, cap)
- runs all.bash
Fixes #294 .
R=rsc, r, r1
https://golang.org/cl/157143
2009-11-24 13:43:18 -08:00
Ian Lance Taylor
568465a931
Mention golang-dev as a default code review destination.
...
R=rsc
CC=r
https://golang.org/cl/160056
2009-11-24 13:36:54 -08:00
Russ Cox
7c9acae2f1
godoc: plug file descriptor leak
...
R=gri
CC=r
https://golang.org/cl/157149
2009-11-24 13:21:14 -08:00
Michael Hoisie
9da8d88499
A quick fix to ensure that json.Marshal returns errors correctly, as well as some error-related tests
...
R=rsc
https://golang.org/cl/157151
2009-11-24 13:18:44 -08:00
Russ Cox
5f484ec118
http: redirect to correct URL
...
R=r, r1
https://golang.org/cl/157154
2009-11-24 11:47:53 -08:00
Roger Peppe
9f17353250
chameneosredux test modified, bug fixed, faster
...
based on suggestion from arvindht@gmail.com
R=r, rsc, r1
https://golang.org/cl/157091
2009-11-24 11:45:30 -08:00
Russ Cox
541eeb8dbc
add Roger Peppe to AUTHORS/CONTRIBUTORS
...
R=r
https://golang.org/cl/157157
2009-11-24 11:33:43 -08:00
Michael Elkins
b320cf5bf4
add Take, TakeWhile, Drop, DropWhile to exp/iterable
...
R=dsymonds1, rsc
https://golang.org/cl/156079
2009-11-24 11:31:11 -08:00
Michael Elkins
43ffcdcbc3
Adding myself to AUTHORS/CONTRIBUTORS as a result of https://golang.org/cl/156079
...
R=golang-dev, rsc
CC=r
https://golang.org/cl/157072
2009-11-24 11:29:51 -08:00
Rob Pike
c14e265c59
print error's string when panicking.
...
R=rsc
https://golang.org/cl/157156
2009-11-24 10:55:50 -08:00
Trevor Strohman
f586870ec2
Add benchmarks for commonly used routines.
...
R=rsc, r, r1
https://golang.org/cl/160046
2009-11-24 00:21:50 -08:00
Eden Li
a9d0da75f1
cgo translates empty function arguments into void instead of dying with 'unexpected type: ...'.
...
Fixes #162 .
R=rsc
https://golang.org/cl/157147
2009-11-23 22:02:12 -08:00
Russ Cox
c95c27a91f
json: expose map in generic representation
...
R=r, r1
https://golang.org/cl/157146
2009-11-23 18:11:00 -08:00
Chris Lennert
8ebd7f7167
Provides implementation of MD4 hashing algorithm.
...
See IETF RFC 1320, http://tools.ietf.org/html/rfc1320 .
Fixes #279 .
R=rsc
https://golang.org/cl/159051
2009-11-23 17:44:44 -08:00
Chris Lennert
c833a57dac
Added my name to the AUTHORS and CONTRIBUTORS lists.
...
R=rsc
https://golang.org/cl/160047
2009-11-23 17:44:38 -08:00
Rob Pike
bdecae9e00
add an FAQ entry about the logo and mascot
...
R=rsc
CC=golang-dev, reneefrench
https://golang.org/cl/157144
2009-11-23 17:34:23 -08:00
Sergio Luis O. B. Correia
6fc820729e
go: makes it build for the case $GOROOT has whitespaces
...
the bash scripts and makefiles for building go didn't take into account
the fact $GOROOT / $GOBIN could both be directories containing whitespaces,
and was not possible to build it in such a situation.
this commit adjusts the various makefiles/scripts to make it aware of that
possibility, and now it builds successfully when using a path with whitespaces
as well.
Fixes #115 .
R=rsc, dsymonds1
https://golang.org/cl/157067
2009-11-23 17:32:51 -08:00
Sergio Luis O. B. Correia
2b1133ff86
cmd/cc: change getquoted() to accept whitespaces.
...
getquoted() currently checks for whitespaces and returns nil
if it finds one. this prevents us from having go in a path
containing whitespaces, as the #pragma dynld directives are
processed through the said function.
this commit makes getquoted() accept whitespaces, and this is
also needed for solving issue #115 .
R=rsc
https://golang.org/cl/157066
2009-11-23 16:00:26 -08:00
Russ Cox
edf7485a6e
gofmt -r: documentation and minor fixes
...
fix a few paren insertion bugs in the printer too.
R=gri, r
CC=golang-dev
https://golang.org/cl/157119
2009-11-23 15:44:27 -08:00
Vish Subramanian
9e95d970cc
Fix crash in xml.Unmarshal. Occasionally while running a scrape of some xml with many goroutines
...
I see a crash with the following stack trace:
SIGSEGV: segmentation violation
Faulting address: 0x44
PC=0x44e510
runtime·mapaccess2+0x18 /home/vish/go/src/pkg/runtime/hashmap.c:790
runtime·mapaccess2(0x0, 0x0)
xml·*Parser·text+0x922 /home/vish/go/src/pkg/xml/xml.go:765
xml·*Parser·text(0xe44c9870, 0x7fa3, 0xffffffff, 0x7f00, 0x44b5c4, ...)
xml·*Parser·RawToken+0x174 /home/vish/go/src/pkg/xml/xml.go:405
xml·*Parser·RawToken(0xe44c9870, 0x7fa3, 0x0, 0x0)
xml·*Parser·Token+0x625 /home/vish/go/src/pkg/xml/xml.go:205
xml·*Parser·Token(0xe44c9870, 0x7fa3, 0x0, 0x0, 0x0, ...)
xml·*Parser·Skip+0x27 /home/vish/go/src/pkg/xml/read.go:371
xml·*Parser·Skip(0xe44c9870, 0x7fa3, 0x8, 0x0)
xml·*Parser·unmarshal+0xae6 /home/vish/go/src/pkg/xml/read.go:328
xml·*Parser·unmarshal(0xe44c9870, 0x7fa3, 0xe8127120, 0x7fa3, 0xdc94bc40, ...)
xml·Unmarshal+0xda /home/vish/go/src/pkg/xml/read.go:121
xml·Unmarshal(0xe65724b0, 0x7fa3, 0xdc94bc00, 0x7fa3, 0x4bcfc0, ...)
scraper·DoSearch+0x3d1 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scraper.go:95
scraper·DoSearch(0xe7dc28c0, 0x7fa3, 0x33, 0x3, 0x6d2510, ...)
main·scrapeQueries+0x202 /home/vish/my-go-src/google3/experimental/users/vish/go_http/scrape.go:251
main·scrapeQueries(0xe7da2600, 0x7fa3, 0x64, 0x1db0, 0xe7e10000, ...)
goexit /home/vish/go/src/pkg/runtime/proc.c:135
goexit()
0x7fa3e7da2600 unknown pc
Clearly xml.Parser is accessing an uninitialized map. Add a check for a nil map before accessing it.
R=r, rsc
https://golang.org/cl/159050
2009-11-23 14:26:30 -08:00
Russ Cox
e69f12ae1d
two more if(h<0) that gcc 4.3 -O2 miscompiles
...
R=r
https://golang.org/cl/160044
2009-11-23 14:23:14 -08:00
Russ Cox
b90f673290
io.ReadWriter: fix doc comment (ReadWrite -> ReadWriter)
...
R=r
CC=eds
https://golang.org/cl/160045
2009-11-23 14:22:56 -08:00
Rob Pike
3b7f552fbb
fix bug in prefix code: must stop one character before any potential match of an empty string
...
Fixes #308 .
R=rsc
CC=golang-dev
https://golang.org/cl/157142
2009-11-23 14:06:21 -08:00
Rob Pike
b050a1b223
Fix doc striing for NewReadLogger.
...
Fixes #315 .
R=rsc
https://golang.org/cl/157140
2009-11-23 13:51:10 -08:00
Russ Cox
dc30800c28
8g: call throwindex for array out of bounds
...
R=ken2
https://golang.org/cl/160043
2009-11-23 12:58:28 -08:00