qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-24 22:27:57 -07:00
Code Releases Activity
7,444 Commits 58 Branches 402 Tags 522 MiB
ca5179d3f6
Commit Graph

77 Commits

Author SHA1 Message Date
Yasuhiro Matsumoto
3108f3f4a0 codereview: use cmd.communicate. 
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/4145046
 2011-02-08 22:30:06 -05:00
Yasuhiro Matsumoto
27191b558c codereview: fix hgpatch on windows 
R=rsc
CC=golang-dev
https://golang.org/cl/3989059
 2011-02-02 22:43:40 -05:00
Russ Cox
fdb46fb470 codereview: record repository, base revision 
Include repository URL in initial mail.
Record repository and base revision in patch description.

R=r
CC=golang-dev
https://golang.org/cl/4126052
 2011-02-02 16:39:31 -05:00
Russ Cox
dc9a02fa66 codereview: more ascii vs unicode nonsense 
R=r
CC=golang-dev
https://golang.org/cl/4124047
 2011-02-01 14:17:41 -05:00
Hector Chu
59a6395279 codereview: fix windows 
Uploading go files on Windows aborts with gofmt: exceptions.ValueError:
close_fds is not supported on Windows platforms if you redirect stdin/stdout/stderr

R=rsc, mattn, Joe Poirier
CC=golang-dev
https://golang.org/cl/4025046
 2011-01-24 14:16:24 -05:00
Russ Cox
17fc373af7 codereview: handle file patterns better 
If a file pattern is given and matches files that look
like they need to be hg added or hg removed, offer to do so.

If a file pattern is given and matches files in another CL, warn.

If a file pattern doesn't match anything, point that out.

Vet first line of CL description.

Fixes #972.

R=adg, niemeyer
CC=bradfitzgo, golang-dev
https://golang.org/cl/4099042
 2011-01-24 14:14:26 -05:00
Hector Chu
1e0efcd579 codereview: fix hg change on Windows 
hg change fails on Windows with 'No valid patches found in output from hg diff'.

R=rsc
CC=golang-dev
https://golang.org/cl/4006043
 2011-01-19 19:02:47 -05:00
Ryan Hitchman
30c85bf14c codereview: don't mail change lists with no files 
R=rsc
CC=golang-dev
https://golang.org/cl/3561041
 2011-01-19 14:46:06 -05:00
Eoghan Sherry
2f8ff0b81d codereview: keep quiet when not in use 
This prevents status messages from filling the
screen when using a command like 'hg log | less'.

R=rsc
CC=golang-dev
https://golang.org/cl/3666042
 2010-12-15 11:49:43 -05:00
Russ Cox
3b6ddd9bce codereview: more utf-8 nonsense 
To annoy hg: Μπορώ να φάω σπασμένα γυαλιά χωρίς να πάθω τίποτα.

R=r
CC=golang-dev
https://golang.org/cl/2900041
 2010-11-04 13:58:32 -04:00
Fazlul Shahriar
0e816f5972 codereview: fix 'hg sync' and 'hg download' in Python 2.7 
Fixes #1218.

R=rsc
CC=golang-dev
https://golang.org/cl/2664041
 2010-11-01 16:37:17 -04:00
Andrew Gerrand
f16b6b14d8 misc: update python scripts to specify python2 or nothing 
(Hopefully this changeset will notice my +x to googlecode_upload.py)

Fixes #1217.

R=rsc
CC=golang-dev
https://golang.org/cl/2634041
 2010-10-21 15:41:51 +11:00
Russ Cox
49bff2da22 codereview: disallow submit of *.[chys] files indented with spaces 
R=r
CC=golang-dev
https://golang.org/cl/2383041
 2010-10-06 18:10:23 -04:00
Russ Cox
9499856488 codereview: fix upload of hg copied file 
Fixes #1134.

R=r, r2
CC=golang-dev
https://golang.org/cl/2264043
 2010-09-28 20:29:20 -04:00
Russ Cox
b2a6558811 codereview: convert email address from Rietveld to lower case 
before looking for it in the CONTRIBUTORS file

R=r
CC=golang-dev
https://golang.org/cl/1883049
 2010-09-11 23:42:29 -04:00
Evan Shaw
9e162aa3be codereview: Fix uploading for Mercurial 1.6.3 
See:
http://selenic.com/repo/hg/rev/32b213b9b22c
http://selenic.com/repo/hg/rev/2096496b40ec

R=rsc, adg
CC=golang-dev
https://golang.org/cl/2072041
 2010-08-29 23:04:05 -04:00
Russ Cox
f7d87f355c codereview: speed upload 
Cuts time to upload trivial 160-file CL by 5x,
from 250 seconds to 50 seconds.

R=r
CC=golang-dev
https://golang.org/cl/1991047
 2010-08-26 18:56:29 -04:00
Russ Cox
3b226f9886 codereview: consistent indent, cut dead code 
End the charade (farce?) that we are using upload.py unaltered.
Cut all the unused stuff.
Indent using tabs to match the rest of the file.

Next: rewrite MercurialVCS to use mercurial package,
to avoid overhead of forking off a new hg command
multiple times for every file.  And parallelize upload.

R=gri
CC=golang-dev
https://golang.org/cl/2009046
 2010-08-26 18:24:14 -04:00
Russ Cox
4ae2b43ef2 codereview: fix hang on standard hg commands 
R=gri
CC=golang-dev
https://golang.org/cl/1950045
 2010-08-26 17:06:36 -04:00
Russ Cox
e3ac0b5d3f codereview: print status when hung 
After 30 seconds, start printing status updates,
so that we can see whether hg is making progress.

$ hg upload 1983051
Thu Aug 26 15:06:15 2010 running gofmt
Thu Aug 26 15:06:30 2010 inspecting src/pkg/big/int_test.go
Thu Aug 26 15:06:45 2010 inspecting src/pkg/cmath/conj.go
Thu Aug 26 15:07:00 2010 inspecting src/pkg/expvar/expvar.go
Thu Aug 26 15:07:15 2010 inspecting src/pkg/os/env_unix.go
Thu Aug 26 15:07:30 2010 inspecting src/pkg/os/sys_bsd.go
Thu Aug 26 15:07:45 2010 inspecting src/pkg/rand/rand_test.go
Thu Aug 26 15:08:00 2010 inspecting src/pkg/runtime/sig.go
Thu Aug 26 15:08:15 2010 inspecting src/pkg/time/time_test.go
Thu Aug 26 15:08:30 2010 inspecting src/pkg/websocket/websocket.go
Thu Aug 26 15:08:45 2010 uploading src/pkg/utf8/utf8.go
Thu Aug 26 15:09:00 2010 uploading src/pkg/unicode/letter_test.go
Thu Aug 26 15:09:15 2010 uploading src/pkg/xml/embed_test.go
Thu Aug 26 15:09:30 2010 uploading src/pkg/time/tick.go
Thu Aug 26 15:09:45 2010 uploading src/pkg/big/rat_test.go
Thu Aug 26 15:10:00 2010 uploading src/pkg/time/sleep_test.go
Thu Aug 26 15:10:15 2010 uploading src/pkg/patch/patch_test.go
Thu Aug 26 15:10:30 2010 uploading src/pkg/rand/rand.go
https://golang.org/cl/1983051

$

R=gri
CC=golang-dev
https://golang.org/cl/2020045
 2010-08-26 16:27:42 -04:00
Russ Cox
e63086548b codereview: really disable codereview when not available 
$ hg p
codereview disabled: cannot open /Users/rsc/g/go/src/pkg/goplan9.googlecode.com/hg/lib/codereview/codereview.cfg
$

R=dsymonds, r
CC=golang-dev
https://golang.org/cl/1998046
 2010-08-25 17:52:25 -04:00
Russ Cox
7886318ca0 codereview: do not send "Abanoned" mail if this CL has 
not been mailed out for review.

R=r
CC=golang-dev
https://golang.org/cl/1962046
 2010-08-12 14:58:38 -07:00
Ivan Krasin
e8b8aeb02a codereview.py: Fix issues with leading tabulation in the Files: section of CL description. 
R=imkrasin, rsc
CC=golang-dev
https://golang.org/cl/1943042
 2010-08-12 00:04:17 -07:00
Russ Cox
bbf925aa56 codereview: avoid crash if no config 
Fixes #959.

R=r
CC=golang-dev
https://golang.org/cl/1876045
 2010-07-26 17:33:50 -07:00
Russ Cox
08e65f79c1 codereview: make 'hg submit' work with Mercurial 1.6 
R=r
CC=golang-dev
https://golang.org/cl/1841044
 2010-07-16 18:54:38 -07:00
Russ Cox
ad665e4fde codereview: don't run gofmt with an empty file list 
R=gri
CC=golang-dev
https://golang.org/cl/1678054
 2010-07-15 16:43:06 -07:00
Evan Shaw
e8fcf60093 codereview: Fix for Mercurial >= 1.6 
R=rsc, adg, rsc1
CC=golang-dev
https://golang.org/cl/1804041
 2010-07-14 17:17:04 -07:00
Russ Cox
93f614ff86 codereview: allow multiple email addresses in CONTRIBUTORS 
R=r
CC=golang-dev
https://golang.org/cl/1650041
 2010-06-30 23:34:11 -07:00
Paolo Giarrusso
3ca72458ec codereview: avoid exception in match 
R=rsc
CC=golang-dev
https://golang.org/cl/1585041
 2010-06-09 21:37:11 -07:00
Peter Williams
1d6eb74697 codereview: work better with mq 
R=rsc
CC=golang-dev
https://golang.org/cl/1140043
 2010-05-24 14:37:00 -07:00
David Symonds
ee75ffa286 codereview: Mention that deleting a CL is a use of 'hg change' in its header. 
R=rsc
CC=golang-dev
https://golang.org/cl/903043
 2010-04-10 01:53:43 -07:00
Andrew Gerrand
e678afa891 codereview.py: fix for compatibility with hg >=1.4.3 
hg.parseurl now returns a two-value tuple; codereview.py expected 3.
Changed to merely take the first return value.

R=rsc, iant
CC=golang-dev
https://golang.org/cl/223087
 2010-03-03 09:03:31 +11:00
Russ Cox
4967f857d5 codereview: make sure each mail has a reviewer 
R=r
CC=golang-dev
https://golang.org/cl/196050
 2010-01-28 12:48:21 -08:00
Russ Cox
84b044e8fb codereview: correct handling of files created with hg cp 
R=r
CC=golang-dev
https://golang.org/cl/194118
 2010-01-27 16:14:11 -08:00
Russ Cox
ff7343f8d0 codereview: accommodate recent change to ui.prompt 
Fixes #525.

R=r
CC=golang-dev
https://golang.org/cl/190044
 2010-01-20 09:49:35 -08:00
Russ Cox
84ac357c79 codereview: split name list only on commas; some user names have spaces 
R=r
CC=golang-dev
https://golang.org/cl/184069
 2010-01-13 09:09:06 -08:00
Russ Cox
752b1702d0 codereview: do not send mail when submitting for others 
rename original_author to copied_from so that it reads
better when used as a condition.

R=r
CC=golang-dev
https://golang.org/cl/185045
 2010-01-09 09:47:14 -08:00
Russ Cox
1594730461 codereview: repeated hg mail sends "PTAL" 
also send out hg mail for TBR submits

R=r
CC=golang-dev
https://golang.org/cl/183137
 2010-01-07 18:23:30 -08:00
Russ Cox
8274742393 codereview: add golang-dev@googlegroups.com 
automatically in "hg mail".
also, avoid "empty list means all modified files in client" bug

R=gri, cw
CC=golang-dev
https://golang.org/cl/174072
 2009-12-15 13:36:05 -08:00
Hector Chu
31645cc0bb Ported godefs to Windows. 
R=rsc
https://golang.org/cl/164049
 2009-12-13 12:21:44 -08:00
Russ Cox
9a86cc679a codereview: do not gofmt deleted files 
R=r
https://golang.org/cl/164083
 2009-12-03 17:23:11 -08:00
Russ Cox
69f893a127 codereview: move reviewers to cc line after submit, 
so that the issue stops showing up on the
  per-reviewer dashboard page.

R=r
https://golang.org/cl/164075
 2009-12-02 09:10:59 -08:00
Devon H. O'Dell
e9a8ab031d lxml.etree is the wrong location for this alt package 
on my linux machine this is the correct one. lxml.etree
  exists with an ElementTree class, but does not contain
  an .XML method.

R=rsc
https://golang.org/cl/163082
 2009-12-02 08:18:26 -08:00
Devon H. O'Dell
742221d20b xml.etree can also be lxml.etree (e.g. CentOS 5.4 with Python 2.4.3) 
R=rsc
CC=golang-dev
https://golang.org/cl/164053
 2009-12-02 01:16:38 -08:00
Hector Chu
cd9d72ba9e Ports of lib9, libbio and libmach to Windows. 
R=rsc
https://golang.org/cl/157159
 2009-11-30 11:53:11 -08:00
Russ Cox
be32c6aaf5 codereview: allow editing of local CL description 
between hg clpatch and hg submit.

R=r
https://golang.org/cl/162059
 2009-11-30 10:28:48 -08:00
Russ Cox
19dae0799b gofmt -r 'α[β:len(α)] -> α[β:]' -w test/bench 
except chameneosredux which i know is being edited

require gofmt for test/bench

R=r
https://golang.org/cl/157110
 2009-11-20 13:11:42 -08:00
Russ Cox
caf15f855d codereview: handle UTF-8 in message descriptions 
what a terrible way to implement strings

R=r
https://golang.org/cl/156116
 2009-11-20 11:19:16 -08:00
Russ Cox
c614ffe946 codereview: make hg sync work with Mercurial 1.4 
R=r
https://golang.org/cl/157102
 2009-11-20 00:30:38 -08:00
Russ Cox
7db2c799ce codereview: more attempts at robustness in the face of unexpected exceptions 
R=r
https://golang.org/cl/156062
 2009-11-17 23:23:18 -08:00