mirror of
https://github.com/golang/go
synced 2024-11-21 09:54:44 -07:00
codereview: make sure each mail has a reviewer
R=r CC=golang-dev https://golang.org/cl/196050
This commit is contained in:
parent
2e989df0fb
commit
4967f857d5
@ -960,8 +960,16 @@ def mail(ui, repo, *pats, **opts):
|
||||
if err != "":
|
||||
return err
|
||||
cl.Upload(ui, repo, gofmt_just_warn=True)
|
||||
if not cl.reviewer and not cl.cc:
|
||||
return "no reviewers listed in CL"
|
||||
if not cl.reviewer:
|
||||
# If no reviewer is listed, assign the review to defaultcc.
|
||||
# This makes sure that it appears in the
|
||||
# codereview.appspot.com/user/defaultcc
|
||||
# page, so that it doesn't get dropped on the floor.
|
||||
if not defaultcc:
|
||||
return "no reviewers listed in CL"
|
||||
cl.cc = Sub(cl.cc, defaultcc)
|
||||
cl.reviewer = defaultcc
|
||||
cl.Flush(ui, repo)
|
||||
cl.Mail(ui, repo)
|
||||
|
||||
def nocommit(ui, repo, *pats, **opts):
|
||||
|
Loading…
Reference in New Issue
Block a user