Rob Pike
c7ec6ef859
case insensitive matching in CONTRIBUTORS file
...
R=rsc
https://golang.org/cl/157043
2009-11-17 11:40:25 -08:00
Aron Nopanen
c51ee432d1
Make non-errored RPC calls return 'nil' error to caller.
...
Error information is carried from RPC server to client in the string
'Error' field of rpc.Response. An empty string is sent in the success
case. This empty string was being returned to the caller (of Client.Call
or Client.Go), resulting in a non-nil error response.
This change detects an empty-string Response.Error at the client, and
translates it into a nil value in Call.Error.
Tests updated to check error return in success cases.
R=r, rsc
https://golang.org/cl/154159
2009-11-17 11:29:02 -08:00
Aron Nopanen
3f00205a0a
Add myself to 'AUTHORS' and 'CONTRIBUTORS'
...
R=rsc, r
https://golang.org/cl/154175
2009-11-17 11:28:54 -08:00
Russ Cox
60df923916
codereview: discard \r characters (sigh)
...
R=r
https://golang.org/cl/157041
2009-11-17 09:08:54 -08:00
Sergio Luis O. B. Correia
bae4f5085e
cmd/cc: Fix -I switch to handle a path with blankspaces correctly
...
Currently, -I switch can't deal with a path containing spaces.
This commit simplify setinclude(), by removing the special case
of a string that had spaces. After this change, setinclude() will
merely add the given directories to the include path, if it does
not yet exist, and this approach works.
Will be needed for solving issue 115.
R=agl1, rsc, iant2, r
https://golang.org/cl/155059
2009-11-17 09:02:47 -08:00
Sergio Luis O. B. Correia
27c3147676
Add myself to list of AUTHORS/CONTRIBUTORS for Go.
...
R=rsc
https://golang.org/cl/154180
2009-11-17 09:02:41 -08:00
Russ Cox
1a2418f575
codereview: add clpatch --ignore_hgpatch_errors.
...
of limited utility but good for creating the metadata
for an AUTHORS/CONTRIBUTORS change even if
the patch doesn't apply cleanly.
R=r
https://golang.org/cl/154140
2009-11-17 08:47:48 -08:00
Russ Cox
b4586a7429
math: fix argument names in Atan2
...
(error introduced converting from arg1, arg2)
Fixes #220 .
R=r
https://golang.org/cl/156041
2009-11-17 08:39:56 -08:00
Russ Cox
c0e1ccf3ff
Make.pkg: have "make coverage" invoke 6cov with correct binary
...
Fixes #239 .
R=r
https://golang.org/cl/154176
2009-11-17 08:39:26 -08:00
Russ Cox
6e788e0f0f
net: enforce timeouts for ReadFrom/WriteTo
...
Fixes #153 .
R=r
https://golang.org/cl/154177
2009-11-17 08:39:17 -08:00
Russ Cox
a65bf95dd8
syscall: use correct pointer in recvfrom/sendto.
...
linux/386 stack trace: use 32-bit hex.
Fixes #159 .
R=r
https://golang.org/cl/154178
2009-11-17 08:39:04 -08:00
Devon H. O'Dell
152bfa03d8
Pass ui into PostMessage to avoid nasty/confusing exception
...
R=rsc
https://golang.org/cl/155079
2009-11-17 08:32:23 -08:00
Devon H. O'Dell
0489a260da
FreeBSD-specific porting work.
...
cgo/libmach remain unimplemented. However, compilers, runtime,
and packages are 100%. I still need to go through and implement
missing syscalls (at least make sure they're all listed), but
for all shipped functionality, this is done. Ship! ;)
R=rsc, VenkateshSrinivas
https://golang.org/cl/152142
2009-11-17 08:20:58 -08:00
Rob Pike
30b1b9a36a
Rework gobs to fix bad bug related to sharing of id's between encoder and decoder side.
...
Fix is to move all decoder state into the decoder object.
Fixes #215 .
R=rsc
CC=golang-dev
https://golang.org/cl/155077
2009-11-16 23:32:30 -08:00
Rob Pike
50c04132ac
fix bug causing empty strings to be become non-nil errors on client side of rpc connection.
...
R=rsc
CC=golang-dev
https://golang.org/cl/155078
2009-11-16 23:32:16 -08:00
Rob Pike
bcb46c8560
fix typo in Append return type
...
R=rsc
https://golang.org/cl/155058
2009-11-16 21:56:38 -08:00
Robert Griesemer
3c5dbb036b
bug218.go: testcase for issue 238
...
R=rsc
https://golang.org/cl/154172
2009-11-16 17:53:39 -08:00
Russ Cox
597b2a91a6
runtime: make signal handler work on 386
...
R=r
https://golang.org/cl/154171
2009-11-16 17:51:47 -08:00
Russ Cox
1ee83f851d
gc: change "can we const evaluate this" from blacklist to whitelist
...
R=ken2
https://golang.org/cl/155074
2009-11-16 17:40:47 -08:00
Russ Cox
44e51fad28
6l: fix divide by zero in glibc linker.
...
repeats 8l change http://code.google.com/p/go/source/detail?r=7594e16b5cf9
Fixes #179 .
R=iant
https://golang.org/cl/154145
2009-11-16 17:40:03 -08:00
Adam Langley
1cdfe9fa28
unsafe: documentation typo.
...
Fixes #236 .
R=r
CC=golang-dev
https://golang.org/cl/155072
2009-11-16 15:39:04 -08:00
Robert Griesemer
af872b2ba4
Add id attribute to h2 and h3 tags so that they exist when referring
...
to generated pages even if Javascript has not introduced them yet.
R=rsc
https://golang.org/cl/154167
2009-11-16 15:25:16 -08:00
Robert Griesemer
e86afaf456
Don't emit line tags when source code is printed as part of
...
package documentation using templates. The line tag interferes
with the anchor tag introduces by the template.
This fixes an an issue where some headers lost their ability
to link to the respective source code.
R=rsc
https://golang.org/cl/154166
2009-11-16 14:26:29 -08:00
David Symonds
affcfe5a75
Add some primitive type aliases to exp/iterable and define Iter on them.
...
R=rsc
https://golang.org/cl/155065
2009-11-16 13:39:59 -08:00
David G. Andersen
37f71e8ad6
An asked-for-in #go-nuts extension to quickly create a repeated
...
copy of a string or a byte array.
strings.Repeat("-", 50)
bytes.Repeat(b, 99)
R=rsc
https://golang.org/cl/155063
2009-11-16 12:40:01 -08:00
David G. Andersen
11c1aa9f6d
Adding my name to authors/contributors. I'm waiting to hear
...
back from Carnegie Mellon about whether they're interested in
signing the agreement (do you know if they have already?).
In the meantime, I'm submitting these changes on my own time.
If CMU has already signed the corporate contributor agreement,
please remove my name from the AUTHORS list.
R=rsc
https://golang.org/cl/154161
2009-11-16 12:39:37 -08:00
Kai Backman
c3cf8d663a
s/AJMP/AB/ to fix build breakage.
...
R=rsc
https://golang.org/cl/155069
2009-11-16 11:58:28 -08:00
Adam Langley
4085364a20
doc: fix typo.
...
Fixes #218
R=r
CC=golang-dev
https://golang.org/cl/155067
2009-11-16 11:56:18 -08:00
Robert Griesemer
d3b1565716
- Clarify that struct composite literal keys are field names not selectors.
...
- Slight re-phrasing of struct type section since "field name" was not
properly introduced.
Fixes #164 .
R=r, rsc, iant
https://golang.org/cl/155061
2009-11-16 08:58:55 -08:00
Robert Griesemer
0660d243b1
Use ElementType consistently.
...
Fixes #173 .
R=r, rsc, r1
https://golang.org/cl/154156
2009-11-15 17:42:27 -08:00
Russ Cox
ef46a9ddac
gc: fix up floating point NaN comparisons
...
Fixes #167 .
R=ken2
https://golang.org/cl/155062
2009-11-15 17:24:14 -08:00
Adam Langley
391e082ca9
crypto/md5: fix comment typo.
...
Fixes #210 .
R=rsc
CC=golang-dev
https://golang.org/cl/155057
2009-11-15 14:00:46 -08:00
Rob Pike
dc3b4932d8
add a paragraph about GOMAXPROCS
...
R=rsc
CC=golang-dev
https://golang.org/cl/154153
2009-11-15 13:09:43 -08:00
Russ Cox
39f64bed52
godefs: avoid gcc 4'isms in command line.
...
Fixes #97 .
R=r
https://golang.org/cl/155054
2009-11-15 12:57:39 -08:00
Russ Cox
dee5ad5c24
godocs.js: fix bad variable name
...
Thanks to anno.langen.
Fixes #103 .
R=r
https://golang.org/cl/155050
2009-11-15 12:57:33 -08:00
Russ Cox
cc3524fb06
makefiles: use correct gcc order in case --as-needed is in use.
...
Suggested by eostapets.
Fixes #141 .
R=r
https://golang.org/cl/155049
2009-11-15 12:57:28 -08:00
Russ Cox
0238fd836f
cgo: arrange for English error messages
...
Fixes #21 .
R=r
https://golang.org/cl/155048
2009-11-15 12:57:21 -08:00
Russ Cox
091191336a
runtime: avoid crash in Caller
...
Fixes #176 .
R=r
https://golang.org/cl/154146
2009-11-15 12:57:15 -08:00
Russ Cox
a338231526
gc: five bug fixes, one better error.
...
* check for struct literal assignment to private fields.
* record, fix crash involving parallel map assignment.
* avoid infinite recursion in exportassignok.
* make floating point bounds check precise.
* avoid crash on invalid receiver.
* add context to error about implicit assignment.
Fixes #86 .
Fixes #88 .
Fixes #158 .
Fixes #174 .
Fixes #201 .
Fixes #204 .
R=ken2
https://golang.org/cl/154144
2009-11-15 12:57:09 -08:00
Russ Cox
a967f57d19
http.URLEscape: escape all bytes required by RFC 2396
...
Fixes #125 .
R=r
https://golang.org/cl/154143
2009-11-15 12:56:50 -08:00
Russ Cox
2a6bb2c63e
gotest: show the test file pattern in "no test files" error
...
Fixes #190 .
R=r
https://golang.org/cl/154142
2009-11-15 12:56:39 -08:00
Rob Pike
029c39f45a
fix some typos in the documentation
...
Fixes #196 .
R=rsc
https://golang.org/cl/154152
2009-11-15 12:09:59 -08:00
Rob Pike
27779dd6cb
fix bug in bytes.Map and add test cases for Map in both strings and bytes packages.
...
thanks to ulrik.sverdrup for the test case.
Fixes #191 .
R=rsc
CC=golang-dev
https://golang.org/cl/155056
2009-11-15 12:07:27 -08:00
Robert Griesemer
13ad5d40c4
Use // to start comment instead of #.
...
Fixes #189 .
R=r
CC=rsc
https://golang.org/cl/155055
2009-11-15 11:33:20 -08:00
Russ Cox
b18bee948e
cc: drop redundant strcpy
...
Fixes #192 .
R=ken2
https://golang.org/cl/155047
2009-11-15 00:00:05 -08:00
Russ Cox
139a053733
cc: eliminate two fixed-size buffers
...
Fixes bug 168.
Alternative to https://golang.org/cl/152143 .
R=ken2
https://golang.org/cl/155042
2009-11-14 23:25:55 -08:00
Kai Backman
529216fa83
complain if GOARCH != arm. fix build break caused by gomake
...
introduction.
R=rsc
https://golang.org/cl/152109
2009-11-14 23:08:22 -08:00
Adam Langley
ad05d29103
crypto/rsa: handle the case of non-coprime blinds.
...
We are dealing with the multiplicative group ℤ/pqℤ. Multiples of
either p or q are not members of the group since they cannot have an
inverse. (Such numbers are 0 in the subgroup ℤ/pℤ.)
With p and q of typical size (> 512 bits), the probability of a random
blind [1..pq-1] being a multiple of p or q is negligible. However, in
the unit tests, much smaller sizes are used and the event could occur.
This change checks the result of the ext GCD and deals with this case.
It also increases the size of p and q in the unit test as a large
number of the keys selected were p, q = 227,169.
R=rsc
CC=golang-dev
https://golang.org/cl/154141
2009-11-14 20:38:00 -08:00
Kai Backman
8e5854ae17
make arm pass match what's working on real hardware
...
R=rsc
https://golang.org/cl/154097
2009-11-14 20:08:22 -08:00
Russ Cox
98811f41b8
test/interface/receiver.go: expand to do dynamic
...
versions of static checks in receiver1.go
R=r
https://golang.org/cl/155045
2009-11-14 19:28:13 -08:00