Adam Langley
f942736495
crypto/openpgp: truncate hashes before checking DSA signatures.
...
I didn't believe that OpenPGP allowed > SHA-1 with DSA, but it does and
so we need to perform hash truncation.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5510044
2012-01-09 16:57:51 -05:00
Rémy Oudompheng
f5d024a746
text/template: handle panic values that are not errors.
...
The recover code assumes that the panic() argument was
an error, but it is usually a simple string.
Fixes #2663 .
R=golang-dev, r, r, gri
CC=golang-dev, remy
https://golang.org/cl/5527046
2012-01-09 12:54:31 -08:00
Alexey Borzenkov
793768e9d5
encoding/gob: fix panic when decoding []byte to incompatible slice types
...
Fixes #2662 .
R=golang-dev, rogpeppe, r, r
CC=golang-dev, r, rogpeppe
https://golang.org/cl/5515050
2012-01-09 12:52:03 -08:00
Luuk van Dijk
41806ec26d
gc: remove now redundant typecheck of ->ninit on switches.
...
Fixes #2576 .
R=rsc
CC=golang-dev
https://golang.org/cl/5498105
2012-01-09 21:42:24 +01:00
Ian Lance Taylor
900b8becb3
cgo: if value for constant did not parse, get it from DWARF info
...
R=rsc, borman
CC=golang-dev
https://golang.org/cl/5525043
2012-01-09 11:22:26 -08:00
Robert Griesemer
b4be65bc7f
math/big: simplify fast string conversion
...
- use slice ops for convertWords instead of lo/hi boundaries
- always compute leading zeroes (simplifies logic significantly),
but remove them once, at the end (since leafSize is small, the
worst-case scenario is not adding significant overhead)
- various comment cleanups (specifically, replaced direct -> iterative,
and indirect -> recursive)
- slightly faster overall for -bench=String
(This CL incorporates the changes re: my comments to CL 5418047
https://golang.org/cl/5418047/ )
benchmark old ns/op new ns/op delta
big.BenchmarkString10Base2 519 527 +1.54%
big.BenchmarkString100Base2 2279 2158 -5.31%
big.BenchmarkString1000Base2 18475 17323 -6.24%
big.BenchmarkString10000Base2 178248 166219 -6.75%
big.BenchmarkString100000Base2 1548494 1431587 -7.55%
big.BenchmarkString10Base8 415 422 +1.69%
big.BenchmarkString100Base8 1025 978 -4.59%
big.BenchmarkString1000Base8 6822 6428 -5.78%
big.BenchmarkString10000Base8 64598 61065 -5.47%
big.BenchmarkString100000Base8 593788 549150 -7.52%
big.BenchmarkString10Base10 654 645 -1.38%
big.BenchmarkString100Base10 1863 1835 -1.50%
big.BenchmarkString1000Base10 12099 11981 -0.98%
big.BenchmarkString10000Base10 57601 56888 -1.24%
big.BenchmarkString100000Base10 20123120 19827890 -1.47%
big.BenchmarkString10Base16 358 362 +1.12%
big.BenchmarkString100Base16 815 776 -4.79%
big.BenchmarkString1000Base16 4710 4421 -6.14%
big.BenchmarkString10000Base16 43938 40968 -6.76%
big.BenchmarkString100000Base16 406307 373930 -7.97%
R=michael.jones, mtj
CC=golang-dev
https://golang.org/cl/5432090
2012-01-09 11:20:09 -08:00
Peter Mundy
834830d2bb
doc: use 2012 for year in model standard copyright header
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5531048
2012-01-09 10:47:28 -08:00
Florian Weimer
70ed0ac588
go-mode.el: fix syntax highlighting of backticks
...
Instead of syntax-tables, an extended go-mode-cs is used for
from a font-lock callback.
Cache invalidation must happen in a before-change-function
because font-lock runs in an after-change-function, potentially
before the cache invalidation takes place.
Performance is reasonable, even with src/pkg/html/entity.go
and test/fixedbugs/bug257.go.
Fixes #2330 .
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5529045
2012-01-09 12:58:29 -05:00
Russ Cox
8a4bd094a0
undo CL 5504108 / 0edee03791f4
...
breaks 386 build
««« original CL description
gc: put limit on size of exported recursive interface
Prevents edge-case recursive types from consuming excessive memory.
Fixes #1909 .
R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5504108
»»»
R=lvd, lvd
CC=golang-dev
https://golang.org/cl/5534049
2012-01-09 09:45:08 -08:00
Lorenzo Stoakes
aa63a928ea
gc: put limit on size of exported recursive interface
...
Prevents edge-case recursive types from consuming excessive memory.
Fixes #1909 .
R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5504108
2012-01-09 11:48:53 -05:00
Albert Strasheim
2cb6fcf63f
syscall: Linux-only support for parent death signal
...
As discussed in this thread:
https://groups.google.com/group/golang-dev/browse_thread/thread/5b76b7700265a787
I've tried to come up with a solution that is minimally invasive for the platforms that don't support "parent death signal", without splitting up exec_unix.go.
See also: http://www.win.tue.nl/~aeb/linux/lk/lk-5.html#ss5.8
R=rsc, dave, borman, iant, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5487061
2012-01-09 21:37:46 +09:00
Andrew Gerrand
468e692e38
doc: only trim newlines in tmpltohtml, gofmt progs
...
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5530048
2012-01-09 20:05:34 +11:00
Andrew Gerrand
c7e91724c0
go/build: handle and warn of duplicate GOPATH entries
...
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5519050
2012-01-09 14:24:05 +11:00
Andrew Gerrand
7478bb981a
doc: float -> float64 in Effective Go template
...
R=r, dsymonds
CC=golang-dev
https://golang.org/cl/5530047
2012-01-09 12:48:42 +11:00
Jeff R. Allen
b7f44e97a3
doc: float -> float64 in Effective Go
...
R=golang-dev
CC=golang-dev
https://golang.org/cl/5531046
2012-01-09 11:53:20 +11:00
Wei Guangjing
9569c67a6b
windows: use ArbitraryUserPointer as TLS slot
...
R=hectorchu, alex.brainman
CC=golang-dev
https://golang.org/cl/5519054
2012-01-09 11:23:07 +11:00
Florian Weimer
0448ce13a0
encoding/asn1: document support for *big.Int
...
Also add basic tests.
R=golang-dev
CC=golang-dev
https://golang.org/cl/5533045
2012-01-08 10:02:23 -05:00
Sameer Ajmani
1379d90651
time: fix godoc for After and NewTicker.
...
R=golang-dev, gri, bradfitz, iant
CC=golang-dev, rsc
https://golang.org/cl/5523049
2012-01-07 20:53:53 -05:00
Ryan Hitchman
a15448d65e
gc: improve unsafe.Pointer type-check error messages
...
Fixes #2627 .
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5498088
2012-01-06 14:34:16 -08:00
Sameer Ajmani
518872bf8f
A+C: add sameer@golang.org to CONTRIBUTORS.
...
R=gri
CC=golang-dev
https://golang.org/cl/5515052
2012-01-06 14:11:51 -08:00
Adam Langley
d4d5bd1bb7
Add Szabolcs Nagy as a contributor.
...
R=iant, gri
CC=golang-dev
https://golang.org/cl/5517056
2012-01-06 12:38:01 -05:00
Robert Griesemer
e36acdfb56
sort: eliminate extra Len() call
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5521052
2012-01-05 18:40:17 -08:00
Robert Hencke
a3baccefd6
various: fix prints
...
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516049
2012-01-05 18:38:01 -08:00
Andrew Gerrand
2c459f14e9
goinstall: fix test data
...
R=gri
CC=golang-dev
https://golang.org/cl/5519048
2012-01-06 09:48:03 +11:00
Eric Eisner
fd1322828c
cmd/go: Pass arguments to command for run
...
Command arguments are separated from input .go file arguments
by a -- separator.
R=rsc, golang-dev, adg
CC=golang-dev
https://golang.org/cl/5514046
2012-01-06 09:23:00 +11:00
Andrew Gerrand
9443949207
doc: add Slices: usage and internals article
...
Originally published on the Go blog on 5 Jan 2011:
http://blog.golang.org/2011/01/go-slices-usage-and-internals.html
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516046
2012-01-06 09:21:43 +11:00
Andrew Gerrand
c2ea412296
goinstall: use correct checkout URL for Google Code svn repos
...
Fixes #2655 .
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5510045
2012-01-06 09:20:59 +11:00
Andrew Gerrand
5353e1ef96
doc: trim spaces from code snippets
...
gofmt likes to put lines like
// STOP OMIT
two blank lines from a closing brace, creating an ugly space inside
<pre> blocks in some of these files. This change resolves this issue.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5520044
2012-01-06 09:20:31 +11:00
Roger Peppe
5f5a7eb4bc
go test: don't try to print package with error message.
...
If there's a error compiling a _test.go file, the error
message tries to print a *Package with %s. There's no String
method on *Package, so the error message looks bad.
Since the error messages identify the file in question
anyway, this CL removes the package from the error message.
R=rsc, gri
CC=golang-dev
https://golang.org/cl/5520045
2012-01-05 13:19:25 -08:00
Charles L. Dorian
149d3f06d8
math: fix typo in all_test.go
...
Logb errors were reported as Ilogb errors.
R=rsc, golang-dev, gri
CC=golang-dev
https://golang.org/cl/5517045
2012-01-05 11:04:14 -08:00
Mikio Hara
bab56ecb4d
net: fix incorrect mode on ListenIP, ListenUDP
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5523044
2012-01-05 09:44:25 -08:00
Jeff R. Allen
c581ec4918
crypto/tls: Improve TLS Client Authentication
...
Fix incorrect marshal/unmarshal of certificateRequest.
Add support for configuring client-auth on the server side.
Fix the certificate selection in the client side.
Update generate_cert.go to new time package
Fixes #2521 .
R=krautz, agl, bradfitz
CC=golang-dev, mikkel
https://golang.org/cl/5448093
2012-01-05 12:05:38 -05:00
Andrew Gerrand
8f1cb093ff
doc/progs: test defer programs
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5517044
2012-01-05 16:43:02 +11:00
Andrew Gerrand
2469a817ba
net: update DialIP comments to mention protocols
...
Fixes #2637 .
R=golang-dev, mikioh.mikioh, iant
CC=golang-dev
https://golang.org/cl/5508043
2012-01-05 15:18:08 +11:00
Alex Brainman
b682da32b3
make.bash: remove old dregs
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5522043
2012-01-05 14:17:32 +11:00
Sanjay Menakuru
2693232f16
cmd/go: include external test files in the files sent to gofmt, govet, and gofix
...
Also, add XTestGoFiles to the go command's public api.
Fixes #2649 .
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502102
2012-01-05 10:37:15 +11:00
Robert Griesemer
3f1eb94ef2
runtime: fix typo in comment
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5511047
2012-01-04 14:06:54 -08:00
Adam Langley
d5e6b8d016
crypto/tls: update generate_cert.go for new time package
...
Fixes #2635 .
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5512043
2012-01-04 14:56:16 -05:00
Dave Cheney
424f53fa0c
exp/ssh: fix two flow control bugs in chanWriter
...
This CL fixes two issues sending data to the remote peer.
The first bug occurs when the size of the buffer passed to
Write is larger than the current window, in this case, w.rwin
can become negative.
The second issue is more problematic than the first as the
amount of data passed to writePacket was not limited to w.rwin.
In this case the remote peer could silently drop the additional
data, or drop the connection.
Credit to Jacek Masiulaniec for the bug report.
R=agl, jacek.masiulaniec
CC=golang-dev
https://golang.org/cl/5511043
2012-01-04 10:36:21 -05:00
Andrew Gerrand
9d92676f63
unsafe: refer to correct reflect functions
...
Fixes #2641 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5509043
2012-01-04 17:14:56 +11:00
Paul Borman
dfedd34d4f
doc: Fix URL to the Xcode web page
...
R=golang-dev, kevlar
CC=golang-dev
https://golang.org/cl/5504113
2012-01-04 11:31:51 +11:00
Andrew Gerrand
126ee245c6
dashboard: increase notification log to 200 lines
...
The go command lists all packages that were built.
A recent breakage notification included this text:
$ tail -100 < log
ok errors
ok exp/ebnf
? exp/ebnflint [no test files]
ok exp/gotype
ok exp/norm
ok exp/spdy
If the breakage occurred before this point it would
not be visible in the output.
R=golang-dev, gri, kevlar
CC=golang-dev
https://golang.org/cl/5504109
2012-01-04 11:22:58 +11:00
Andrew Balholm
99fed2be27
html: parse <frameset> inside body
...
Pass tests6.dat, test 47:
<param><frameset></frameset>
| <html>
| <head>
| <frameset>
Also pass remaining tests in tests6.dat.
R=nigeltao
CC=golang-dev
https://golang.org/cl/5489136
2012-01-04 09:51:15 +11:00
Sanjay Menakuru
7ccd505dc4
cmd/go: include test files in the files sent to gofmt, govet, and gofix
...
Also, add TestGoFiles to the go command's public api.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5505083
2012-01-03 14:12:54 +11:00
Andrew Gerrand
12d4847263
A+C: add Sanjay Menakuru
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5504110
2012-01-03 14:10:12 +11:00
Evan Shaw
c20c09251c
encoding/json: don't marshal special float values
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5500084
2012-01-03 12:30:18 +11:00
Michael Shields
38ff98b4c6
encoding/xml: use strings.Reader in tests.
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502083
2012-01-03 12:22:02 +11:00
John DeNero
c2b87ce007
doc/codewalk/functions.xml: Fix broken function examples
...
I removed the broken function comparison example and fixed a code highlighting regexp.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501078
2012-01-03 12:15:08 +11:00
Christoph Hack
a274798d6e
cmd/go: refer to the right command in the doc description.
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501072
2012-01-03 12:06:12 +11:00
Benny Siegert
8e9e75f008
gotest: make _testmain.go conform to gofmt rules
...
Otherwise, running "gofmt -d ." after "gotest" gives some
spurious changes.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5504101
2012-01-03 12:00:39 +11:00