1
0
mirror of https://github.com/golang/go synced 2024-11-15 11:30:36 -07:00
Commit Graph

12960 Commits

Author SHA1 Message Date
Russ Cox
a2f13c8cf2 [release-branch.go1] cmd/gc: fix LEAQ $0, SI bug
««« backport c4a344d25b87
cmd/gc: fix LEAQ $0, SI bug

Cannot take effective address of constant.

Fixes #3670.

R=ken2
CC=golang-dev
https://golang.org/cl/6299055

»»»
2012-06-13 16:24:52 -04:00
Russ Cox
0d5061ac95 [release-branch.go1] cmd/gc: fix type checking loop
««« backport e69400ace361
cmd/gc: fix type checking loop

CL 4313064 fixed its test case but did not address a
general enough problem:

type T1 struct { F *T2 }
type T2 T1
type T3 T2

could still end up copying the definition of T1 for T2
before T1 was done being evaluated, or T3 before T2
was done.

In order to propagate the updates correctly,
record a copy of an incomplete type for re-execution
once the type is completed. Roll back CL 4313064.

Fixes #3709.

R=ken2
CC=golang-dev, lstoakes
https://golang.org/cl/6301059

»»»
2012-06-13 16:24:51 -04:00
Russ Cox
61364c1b97 [release-branch.go1] cmd/gc: delete dead code
««« backport 721d528a4e91
cmd/gc: delete dead code

R=ken2
CC=golang-dev
https://golang.org/cl/6307050

»»»
2012-06-13 16:24:50 -04:00
Russ Cox
a56e41d518 [release-branch.go1] cmd/gc: do not crash on struct with _ field
««« backport af07f1cd12dc
cmd/gc: do not crash on struct with _ field

Fixes #3607.

R=ken2
CC=golang-dev
https://golang.org/cl/6296052

»»»
2012-06-13 16:24:49 -04:00
Russ Cox
4bc9ddf82f [release-branch.go1] cmd/gc: preserve side effects during inlining of function with _ argument
««« backport 0ba8e27c7b87
cmd/gc: preserve side effects during inlining of function with _ argument

Fixes #3593.

R=ken2
CC=golang-dev, lvd
https://golang.org/cl/6305061

»»»
2012-06-13 16:24:49 -04:00
Russ Cox
dc0f7d6fde [release-branch.go1] encoding/json: fix panic unmarshaling into non-nil interface value
««« backport bee83c1509a3
encoding/json: fix panic unmarshaling into non-nil interface value

Fixes #3614.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6306051

»»»
2012-06-13 16:24:48 -04:00
Russ Cox
cec2715018 [release-branch.go1] cmd/gc: mark output of typename as type-checked
««« backport d39a44280dd3
cmd/gc: mark output of typename as type-checked

R=ken2
CC=golang-dev
https://golang.org/cl/6302051

»»»
2012-06-13 16:24:47 -04:00
Daniel Morsing
24ee3e4eef [release-branch.go1] fmt: fix doc typo
««« backport 76f136192aac
fmt: fix doc typo

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6308046

»»»
2012-06-13 16:24:46 -04:00
Russ Cox
0db7bc2ed8 [release-branch.go1] A+C: Daniel Morsing (individual CLA)
««« backport a47632179cb7
A+C: Daniel Morsing (individual CLA)

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6307048

»»»
2012-06-13 16:24:45 -04:00
Russ Cox
2ed8b2011d [release-branch.go1] A+C: Markus Sonderegger (individual CLA)
««« backport a6e2b17a16d7
A+C: Markus Sonderegger (individual CLA)

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6303047

»»»
2012-06-13 16:24:44 -04:00
Shenghou Ma
d261dc39aa [release-branch.go1] build: restore PATH before "dist banner"
««« backport 2787cca7ac8f
build: restore PATH before "dist banner"
        Fixes #3699.

R=golang-dev, r, rsc
CC=golang-dev
https://golang.org/cl/6272048

»»»
2012-06-13 16:24:44 -04:00
Dave Cheney
d4a15ab8ca [release-branch.go1] cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1
««« backport 9b455eb64690
cmd/5c, cmd/5g, cmd/5l: fix array indexing warning under Clang 3.1

This should be the last of them.

R=golang-dev, minux.ma, rsc
CC=golang-dev
https://golang.org/cl/6297043

»»»
2012-06-13 16:24:43 -04:00
Rémy Oudompheng
3a9bd603ed [release-branch.go1] cmd/[568]g: correct freeing of allocated Regs.
««« backport f1028a23b059
cmd/[568]g: correct freeing of allocated Regs.

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/6281050

»»»
2012-06-13 16:24:42 -04:00
Robert Griesemer
9f0345c4ec [release-branch.go1] go spec: clarify promotion rules for methods/fields of anonymous fields
««« backport ae0301294b9b
go spec: clarify promotion rules for methods/fields of anonymous fields

Fixes #3635.

R=rsc, r, iant, kevlar, iant
CC=golang-dev
https://golang.org/cl/6217045

»»»
2012-06-13 16:24:41 -04:00
Russ Cox
0508326926 [release-branch.go1] doc/install: we don't print 'The compiler is 6g' anymore
««« backport 008b163fb38a
doc/install: we don't print 'The compiler is 6g' anymore

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6273050

»»»
2012-06-13 16:24:40 -04:00
Ryan Barrett
1ba00e32da [release-branch.go1] misc/emacs: make compilation-mode's next-error understand test failure output.
««« backport f469c9d212c4
misc/emacs: make compilation-mode's next-error understand test failure output.

specifically, adds a go-test element to compilation-error-regexp-alist[-alist].
Fixes #3629.

R=golang-dev, rsc, sameer
CC=golang-dev, jba
https://golang.org/cl/6197091

»»»
2012-06-13 16:24:40 -04:00
Shenghou Ma
4c35c0b498 [release-branch.go1] api: add Linux/ARM to go1 API
««« backport 5538444d6f32
api: add Linux/ARM to go1 API
It's very unfortunate that the type of Data field of struct
RawSockaddr is [14]uint8 on Linux/ARM instead of [14]int8
on all the others.
btw, it should be [14]int8 according to my header files.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6275050

»»»
2012-06-13 16:24:39 -04:00
Mikio Hara
0a6b1d66f6 [release-branch.go1] path/filepath: fix test
««« backport 912fdfb20cc6
path/filepath: fix test

Make it possible to run test over symlinked GOROOT.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6268046

»»»
2012-06-13 16:24:38 -04:00
Alex Brainman
f384564778 [release-branch.go1] syscall: correct Win32finddata definition
««« backport 45d1063d8520
syscall: correct Win32finddata definition

Fixes #3685.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6261053

»»»
2012-06-13 16:24:37 -04:00
Shenghou Ma
47c317c50b [release-branch.go1] syscall: fix 32-bit uid calls
««« backport 31e36672e3df
syscall: fix 32-bit uid calls
        16-bit uid calls are not always supported in newer kernels.

R=dave, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6279047

»»»
2012-06-13 16:24:36 -04:00
Jan Mercl
c30e746666 [release-branch.go1] path/filepath: implement documented SkipDir behavior
««« backport 4ef88bab4b0d
path/filepath: implement documented SkipDir behavior

Currently walk() doesn't check for err == SkipDir when iterating
a directory list, but such promise is made in the docs for WalkFunc.

Fixes #3486.

R=rsc, r
CC=golang-dev
https://golang.org/cl/6257059

»»»
2012-06-13 16:24:35 -04:00
Brad Fitzpatrick
01faffd009 [release-branch.go1] api: add FreeBSD to go1 API
««« backport d8e47164f8dd
api: add FreeBSD to go1 API

Now that gri has made go/parser 15% faster, I offer this
change to slow back down cmd/api ~proportionately, adding
FreeBSD to the go1-checked set of platforms.

Really we should have done this earlier. This will prevent us
from breaking FreeBSD compatibility accidentally in the
future.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6279044

»»»
2012-06-13 16:24:34 -04:00
Ryan Barrett
8da546a3cf [release-branch.go1] misc/emacs: stop go-mode from spuriously marking the buffer modified when it loads
««« backport f0fc2ba71361
misc/emacs: stop go-mode from spuriously marking the buffer modified when it loads

R=golang-dev, sameer, bradfitz
CC=golang-dev, jba
https://golang.org/cl/6213056

»»»
2012-06-13 16:24:34 -04:00
Sameer Ajmani
95cffc1227 [release-branch.go1] CONTRIBUTORS: Add Ryan Barrett (Google CLA)
««« backport d7030ef36339
CONTRIBUTORS: Add Ryan Barrett (Google CLA)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6244071

»»»
2012-06-13 16:24:33 -04:00
Rob Pike
c558dc787d [release-branch.go1] regexp: fix a couple of bugs in the documentation
««« backport 97295af6ee9b
regexp: fix a couple of bugs in the documentation
Byte slices are not strings.

Fixes #3687.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6257074

»»»
2012-06-13 16:24:32 -04:00
Ivan Krasin
5fc093e3c0 [release-branch.go1] compress/flate: fix overflow on 2GB input. Reset hashOffset every 16 MB.
««« backport 00a1ca1ea3bd
compress/flate: fix overflow on 2GB input. Reset hashOffset every 16 MB.

This bug has been introduced in the following revision:

changeset:   11404:26dceba5c610
user:        Ivan Krasin <krasin@golang.org>
date:        Mon Jan 23 09:19:39 2012 -0500
summary:     compress/flate: reduce memory pressure at cost of additional arithmetic operation.

This is the review page for that CL: https://golang.org/cl/5555070/

R=rsc, imkrasin
CC=golang-dev
https://golang.org/cl/6249067

»»»
2012-06-13 16:24:31 -04:00
Mats Lidell
19af0b28c5 [release-branch.go1] go-mode: Works for both GNU-Emacs and XEmacs-21.5
««« backport 83f7ee1fa792
go-mode: Works for both GNU-Emacs and XEmacs-21.5

Fixes some portability issues between the Emacsen.

R=golang-dev, sameer, bradfitz, ryanb
CC=golang-dev
https://golang.org/cl/6206043

»»»
2012-06-13 16:24:30 -04:00
Sameer Ajmani
56ef99d910 [release-branch.go1] A+C: add Mats Lidell. He signed the agreement with the Sweden email
««« backport 700728feacc8
A+C: add Mats Lidell.  He signed the agreement with the Sweden email
address, but his changelist is under the Gmail address.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6248069

»»»
2012-06-13 16:24:30 -04:00
Jean-Marc Eurin
39c6f00c9a [release-branch.go1] misc/emacs: Use patch output of gofmt instead of replacing the buffer.
««« backport 6c2e9ed1f714
misc/emacs: Use patch output of gofmt instead of replacing the buffer.

This uses the patch output of gofmt (-d option) and applies each
chunk to the buffer, instead of replacing the whole buffer.  The
main advantage is that the undo history is kept across gofmt'ings,
so it can really be used as a before-save-hook.

R=sameer, sameer
CC=golang-dev
https://golang.org/cl/6198047

»»»
2012-06-13 16:24:29 -04:00
Rémy Oudompheng
f12183ff6a [release-branch.go1] runtime: do not unset the special bit after finalization.
««« backport 4a10c887bb3e
runtime: do not unset the special bit after finalization.

A block with finalizer might also be profiled. The special bit
is needed to unregister the block from the profile. It will be
unset only when the block is freed.

Fixes #3668.

R=golang-dev, rsc
CC=golang-dev, remy
https://golang.org/cl/6249066

»»»
2012-06-13 16:24:28 -04:00
Peter Kleiweg
c8ba37cf37 [release-branch.go1] Emacs go-mode: don't indent the inside of strings.
««« backport 8888febbe757
Emacs go-mode: don't indent the inside of strings.

Two fixes for indentation problems:

1. Properly recognize multi-line strings. These start with `, not ".

2. Don't indent a line if the beginning of the line is the end of a multi-line string. This happened for instance when inserting a closing bracket after a multi-line string.

R=sameer
CC=golang-dev
https://golang.org/cl/6157044

»»»
2012-06-13 16:24:27 -04:00
Dmitriy Vyukov
d0176e77e7 [release-branch.go1] time: fix deadlock in Sleep(0)
««« backport 085b20e6e0aa
time: fix deadlock in Sleep(0)
See time/sleep_test.go for repro.

R=golang-dev, r, rsc
CC=golang-dev, patrick.allen.higgins
https://golang.org/cl/6250072

»»»
2012-06-13 16:24:26 -04:00
Mikio Hara
35a1aa0420 [release-branch.go1] net: fix comment on FileListener
««« backport 3dfcac5f8254
net: fix comment on FileListener

R=rsc
CC=golang-dev
https://golang.org/cl/6242067

»»»
2012-06-13 16:24:26 -04:00
Peter Kleiweg
4fcdfe1eb6 [release-branch.go1] Emacs go-mode: fix Emacs freeze-up when copy/pasting from string or comment.
««« backport 798239220647
Emacs go-mode: fix Emacs freeze-up when copy/pasting from string or comment.

Fixes #3509.
Fixes #2767.

R=golang-dev, sameer
CC=golang-dev
https://golang.org/cl/6139066

»»»
2012-06-13 16:24:25 -04:00
Sameer Ajmani
90f1a852dc [release-branch.go1] A+C: Peter Kleiweg (individual CLA)
««« backport 771b60b029d4
A+C: Peter Kleiweg (individual CLA)

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6260049

»»»
2012-06-13 16:24:24 -04:00
Alexey Borzenkov
71b3ca0817 [release-branch.go1] net/http: reuse http proxy connections for different http requests
««« backport d0bc02d414c7
net/http: reuse http proxy connections for different http requests

Comment on cache keys above connectMethod says "http to proxy, http
anywhere after that", however in reality target address was always
included, which prevented http requests to different target
addresses to reuse the same http proxy connection.

R=golang-dev, r, rsc, bradfitz
CC=golang-dev
https://golang.org/cl/5901064

»»»
2012-06-13 16:24:23 -04:00
Alex Brainman
6835ec91dd [release-branch.go1] syscall: simplify text returned by Errno.Error() when FormatMessage fails
««« backport ac7250065a04
syscall: simplify text returned by Errno.Error() when FormatMessage fails

Fixes #3623.

R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/6218072

»»»
2012-06-13 16:24:22 -04:00
Russ Cox
920ebab03c [release-branch.go1] cmd/gc: fix parallel assignment in range
««« backport 2252777854d2
cmd/gc: fix parallel assignment in range

for expr1, expr2 = range slice
was assigning to expr1 and expr2 in sequence
instead of in parallel.  Now it assigns in parallel,
as it should.  This matters for things like
for i, x[i] = range slice.

Fixes #3464.

R=ken2
CC=golang-dev
https://golang.org/cl/6252048

»»»
2012-06-13 16:24:21 -04:00
Russ Cox
dfb11495b5 [release-branch.go1] runtime: handle and test large map values
««« backport 98488e2e38ee
runtime: handle and test large map values

This is from CL 5451105 but was dropped from that CL.
See also CL 6137051.

The only change compared to 5451105 is to check for
h != nil in reflect·mapiterinit; allowing use of nil maps
must have happened after that original CL.

Fixes #3573.

R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/6215078

»»»
2012-06-13 16:24:21 -04:00
Robert Griesemer
73052c1d6c [release-branch.go1] strconv: better documentation for FormatInt, FormatUint.
««« backport e2e4e44b1804
strconv: better documentation for FormatInt, FormatUint.

Fixes #3580.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6252047

»»»
2012-06-13 16:24:20 -04:00
Bill Thiede
c8e2ccdc9c [release-branch.go1] net/mail: more liberal parsing of Date headers.
««« backport e995a1bfe589
net/mail: more liberal parsing of Date headers.
Fixes #3639.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6243045

»»»
2012-06-13 16:24:19 -04:00
David Symonds
ce85383682 [release-branch.go1] C: Bill Thiede (Google CLA)
««« backport 2088c4af2ff8
C: Bill Thiede (Google CLA)

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6257050

»»»
2012-06-13 16:24:18 -04:00
Rob Pike
f5ef888ce9 [release-branch.go1] runtime: fix docs for Caller and Callers
««« backport 443c7a2dabe9
runtime: fix docs for Caller and Callers
The previous attempt to explain this got it backwards (all the more reason to be
sad we couldn't make the two functions behave the same).

Fixes #3669.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6249051

»»»
2012-06-13 16:24:17 -04:00
Russ Cox
84d3dc5a93 [release-branch.go1] cmd/gc: fix small integer bounds check bug
««« backport 967ae8baf398
cmd/gc: fix small integer bounds check bug

R=ken2
CC=golang-dev
https://golang.org/cl/6254046

»»»
2012-06-13 16:24:17 -04:00
Robert Griesemer
ea2a0ad508 [release-branch.go1] spec: clarify evaluation order of "i, x[i] = range ..."
««« backport 1c4d1ba268ca
spec: clarify evaluation order of "i, x[i] = range ..."

Part of fix for issue 3464.

R=golang-dev, rsc, mirtchovski, iant, r
CC=golang-dev
https://golang.org/cl/6246045

»»»
2012-06-13 16:24:16 -04:00
Shenghou Ma
b260999d4c [release-branch.go1] cmd/cc: fix uint right shift in constant evaluation
««« backport aa2d2fa1e5a9
cmd/cc: fix uint right shift in constant evaluation
        Fixes #3664.

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/6249048

»»»
2012-06-13 16:24:15 -04:00
David Symonds
536be05e32 [release-branch.go1] flag: include flag name in redefinition panic.
««« backport 64a249c65d51
flag: include flag name in redefinition panic.

R=golang-dev, rsc, r
CC=golang-dev
https://golang.org/cl/6250043

»»»
2012-06-13 16:24:14 -04:00
Brad Fitzpatrick
7de2fc41a2 [release-branch.go1] encoding/json: documentation fix
««« backport 258d7ab64d9a
encoding/json: documentation fix

Fixes #3650

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/6238046

»»»
2012-06-13 16:24:13 -04:00
Robert Griesemer
0d814d213e [release-branch.go1] go/parser: resolve all parameter types
««« backport 0a76445053e5
go/parser: resolve all parameter types

Fixes #3655.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6213065

»»»
2012-06-13 16:24:12 -04:00
Brad Fitzpatrick
88c11420a3 [release-branch.go1] cmd/api: add flag to specify contexts
««« backport 287685288ce1
cmd/api: add flag to specify contexts

I needed this to explore per-GOOS/GOARCH differences in pkg
syscall for a recent CL.  Others may find it useful too.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6236046

»»»
2012-06-13 16:24:12 -04:00