1
0
mirror of https://github.com/golang/go synced 2024-11-13 18:50:24 -07:00
Commit Graph

3959 Commits

Author SHA1 Message Date
Robert Griesemer
9e0d2fa89b better code for a copy loop
R=rsc
https://golang.org/cl/152046
2009-11-10 15:33:59 -08:00
Russ Cox
44fb865a48 default to codereview.appspot.com
R=r
http://codereview.prom.corp.google.com/1026040
2009-11-10 15:18:40 -08:00
Ken Thompson
c90d392ce3 spell it with an "e"
R=rsc
http://go/go-review/1025037
2009-11-10 15:05:15 -08:00
Russ Cox
8a902ed840 video is coming soon
R=r
http://go/go-review/1024049
2009-11-10 14:47:23 -08:00
Russ Cox
77da85564e delete old release tag 2009-11-10 14:15:36 -08:00
Russ Cox
1a177a711d tag for public release 2009-11-10 14:12:32 -08:00
Russ Cox
78c47c36b2 update video links
R=r
http://go/go-review/1024048
2009-11-10 14:09:01 -08:00
Robert Griesemer
b27f05f63b minor adjustments to package comments for better synopsis.
R=rsc
CC=r
http://go/go-review/1026038
2009-11-10 10:55:53 -08:00
Russ Cox
c9b5ca457d correct mailing list URL
R=r
http://go/go-review/1024047
2009-11-10 09:44:04 -08:00
Russ Cox
4414442442 remove internal references from doc/install.html
and doc/contribute.html.

add #go-nuts to help section on nav bar.

R=r
http://go/go-review/1025035
2009-11-10 09:37:03 -08:00
Russ Cox
b351113b50 make regexp comment not a package comment
R=r
http://go/go-review/1025036
2009-11-10 09:36:48 -08:00
Russ Cox
cb94b60cfb allow user agent to mention Go.
R=r
http://go/go-review/1024046
2009-11-10 09:10:08 -08:00
Ian Lance Taylor
cc6720aab7 Minor tweaks.
The text changes are trivial and may be ignored, but there are
two code corrections.

R=r, rsc
CC=go-dev
http://go/go-review/1024045
2009-11-10 00:09:53 -08:00
Rob Pike
6898f95dec make the titles of the FAQs match their links; adds clarity too. requested by rsc.
R=rsc
CC=go-dev
http://go/go-review/1025034
2009-11-09 23:54:35 -08:00
Robert Griesemer
a10e2051ae - add .. link to package directory listing, for easy traversal
- matches style of source file directory listing

R=rsc
http://go/go-review/1024044
2009-11-09 23:22:04 -08:00
Russ Cox
c9ac862aab in addition to bison, need to have gcc and c libraries installed.
R=r
http://go/go-review/1024043
2009-11-09 23:12:09 -08:00
Russ Cox
da776791c4 drop output from nilptr tests;
too hard to make it the same everywhere.
still checking for non-zero exit status though.

disable core files while running tests

R=r
http://go/go-review/1026037
2009-11-09 23:11:36 -08:00
Robert Griesemer
3d668c1b5d - minor cleanups
- better debugging support
- gofmt -l src misc | wc -l is 0

R=rsc
http://go/go-review/1024042
2009-11-09 22:30:07 -08:00
Robert Griesemer
3bb0032cd6 - replaced gofmt expression formatting algorithm with
rsc's algorithm
- applied gofmt -w misc src
- partial CL (last chunk)

R=rsc, r
http://go/go-review/1024041
2009-11-09 21:23:52 -08:00
Robert Griesemer
baba292998 - replaced gofmt expression formatting algorithm with
rsc's algorithm
	- applied gofmt -w misc src
	- partial CL (remaining files in other CLs)

R=rsc, r
http://go/go-review/1026036
2009-11-09 21:13:17 -08:00
Robert Griesemer
1698934194 - replaced gofmt expression formatting algorithm with
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)

R=rsc, r
http://go/go-review/1024040
2009-11-09 21:09:34 -08:00
Rob Pike
7685a67fe8 add a q&a about google's internal use of go
R=rsc
CC=go-dev
http://go/go-review/1026035
2009-11-09 20:25:45 -08:00
Russ Cox
1a821b32da noted by kaib: explicit assignment initialization
didn't match the composite literal initialization.

R=r
CC=kaib
http://go/go-review/1024039
2009-11-09 17:09:33 -08:00
Russ Cox
6c7f9f6340 add id tags to contribute.html
R=r
http://go/go-review/1025033
2009-11-09 16:56:17 -08:00
Robert Griesemer
c110269579 cleanup style:
- consistently remove all underbars from links
- this removes need for noline style
- removed unused info style

R=r, rsc
http://go/go-review/1025032
2009-11-09 16:19:38 -08:00
Rob Pike
0b4de7aa8a comment out red TODO clauses except for the last one
R=rsc
CC=go-dev
http://go/go-review/1024037
2009-11-09 16:09:57 -08:00
Russ Cox
9f42ccb781 error rewording suggested by robert.
update comment.

R=ken
http://go/go-review/1025031
2009-11-09 15:25:18 -08:00
Robert Griesemer
93c3f5124e make search box ever so slightly wider
R=rsc
http://go/go-review/1024036
2009-11-09 14:49:01 -08:00
Robert Griesemer
92743615fb TBR:
fix typo that prevented function bodies from being indexed (ouch!)

R=rsc
http://go/go-review/1024035
2009-11-09 14:44:16 -08:00
Robert Griesemer
fb5fce5532 fix for incorrect composite literal grammar
(issue found by ken)

R=go-dev, rsc
http://go/go-review/1025030
2009-11-09 12:35:56 -08:00
Robert Griesemer
40621d5c0d remove semis after statements in one-statement statement lists
R=rsc, r
http://go/go-review/1025029
2009-11-09 12:07:39 -08:00
Russ Cox
18ccbc69f8 tweak documentation of commands
so that first sentence is better for cmd page.

live at http://r45:3456/cmd/

R=gri, r
http://go/go-review/1024034
2009-11-09 11:45:15 -08:00
Robert Griesemer
81672e79e4 - rename Context to exprContext to remove it from public interface
(and to match the style of declContext)

R=rsc
http://go/go-review/1024033
2009-11-09 10:37:36 -08:00
Robert Griesemer
568c018fee make search box width dynamically sized
R=rsc, agl
http://go/go-review/1024032
2009-11-09 10:27:07 -08:00
Rob Pike
0c7e20ba67 delete commented-out section; details now covered elsewhere
R=rsc
CC=go-dev
http://go/go-review/1025028
2009-11-09 09:46:10 -08:00
Robert Griesemer
53f485813e fix for nodeSize computation, used to determine if
a node fits on one line:
- for purposes of measuring the node size in text,
  don't generate html or use a styler that could
  generate html as it will lead to overly large
  sizes

A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.

This change causes no difference to the gofmt formatting
of any files in src or misc.

R=rsc
http://go/go-review/1026034
2009-11-09 09:34:55 -08:00
Robert Griesemer
aae64f8c81 - exit godoc w/o crashing if negative tabwidth is provided
- minor related cleanups

R=rsc
http://go/go-review/1025026
2009-11-08 23:42:00 -08:00
Russ Cox
8b04ceff62 copy help section to install doc,
since most people won't get to the second one.

R=r
http://go/go-review/1024031
2009-11-08 23:38:30 -08:00
Russ Cox
bb097d4649 change highlight color from green to yellow
(fits better in the color scheme).

eliminate background color on line numbers at
bottom of search results, now that they are grouped.

live at http://r45:3456/search?q=Reader

R=r, gri
http://go/go-review/1024030
2009-11-08 23:37:46 -08:00
Robert Griesemer
d731dc8e72 Addressing issue brought up by dsymonds:
- When providing alternative spellings to a query, do not
  prefix it with a package qualifier as the suggestion may
  not have any results. Correctly filtering is quite a bit
  of work, and clicking the alternative spelling will always
  also show the qualified hits if they exist (but also others).
  Seems good enough for now.
- Give user feedback when the query syntax was wrong.
- Package names in search results are now links to the respective
  package documentation.
- Experimented with excluding main packages and test files
  from index with inconclusive results. Code is present and
  can be enabled by changing a flag in the source. This needs
  some more work.

R=rsc
CC=r, dsymonds
http://go/go-review/1026033
2009-11-08 23:34:08 -08:00
Russ Cox
71983af4a1 bug212, bug213.
R=ken
http://go/go-review/1026032
2009-11-08 23:22:06 -08:00
Russ Cox
b1a52ce4a3 make hg mail more forgiving:
create CL first, even if gofmt is needed
or no reviewers listed.

R=r
http://go/go-review/1025025
2009-11-08 22:13:10 -08:00
Russ Cox
6fff7b2399 mention license in install.html.
tighter nav list.

R=r
http://go/go-review/1024029
2009-11-08 22:12:51 -08:00
Rob Pike
0d93dbcf9b link the course slides from early in the tutorial
R=rsc
CC=go-dev
http://go/go-review/1026031
2009-11-08 22:03:12 -08:00
Rob Pike
d10f1547b0 make "Go for it" link to install.html.
delete the unnecessary "Programming in Go. Watch Now" from the right box.
center the video picture in the right box.

R=rsc
CC=go-dev
http://go/go-review/1025027
2009-11-08 22:02:15 -08:00
Rob Pike
e02f2b51c5 delete a pointless todo in all_test.go.
address one in rpc/client.go

R=rsc
CC=go-dev
http://go/go-review/1026030
2009-11-08 21:57:59 -08:00
Robert Griesemer
c532940ecf improved sentence extraction:
- don't forget first periods
- look at capitalization of last char before periods

R=rsc
http://go/go-review/1024027
2009-11-08 21:48:51 -08:00
Russ Cox
ed6eb5b577 a nagging inconsistency: capitalization of
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.

R=r
CC=go-dev
http://go/go-review/1024026
2009-11-08 21:46:20 -08:00
Russ Cox
830813f019 assorted cleanup
R=r, iant
CC=go-dev
http://go/go-review/1025024
2009-11-08 21:08:27 -08:00
Ian Lance Taylor
97a55a7485 Minor cleanups.
These are all fairly trivial and may be ignored.

R=r
CC=go-dev
http://go/go-review/1024025
2009-11-08 21:00:45 -08:00