Christopher Wedgwood
7600281bda
bytes: fix test output
...
R=rsc, gri
CC=golang-dev
https://golang.org/cl/5441048
2011-11-28 09:50:51 -08:00
Christopher Wedgwood
62203141ac
doc/tmptohtml: output fix
...
R=r, gri
CC=golang-dev
https://golang.org/cl/5441047
2011-11-28 09:50:40 -08:00
Dave Cheney
b57bb9282e
exp/ssh: add safeString error sanitiser
...
R=huin, agl, gustav.paul, cw
CC=golang-dev
https://golang.org/cl/5399044
2011-11-28 12:29:19 -05:00
Rémy Oudompheng
60e4a61d30
gc: don't inherit orig from subnodes in constant expression nodes.
...
The wrong value made Nconv() show "1" for node "-1", and "2" from
node "2+3".
Fixes #2452 .
R=gri, lvd, rsc
CC=golang-dev, remy
https://golang.org/cl/5435064
2011-11-28 12:22:15 -05:00
Dave Cheney
ce7e11997b
exp/ssh: fix three shift bugs related to packet lengths
...
Thanks for Ke Lan for the initial report and investigation.
R=agl, gustav.paul, tg8866, rsc
CC=golang-dev
https://golang.org/cl/5443044
2011-11-28 12:10:16 -05:00
Maxim Pimenov
ffa6b383f5
gc: fix copying of types
...
reset xmethod during copytype
Fixes #2497
R=rsc, dvyukov
CC=golang-dev
https://golang.org/cl/5441045
2011-11-28 11:52:16 -05:00
Brad Fitzpatrick
1e85f41fd5
http: fix sniffing bug causing short writes
...
R=rsc
CC=golang-dev
https://golang.org/cl/5442045
2011-11-28 11:51:34 -05:00
Russ Cox
7606079d9f
CONTRIBUTORS: add Maxim Pimenov (Google CLA)
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5443047
2011-11-28 11:47:23 -05:00
Brad Fitzpatrick
e77099daa2
sql: add Tx.Stmt to use an existing prepared stmt in a transaction
...
R=rsc
CC=golang-dev
https://golang.org/cl/5433059
2011-11-28 11:00:32 -05:00
Gustav Paul
23227f3d63
exp/ssh: fix misleading spelling mistake in comment
...
R=dave, agl, rsc, golang-dev
CC=golang-dev
https://golang.org/cl/5431089
2011-11-28 10:45:52 -05:00
Gustavo Niemeyer
a620865639
filepath/path: fix Rel buffer sizing
...
Fixes #2493 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5433079
2011-11-27 21:28:52 -05:00
Charles L. Dorian
f1fecf8d2a
math: fix typo in Log1p comments
...
Also note the special case of -0.0.
R=rsc, golang-dev, gri
CC=golang-dev
https://golang.org/cl/5435084
2011-11-27 18:01:08 -08:00
Andrew Balholm
68e7363b56
html: parse <nobr> elements
...
Pass tests3.dat, test 20:
<!doctype html><nobr><nobr><nobr>
| <!DOCTYPE html>
| <html>
| <head>
| <body>
| <nobr>
| <nobr>
| <nobr>
Also pass tests through test 22:
<!doctype html><html><body><p><table></table></body></html>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5438056
2011-11-28 10:55:31 +11:00
Michael T. Jones
4c113ffe16
math/big: use recursive subdivision for significant speedup
...
This change adds the second aspect to the conversion code, the
use of large divisiors (powers of big base) to greatly speed up
the divsion of large numbers. Speedups of 30x are common in the
large cases. Also includes new tests and tuning code for the
key internal parameters.
R=gri
CC=golang-dev
https://golang.org/cl/5438058
2011-11-27 11:10:59 -08:00
Gustav Paul
d859d7deee
exp/ssh: messages now contain remote channel's id instead of local id
...
According to http://www.ietf.org/rfc/rfc4254.txt most channel messages contain the channel id of the recipient channel, not the sender id. This allows the recipient connection multiplexer to route the message to the correct channel.
This changeset fixes several messages that incorrectly send the local channel id instead of the remote channel's id.
While sessions were being created and closed in sequence channels in the channel pool were freed and reused on the server side of the connection at the same rate as was done on the client, so the channel local and remote channel ids always corresponded. As soon as I had concurrent sessions on the same clientConn the server started to complain of 'uknown channel id N' where N is the local channel id, which is actually paired with server channel id K.
R=golang-dev, dave, rsc, agl
CC=golang-dev
https://golang.org/cl/5433063
2011-11-27 09:59:20 -05:00
Andrew Balholm
557ba72e69
html: ignore <head> tags in <head> element
...
Pass tests3.dat, test 12:
<!DOCTYPE html><HTML><META><HEAD></HEAD></HTML>
| <!DOCTYPE html>
| <html>
| <head>
| <meta>
| <body>
Also pass tests through test 19:
<!DOCTYPE html><html><head></head><body><ul><li><div><p><li></ul></body></html>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5436069
2011-11-27 14:41:08 +11:00
Rob Pike
e9025df7ad
text/template: rename the method Template.Template to Template.Lookup
...
Calling it Template makes it clumsy to embed the type, which html/template
depends on.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5432079
2011-11-26 08:32:55 -08:00
Alex Brainman
e38a1053a9
os: fail if Open("") is called on windows
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5432071
2011-11-26 11:01:49 +11:00
Benny Siegert
5519b5d716
exp/sql/driver: Correct package name in comment.
...
IIRC, package sql used to be called db. There was one occurrence
of the old name in a comment.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5431075
2011-11-25 10:57:10 -05:00
Brad Fitzpatrick
1f83c2b6d5
C+A: add Gustav Paul (individual CLA)
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5432076
2011-11-25 10:50:19 -05:00
Dmitriy Vyukov
a899a467f2
time: fix timer stop
...
Due to data structure corruption,
some timers could not be removed.
Fixes #2495 .
R=golang-dev, adg
CC=golang-dev, mdbrown
https://golang.org/cl/5437060
2011-11-25 14:13:10 +03:00
Andrew Gerrand
38c082f69e
html/template: fix documentation indent
...
R=nigeltao
CC=golang-dev
https://golang.org/cl/5437061
2011-11-25 13:32:44 +11:00
Andrew Gerrand
49dfaad870
dashboard: builder-facing implementation and tests
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5431048
2011-11-25 12:53:05 +11:00
Rob Pike
0197cc49ae
text/template: fix bug in Clone
...
Cloned template copied the root template incorrectly.
Add test of self-consistency.
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5436063
2011-11-24 16:07:19 -08:00
Rob Pike
d1324d8a7a
effective_go: remove unused variable from a couple of examples
...
Fixes #2481 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5435068
2011-11-24 08:51:47 -08:00
Scott Lawrence
0f0c25dccc
strings: Add ContainsAny and ContainsRune to correspond to IndexAny etc.
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5430046
2011-11-23 20:20:14 -08:00
Rob Pike
da62104169
gofix: trivial rewrite for template.ParseFiles
...
Also warn about uses of Set.
R=rsc
CC=golang-dev
https://golang.org/cl/5436051
2011-11-23 20:17:41 -08:00
Rob Pike
f56db6f534
text/template: new, simpler API
...
The Set type is gone. Instead, templates are automatically associated by
being parsed together; nested definitions implicitly create associations.
Only associated templates can invoke one another.
This approach dramatically reduces the breadth of the construction API.
For now, html/template is deleted from src/pkg/Makefile, so this can
be checked in. Nothing in the tree depends on it. It will be updated next.
R=dsymonds, adg, rsc, r, gri, mikesamuel, nigeltao
CC=golang-dev
https://golang.org/cl/5415060
2011-11-23 20:17:22 -08:00
Andrew Balholm
af081cd43e
html: ingore newline at the start of a <pre> block
...
Pass tests3.dat, test 4:
<!DOCTYPE html><html><head></head><body><pre>\n</pre></body></html>
| <!DOCTYPE html>
| <html>
| <head>
| <body>
| <pre>
Also pass tests through test 11:
<!DOCTYPE html><pre>

A</pre>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5437051
2011-11-24 13:15:09 +11:00
Robert Griesemer
63e48ccd8e
go/ast: trivial cleanup (remove superfluous string conversion)
...
R=iant, bradfitz
CC=golang-dev
https://golang.org/cl/5430059
2011-11-23 16:20:55 -08:00
Andrew Balholm
77b0ad1e80
html: parse DOCTYPE into name and public and system identifiers
...
Pass tests2.dat, test 59:
<!DOCTYPE <!DOCTYPE HTML>><!--<!--x-->-->
| <!DOCTYPE <!doctype>
| <html>
| <head>
| <body>
| ">"
| <!-- <!--x -->
| "-->"
Pass all the tests in doctype01.dat.
Also pass tests2.dat, test 60:
<!doctype html><div><form></form><div></div></div>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5437045
2011-11-24 09:28:58 +11:00
Robert Griesemer
b3923a27dd
go/printer, gofmt: more performance tweaks
...
Removed more string conversions and streamlined bottleneck
printing interface by removing unnecessary tests where possible.
About 6% faster AST printing.
Before:
- printer.BenchmarkPrint 50 32056640 ns/op
After:
- printer.BenchmarkPrint 50 30138440 ns/op (-6%)
R=r
CC=golang-dev
https://golang.org/cl/5431047
2011-11-23 09:27:38 -08:00
Rémy Oudompheng
8362ee99b0
fmt: don't check for nil when printing arrays as Go syntax.
...
Also add array values to printing test suite.
Fixes #2468 .
R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/5436053
2011-11-23 09:04:02 -08:00
Adam Langley
8281f6bd1b
crypto/openpgp/packet: fix private key checksum
...
I misinterpreted http://tools.ietf.org/html/rfc4880#section-5.5.3
and implemented the sum of 16-bit values, rather than the 16-bit sum
of 8-bit values.
Thanks to Szabolcs Nagy for pointing it out.
R=bradfitz, r, rsc
CC=golang-dev
https://golang.org/cl/5372091
2011-11-23 09:44:29 -05:00
Dave Cheney
f2c858749a
exp/ssh: add simple tcpip.go functional tests
...
R=rsc, agl, n13m3y3r, bradfitz
CC=golang-dev
https://golang.org/cl/5385041
2011-11-23 09:38:11 -05:00
Dave Cheney
d5514120b1
exp/ssh: remove unused forwarding methods in Server Listener
...
R=agl, rsc
CC=golang-dev
https://golang.org/cl/5436056
2011-11-23 09:35:01 -05:00
Robert Griesemer
4874d14180
go/printer: remove "written" result value - is never used
...
R=r
CC=golang-dev
https://golang.org/cl/5436052
2011-11-22 15:27:10 -08:00
Robert Griesemer
a0e54aaffa
go/printer, gofmt: 20 to 30% faster gofmt
...
Buffer intermediate output via a bytes.Buffer and thus avoid
calling through the entire Writer stack for every item printed.
There is more opportunity for improvements along the same lines.
Before (best of 3 runs):
- printer.BenchmarkPrint 50 47959760 ns/op
- time gofmt -l $GOROOT/src real 0m11.517s
After (best of 3 runs):
- printer.BenchmarkPrint 50 32056640 ns/op (= -33%)
- time gofmt -l $GOROOT/src real 0m9.070s (= -21%)
R=r
CC=golang-dev
https://golang.org/cl/5432054
2011-11-22 15:12:34 -08:00
Andrew Balholm
57ed39fd3b
html: on EOF in a comment, ignore final dashes (up to 2)
...
Pass tests2.dat, test 57:
<!DOCTYPE html><!--x--
| <!DOCTYPE html>
| <!-- x -->
| <html>
| <head>
| <body>
Also pass test 58:
<!DOCTYPE html><table><tr><td></p></table>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5436048
2011-11-23 09:26:37 +11:00
Andrew Gerrand
79bce499a3
dashboard: new Go dashboard data structure design
...
R=rsc, r, dsymonds, bradfitz
CC=golang-dev
https://golang.org/cl/5416056
2011-11-23 08:13:05 +11:00
Rob Pike
422e247332
tutorial: update go_tutorial.html
...
There's version skew with respect to the programs in doc/progs.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5433048
2011-11-22 11:53:30 -08:00
Russ Cox
fe838c2ddb
encoding/xml: fix copy bug
...
Fixes #2484 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5417059
2011-11-22 12:31:33 -05:00
Russ Cox
6e3e380923
allow direct conversion between string and named []byte, []rune
...
The allowed conversions before and after are:
type Tstring string
type Tbyte []byte
type Trune []rune
string <-> string // ok
string <-> []byte // ok
string <-> []rune // ok
string <-> Tstring // ok
string <-> Tbyte // was illegal, now ok
string <-> Trune // was illegal, now ok
Tstring <-> string // ok
Tstring <-> []byte // ok
Tstring <-> []rune // ok
Tstring <-> Tstring // ok
Tstring <-> Tbyte // was illegal, now ok
Tstring <-> Trune // was illegal, now ok
Update spec, compiler, tests. Use in a few packages.
We agreed on this a few months ago but never implemented it.
Fixes #1707 .
R=golang-dev, gri, r
CC=golang-dev
https://golang.org/cl/5421057
2011-11-22 12:30:02 -05:00
Russ Cox
c69d6345da
os: make ReadAt comment clearer
...
Fixes #2486 .
R=golang-dev, hanwen
CC=golang-dev
https://golang.org/cl/5417064
2011-11-22 12:22:28 -05:00
Dmitriy Vyukov
11e73b89ca
cgo: add support for callbacks from dynamic libraries
...
R=golang-dev, rsc
CC=golang-dev, mpimenov
https://golang.org/cl/5375042
2011-11-22 17:57:49 +03:00
Andrew Balholm
95e60acb97
html: copy attributes from extra <html> tags to root element
...
Pass tests2.dat, test 50:
<!DOCTYPE html><html><body><html id=x>
| <!DOCTYPE html>
| <html>
| id="x"
| <head>
| <body>
Also pass tests through test 56:
<!DOCTYPE html>X<p/x/y/z>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5432045
2011-11-22 12:08:22 +11:00
Andrew Balholm
750de28d6c
html: ignore whitespace before <head> element
...
Pass tests2.dat, test 47:
" \n "
(That is, two spaces separated by a newline)
| <html>
| <head>
| <body>
Also pass tests through test 49:
<!DOCTYPE html><script>
</script> <title>x</title> </head>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5422043
2011-11-22 09:27:27 +11:00
Andrew Gerrand
86c08e9611
goinstall: support googlecode subrepos and add repo match tests
...
goinstall: don't hit network unless a checkout or update is required
R=rsc, rogpeppe
CC=golang-dev
https://golang.org/cl/5343042
2011-11-22 07:10:25 +11:00
Adam Langley
7c161b05aa
crypto/x509, crypto/tls: support PKCS#8 private keys.
...
OpenSSL 1.0.0 has switched to generating PKCS#8 format private keys by
default. This change allows http.ListenAndServeTLS to work with either
types of keys.
See http://groups.google.com/group/golang-nuts/browse_thread/thread/84715b5f0c9e3c30/63a8a27b53e102a6
R=bradfitz
CC=golang-dev
https://golang.org/cl/5416059
2011-11-21 14:18:42 -05:00
Benny Siegert
85255f9942
bcrypt: Correct typo in package comment.
...
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5415062
2011-11-21 09:11:34 -08:00
