««« backport 3357d8d34ab8
encoding/gob: revert 6348067, which broke compatibility
Add commentary to explain better what's going on, but the
code change is a simple one-line reversal to the previous
form.
R=rsc
CC=golang-dev
https://golang.org/cl/6428072
»»»
««« backport 6d5faedd95bc
cmd/gc: reject use of ... with multiple-valued expressions.
Fixes#3334.
R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/6350103
»»»
««« backport 254232c99b3e
cmd/gc: avoid an internal error on invalid type switch.
The error was caused by a call to implements() even when
the type switch variable was not an interface.
Fixes#3786.
R=golang-dev, r
CC=golang-dev, remy
https://golang.org/cl/6354102
»»»
««« backport 46ca86e70e96
crypto/rsa: left-pad PKCS#1 v1.5 outputs.
OpenSSL requires that RSA signatures be exactly the same byte-length
as the modulus. Currently it'll reject ~1/256 of our signatures: those
that end up a byte shorter.
Fixes#3796.
R=golang-dev, edsrzf, r
CC=golang-dev
https://golang.org/cl/6352093
»»»
««« backport 8241ffc8686e
crypto/x509: exempt broken Entrust certificate from checks.
Entrust have issued a root certificate that's not marked as valid for
signing certificates.
This results in Go programs failing to validate certificates that
chain up to this root (i.e. gateway.push.apple.com:2195).
Although this is clearly a mistake on Entrust's part, it seems that we
will have to bodge around it.
R=golang-dev, dave, r
CC=golang-dev
https://golang.org/cl/6346064
»»»
««« backport ce3a981ad1ef
pkg: Removing duplicated words ("of of", etc.), mostly from comments.
Ran 'double.pl' on the pkg tree to identify doubled words.
One change to an error string return in x509; the rest are in comments.
Thanks to Matt Jibson for the idea.
R=golang-dev, bsiegert
CC=golang-dev
https://golang.org/cl/6344089
»»»
««« backport 21130d62eeb0
reflect: reflect.Zero results are neither addressable nor settable
This could be deduced from "The Laws of Reflection" but it seems
worthwhile highlighting it.
R=r
CC=golang-dev
https://golang.org/cl/6350073
»»»
««« backport c89f17a9ff4f
encoding/gob: fix bug in Register
The old code added a star but did not indirect the reflect.Type.
R=bradfitz
CC=golang-dev
https://golang.org/cl/6348067
»»»
««« backport be7e338a8960
doc/debugging_with_gdb: mention how to disable gc optimization
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6353055
»»»
««« backport c533f48701cb
math/big: Remove unnecessary test from nat.go multiplication
The switch at the beginning of the function already ensures n > 1,
so testing for n < 2 is redundant.
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/6350051
»»»
««« backport b5c4f411a852
cmd/gc: add missing case for OCOM in defaultlit()
Fixes#3765.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6349064
»»»
««« backport 650544a058e9
cmd/go: httpGet function does not use global variable httpClient
No change, just for consistency.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6346048
»»»
««« backport 3f7501fdb220
cmd/dist: Make windows.c's fatal() print to stderr
Generating env.bat using dist env -wp > env.bat failed silently
if case of an error, because the message was redirected to env.bat.
Verbose messages still go to stdout, causing problems, but that's
a seperate change.
Made errprintf() identical to xprintf(), except for the output handle.
Yes, it's duplicate code, but most of the function is unpacking
the argument list and preparing it for WriteFile(), which has to be
done anyway.
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/6343047
»»»
««« backport c5f564efc620
misc/emacs: Fix the gofmt patching when the TMPDIR is not the default.
The previous code assumed the gofmt output referred to /tmp but
that's not true if TMPDIR points somewhere else (like on Macs).
Fixes#3782.
R=sameer
CC=golang-dev
https://golang.org/cl/6346050
»»»
««« backport eb24cee7f21b
go spec: clean up section on selectors
- point out difference between selectors and qualified identifiers
- differentiate between illegal selectors and run-time panics
- use "indirect" as opposed to "dereference" consistently
- add extra links
Fixes#3779.
R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/6326059
»»»
««« backport d8bd45866999
go spec: clean up use of QualifiedIdent production.
Fixes#3763.
R=r, rsc, iant, ken
CC=golang-dev
https://golang.org/cl/6333066
»»»
««« backport c88692a626e9
A+C: L Campbell (individual CLA)
Guess I was wrong about being done for the day.
R=golang-dev, r
CC=golang-dev, unpantsu
https://golang.org/cl/6325060
»»»
««« backport 9da3902443ca
doc: drop video title from homepage
It's just stutter.
R=golang-dev, dsymonds, r
CC=golang-dev
https://golang.org/cl/6334053
»»»
««« backport ee62927ec779
A+C: Jonathan Gold (individual CLA)
This is my last one for today, I hope!
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6339052
»»»
««« backport e12419d09635
go/build: fix doc typo
go/build section "Build Constraints", first paragraph said:
"... they must be appear near the top of the file ..."
fixed to:
"... they must appear near the top of the file ..."
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6329060
»»»
««« backport 565770878659
A+C: Amir Mohammad Saied, Thomas Alan Copeland (both individual CLA)
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6330059
»»»
««« backport c72ac7873261
spec: clarify receive operator
- receiving from a closed channel returns immediately
- in the ,ok form, the 2nd result is of type bool, not
just boolean (gc and ggcgo agree).
Per dsymonds' suggestion.
R=r, rsc, ken, iant, dsymonds
CC=golang-dev
https://golang.org/cl/6333057
»»»
««« backport f99b9475b914
runtime: detect hash map collision problems
This can only happen if the hash function we're using is getting
far more than it's fair share of collisions, but that has happened
to us repeatedly as we've expanded the allowed use cases for
hash tables (issue 1544, issue 2609, issue 2630, issue 2883, issue 3695).
Maybe this will help the next time we try something new.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6306083
»»»
