1
0
mirror of https://github.com/golang/go synced 2024-11-12 02:50:25 -07:00
Commit Graph

12787 Commits

Author SHA1 Message Date
Russ Cox
5eb007dede runtime: work around false negative in deadlock detection
Not a complete fix for issue 3342, but fixes the trivial case.
There may still be a race in the instants before and after
a scavenger-induced garbage collection.

Intended to be "obviously safe": a call to runtime·gosched
before main.main is no different than a call to runtime.Gosched
at the beginning of main.main, and it is (or had better be)
safe to call runtime.Gosched at any point during main.

Update #3342.

R=iant
CC=golang-dev
https://golang.org/cl/5919052
2012-03-27 12:22:19 -04:00
Russ Cox
9d7076b178 cmd/go: respect $GOBIN always
Another attempt at https://golang.org/cl/5754088.

Before, we only consulted $GOBIN for source code
found in $GOROOT, but that's confusing to explain
and less useful.  The new behavior lets users set
GOBIN=$HOME/bin and have all go-compiled binaries
installed there.

Tested a few cases in test.bash.

Ran all.bash with and without $GOBIN and it works.
Even so, I expect it to break the builders,
like it did last time, we can debug from there.

Fixes #3269 (again).
Fixes #3396.
Fixes #3397.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5927051
2012-03-27 11:57:39 -04:00
Russ Cox
671862747e go/build: fix import check
When we find a package in DIR/src/foo, we only let it
be known as foo if there is no other foo in an earlier
GOPATH directory or the GOROOT directory.
The GOROOT check was looking in GOROOT/src/foo
instead of GOROOT/src/pkg/foo, which meant that
the import paths "lib9", "libbio", "libmach", and so
on were unavailable, and the import paths "math",
"errors", and so on were available.  Correct this.

Fixes #3390.

R=golang-dev, minux.ma
CC=golang-dev
https://golang.org/cl/5927050
2012-03-27 11:16:10 -04:00
Russ Cox
6b0929505b cmd/go: fix two bugs
Issue 3207 was caused by setting GOPATH=GOROOT.
This is a common mistake, so diagnose it at command start
and also correct the bug that it caused in get (downloading
to GOROOT/src/foo instead of GOROOT/src/pkg/foo).

Issue 3268 was caused by recognizing 'packages' that
had installed binaries but no source.  This behavior is not
documented and causes trouble, so remove it.  We can
revisit the concept of binary-only packages after Go 1.

Fixes #3207.
Fixes #3268.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5930044
2012-03-27 10:41:44 -04:00
Andrew Gerrand
14da5298cd doc: use relative links in Laws of Reflection article
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5924050
2012-03-27 20:53:16 +11:00
Andrew Gerrand
cafc2b6a24 doc: use relative links in draw package article
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5924051
2012-03-27 20:52:48 +11:00
Andrew Gerrand
d98507f1c4 doc: update wiki tutorial templates, and template discussion
Fixes #3384.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5915044
2012-03-27 16:07:46 +11:00
Alex Brainman
7a39654174 path/filepath: use windows GetShortPathName api to force GetLongPathName to do its work
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5928043
2012-03-27 15:53:08 +11:00
Russ Cox
d6c9af6a4e cmd/go: update for go1 tag format
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/5919048
2012-03-27 00:17:50 -04:00
Russ Cox
901ee5c151 cmd/dist: fix detection of go1 version
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5924044
2012-03-27 00:17:35 -04:00
Andrew Gerrand
c748689277 doc: update licensing text one more time
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5916046
2012-03-27 15:09:13 +11:00
Devon H. O'Dell
a63c37b91e net: ignore ECONNABORTED from syscall.Accept
Fixes #3395.

R=rsc, dsymonds
CC=golang-dev
https://golang.org/cl/5905063
2012-03-27 00:06:14 -04:00
Mikio Hara
4c2614c57c undo CL 5844051 / 5d0322034aa8
Breaks closure test when GOMAXPROCS=2 or more.

««« original CL description
runtime: restore deadlock detection in the simplest case.

Fixes #3342.

R=iant, r, dave, rsc
CC=golang-dev, remy
https://golang.org/cl/5844051

»»»

R=rsc
CC=golang-dev
https://golang.org/cl/5924045
2012-03-27 13:05:17 +09:00
Russ Cox
a3498f4be4 cmd/go: copy tag_test.go from goinstall
hg cat -r 11846 src/cmd/goinstall/tag_test.go >tag_test.go
No changes.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5919047
2012-03-26 23:44:30 -04:00
Ben Fried
bf9620ebbd misc/emacs: fix overindentation caused by mis-parsing lines ending with special chars
Fixes #3313

go-mode-backward-skip-comments is probably due for a more ambitious refactoring --- it repeats guard conditions after every nearly every movement of point.

R=sameer, r
CC=golang-dev
https://golang.org/cl/5844063
2012-03-26 23:26:39 -04:00
Rob Pike
b485629e47 C: add Ben Fried, Googler
R=golang-dev, dsymonds
CC=ben.fried, golang-dev
https://golang.org/cl/5869043
2012-03-26 23:26:28 -04:00
Rémy Oudompheng
84bb2547fb runtime: restore deadlock detection in the simplest case.
Fixes #3342.

R=iant, r, dave, rsc
CC=golang-dev, remy
https://golang.org/cl/5844051
2012-03-26 23:06:20 -04:00
Francisco Souza
603a44c50f doc: fix concurrency patterns rawhtml generation
The Makefile target was broken due to the rename of the HTML file.

R=golang-dev
CC=golang-dev
https://golang.org/cl/5918045
2012-03-27 14:03:46 +11:00
Andrew Gerrand
8d5b324afc doc: move /ref/cmd to /doc/cmd
Fixes #3400.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5926043
2012-03-27 13:46:16 +11:00
Francisco Souza
a786fe8e13 doc: add JSON-RPC: a tale of interfaces article
Originally published on The Go Programming Language Blog, Abril 27, 2010.

http://blog.golang.org/2010/04/json-rpc-tale-of-interfaces.html

R=adg, r
CC=golang-dev
https://golang.org/cl/5920044
2012-03-27 13:35:40 +11:00
Andrew Gerrand
308cc100e6 doc: update footer text
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5920043
2012-03-27 13:35:01 +11:00
Alex Brainman
cf13bd3fab path/filepath: convert drive letter to upper case in windows EvalSymlinks
Fixes #3347.

R=golang-dev, aram, r, rsc
CC=golang-dev
https://golang.org/cl/5918043
2012-03-27 12:56:56 +11:00
Andrew Gerrand
9031f952e2 doc: remove cov and prof from /ref/cmd
Update #3400

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5921044
2012-03-27 12:46:46 +11:00
Andrew Gerrand
849ad2d0ca cmd/godoc: canonicalize custom path redirects
For example, /ref and /doc/reference.html now both redirect to /ref/.

Fixes #3401.

R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5916044
2012-03-27 12:44:17 +11:00
Andrew Gerrand
98155bd6a9 doc: move gdb doc back to /doc/ and de-emphasize on references page
Fixes #3399.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5919044
2012-03-27 11:42:01 +11:00
Andrew Gerrand
11441285db doc: add doc/articles/index.html
Fixes #3402.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5923043
2012-03-27 11:40:17 +11:00
Andrew Gerrand
1b89d514d7 doc: describe the Windows MSI installer as experimental
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5921043
2012-03-27 11:19:30 +11:00
Yasuhiro Matsumoto
a3b86e9379 misc/goplay: fix error on IE8.
use cancelBubble=true instead of preventDefault().

R=golang-dev, rsc, adg
CC=golang-dev
https://golang.org/cl/5888043
2012-03-27 11:16:29 +11:00
Andrew Gerrand
0c58eff0b6 misc/dist: don't ship codereview either
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5917043
2012-03-27 10:38:10 +11:00
Andrew Gerrand
fd9c206718 cmd/godoc: fix app engine version
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5902060
2012-03-27 10:10:25 +11:00
Andrew Gerrand
9b6555c605 misc/dist: don't include old python dashboard in releases
I'd prefer not to ship a bunch of bad Python code to everyone who uses
Go 1.

R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5915043
2012-03-27 09:59:20 +11:00
Andrew Gerrand
d2991229bc doc: add Terms of Service
R=r
CC=golang-dev
https://golang.org/cl/5913044
2012-03-27 09:27:43 +11:00
Robert Griesemer
5390722100 exp/types: generalized GCImporter API.
- Renamed ExportData -> FindGcExportData
  and base it on an a bufio.Reader rather
  than a filename so it can be used in
  environments where object files are
  stored elsewhere.

- Factor former GcImporter into GcImportData
  and GcImport. Implementations with different
  storage locations for object files can build
  a customized GcImport using GcImportData.

This is pkg/exp only - no impact on Go 1.

R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5574069
2012-03-26 11:26:05 -07:00
Benny Siegert
f4ec146454 doc: Change id of footer
The heading "Copyright" uses id="copyright" as the anchor name.
However, there is also a <div id="copyright"> at the bottom.
Using the same ID value twice in the same file is illegal
(http://www.w3.org/TR/html401/struct/links.html#h-12.2.3).

R=golang-dev, bradfitz, rsc
CC=golang-dev
https://golang.org/cl/5909045
2012-03-26 09:12:15 -07:00
Rob Pike
6421bdeb71 cmd/go: explain versions better
Summarize the desiderata for selecting versions of remote packages to get.
Fixes #3394.

R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5902058
2012-03-26 17:47:39 +11:00
Andrew Gerrand
bfdc45a456 misc/dist: add -wxs flag to provide custom installer.wxs file
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5908055
2012-03-26 17:32:20 +11:00
Rob Pike
072646cd17 run.bash: set -e in new codewalk block
Otherwise we won't fail if something goes wrong.
This shell programming stuff is tricky.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5905062
2012-03-26 17:03:04 +11:00
Joe Poirier
f4fc889424 windows: install fixes
* set default installation drive to C:\
* remove Win64 component property

R=golang-dev, bradfitz, aram
CC=golang-dev
https://golang.org/cl/5901044
2012-03-26 16:48:20 +11:00
Rob Pike
6492cac6dd run.bash: compile the codewalks
They could be tested but that requires more than seems wise right now.

Update #2648.

R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5908054
2012-03-26 16:08:21 +11:00
Andrew Gerrand
0b762d9523 godoc: make 'Overview' section collapsable
This makes packages with lengthly package comments easier to browse.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5901055
2012-03-26 14:10:27 +11:00
Andrew Gerrand
ce06e15e2a doc: make installation instructions more skim-friendly
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5908052
2012-03-26 13:59:30 +11:00
Shenghou Ma
304404895d cmd/go: allow underscores in tool name
Otherwise we can't invoke go_bootstrap directly.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5900061
2012-03-26 10:01:17 +08:00
Shenghou Ma
d1f6e27880 go/build: cgoEnabled is not known to cmd/dist anymore
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5901051
2012-03-26 10:00:06 +08:00
Evan Shaw
c26b504b0d cmd/go: add missing error check
R=golang-dev, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/5874055
2012-03-26 09:52:29 +08:00
Rob Pike
7b8f8bf5b5 doc/reference-cmd: use vet as example, not fmt
"go tool fmt" doesn't work, "go tool vet" does.

R=golang-dev, rogpeppe, r, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/5900049
2012-03-25 11:35:16 +11:00
Rob Pike
4074795e15 effective_go: cleanups and fixes
Also explain the situation with recursive String methods more accurately,
and clean up the code now that the fmt package is more careful.

R=golang-dev, minux.ma, bradfitz
CC=golang-dev
https://golang.org/cl/5907047
2012-03-25 11:34:51 +11:00
Rob Pike
73b5eb38c1 docs/articles/wiki: minor fixes
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5900046
2012-03-24 10:14:25 +11:00
Rob Pike
c5f695e863 doc/go1: add mention of packaged releases
Fixes #3245.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5905045
2012-03-24 10:14:07 +11:00
Rob Pike
b73046407f doc/reference-cmd.html: new introduction
Compare and explain go, go cmd, and go tool cmd.
The situation is not concisely explained elsewhere in the main docs.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/5906043
2012-03-24 09:29:08 +11:00
Stefan Nilsson
2dfcbd0a3b os: add missing byte to FileMode buffer
32 bytes is enough for all FileMode bits.

R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5853044
2012-03-24 08:16:57 +11:00