David Symonds
1ad6fc6bc4
A+C: Marco Hennings (individual CLA)
...
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/13096043
2013-08-19 10:45:06 +10:00
Rob Pike
6fb9cc1f63
testing: don't start timing a Parallel test until it's actually starting
...
Fixes #5285 .
R=golang-dev, dvyukov
CC=golang-dev
https://golang.org/cl/13045044
2013-08-19 10:15:30 +10:00
Dominik Honnef
43a39bfd7f
encoding/xml: flush buffer after encoding token
...
R=rsc, bradfitz, adg
CC=golang-dev
https://golang.org/cl/13004046
2013-08-19 10:14:10 +10:00
Rob Pike
7fb121aa47
cmd/dist: more informative error for mkdtemp failing
...
The Darwin builders are all failing here but strerror doesn't provide context.
R=golang-dev, bradfitz, adg
CC=golang-dev
https://golang.org/cl/13095043
2013-08-19 08:29:43 +10:00
Mikio Hara
7917b88a06
net: make protocol-specific WriteTo, WriteMsg methods return error instead of crash
...
R=golang-dev, dave, rsc, adg, bradfitz
CC=golang-dev
https://golang.org/cl/11809043
2013-08-18 19:19:36 +09:00
Emil Hessman
df7b93c175
net/textproto: use ReadDotBytes instead of non-existent ReadDotAll.
...
Fixes #5893 .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13086043
2013-08-18 08:11:34 +10:00
Emil Hessman
20eb4cba37
net/textproto: replace '3-digit' with 'three-digit'
...
A matter on form in documentation.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13087043
2013-08-18 08:10:00 +10:00
Mikio Hara
ca01ab39ef
net: fix garbage connection close in dual stack tests
...
This may possibly be the root cause of flaky dual stack tests.
Update #4176
Update #5001
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13050043
2013-08-17 13:40:55 +09:00
Mikio Hara
96d7997f03
net: enable runtime-integrated network pollster on netbsd
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13080043
2013-08-17 13:40:14 +09:00
Mikio Hara
c4cdd35e6e
runtime: integrated network pollster for netbsd/amd64,386,arm
...
Original CL by minux (9545044).
Update #6146
R=golang-dev, rsc
CC=golang-dev, minux.ma
https://golang.org/cl/12949045
2013-08-17 12:11:29 +09:00
Russ Cox
1d3efd6533
net: limit number of concurrent cgo calls
...
The limit is 500. There is no way to change it.
This primarily affects name resolution.
If a million goroutines try to resolve DNS names,
only 500 will get to execute cgo calls at a time.
But in return the operating system will not crash.
Fixes #5625 .
R=golang-dev, dan.kortschak, r, dvyukov
CC=bradfitz, golang-dev
https://golang.org/cl/13038043
2013-08-16 22:43:05 -04:00
Russ Cox
665feeedcb
runtime: impose thread count limit
...
Actually working to stay within the limit could cause subtle deadlocks.
Crashing avoids the subtlety.
Fixes #4056 .
R=golang-dev, r, dvyukov
CC=golang-dev
https://golang.org/cl/13037043
2013-08-16 22:25:26 -04:00
Russ Cox
3b4d792606
cmd/gc: separate "has pointers" from "needs zeroing" in stack frame
...
When the new call site-specific frame bitmaps are available,
we can cut the zeroing to just those values that need it due
to scope escaping.
R=cshapiro, cshapiro
CC=golang-dev
https://golang.org/cl/13045043
2013-08-16 21:45:59 -04:00
Dmitriy Vyukov
a96d850a5b
doc: describe halt_on_error race detector parameter
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13067043
2013-08-16 22:42:54 +04:00
Dmitriy Vyukov
18f5ce8561
runtime/race: add output tests for different GORACE params
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13065043
2013-08-16 21:54:04 +04:00
Dmitriy Vyukov
eaa0704483
test: say that nilptr2.go requires 256+MB stack
...
Fixes #6161 .
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/13059043
2013-08-16 21:14:38 +04:00
Dmitriy Vyukov
187b9c695f
runtime: fix goroutine stack accounting
...
Fixes #6166 .
Fixes #6168 .
R=golang-dev, bradfitz, remyoudompheng
CC=golang-dev
https://golang.org/cl/12927045
2013-08-16 21:04:05 +04:00
Dominik Honnef
29794b77dd
misc/emacs: godef: print the entire description, not just the first line
...
When identifying structs or interfaces we really want to know
their makeup, not just their name.
R=adonovan
CC=golang-dev
https://golang.org/cl/13042043
2013-08-16 13:03:40 -04:00
Dmitriy Vyukov
fbf5fd5f1e
runtime/race: update runtime to rev 188542
...
Fixes #6107 .
race: output goroutine 1 as main goroutine
Fixes #6130 .
race: option to abort program on first detected error
R=golang-dev, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/12968044
2013-08-16 17:51:09 +04:00
Dmitriy Vyukov
727dd08cdf
net: fix bug in fdMutex
...
Fixes #6165 .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/12984044
2013-08-16 16:02:55 +04:00
Robert Dinu
b6a8fa100c
A+C: change Robert Dinu's email address
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/12759043
2013-08-16 17:19:22 +10:00
Rob Pike
8814b4a4c6
doc/go1.2.txt: testing: add TB interface
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/12890044
2013-08-16 15:38:18 +10:00
Carl Shapiro
d3b04f46b5
cmd/5g, cmd/6g, cmd/8g: update frame zeroing for new bitmap format
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12740046
2013-08-16 01:15:04 -04:00
Rob Pike
4c855f3830
time: fix time zones yet again.
...
This time we're going for 5!
http://goo.gl/3ETYH7
Fixes #3790
Yeah, right.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13002044
2013-08-16 14:57:49 +10:00
David Symonds
ea6cfc57b3
undo CL 12822043 / 96fefaa02ae3
...
Fixes #6160 .
««« original CL description
go/doc: permit a package synopsis to end with ":\n".
R=gri, r
CC=golang-dev
https://golang.org/cl/12822043
»»»
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/13040043
2013-08-16 14:36:06 +10:00
Dominik Honnef
0b25ba9ced
misc/emacs: allow godef to work in coverage buffers
...
Jumps to the same file will use the original buffer, not the
coverage buffer. Making it work for the coverage buffer isn't
worth the trouble, especially because it would break as soon as
you jump to a different file and back.
Use error instead of message so it actually terminates
R=adonovan
CC=golang-dev
https://golang.org/cl/13041043
2013-08-16 00:22:38 -04:00
Dominik Honnef
c320cf85d9
misc/emacs: do not use any free variables
...
R=adonovan
CC=golang-dev
https://golang.org/cl/12744046
2013-08-16 00:06:19 -04:00
Dominik Honnef
5f199f2d5a
misc/emacs: when defining prog-mode, define it like GNU Emacs 24 would
...
Fixes #6156 .
R=adonovan
CC=golang-dev
https://golang.org/cl/13035043
2013-08-15 20:40:38 -07:00
Andrew Gerrand
b1d64f20f2
misc/dist: don't copy godoc templates to lib/godoc
...
They're baked into the godoc binary now.
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/12751047
2013-08-16 13:14:13 +10:00
Rob Pike
f0fef32383
cmd/go: fix at least some instances of double compilation
...
When the packages the tested package depends on don't build,
we weren't getting out early. Added a simple check for a successful
build to an existing early out.
There may be other ways that double compilation arises, but
this fixes the one listed in the issue.
Fixes #5679
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/13036043
2013-08-16 12:49:51 +10:00
Rob Pike
703b897f78
cmd/gc: remove mentions of "ideal" from error messages.
...
_ = complex("foo", 0)
_ = complex(true, 0)
now trigger:
x.go:4: invalid operation: complex("foo", 0) (mismatched types untyped string and untyped number)
x.go:5: invalid operation: complex(true, 0) (mismatched types untyped bool and untyped number)
Fixes #4521
R=golang-dev, remyoudompheng, rsc
CC=golang-dev
https://golang.org/cl/12973043
2013-08-16 12:40:02 +10:00
Dominik Honnef
3495aa298d
misc/emacs: Refactor coverage code into multiple functions
...
Also fixes color gradient being calculated against the wrong maximum.
R=adonovan
CC=golang-dev
https://golang.org/cl/12968043
2013-08-15 22:37:16 -04:00
Russ Cox
757e0de89f
runtime: impose stack size limit
...
The goal is to stop only those programs that would keep
going and run the machine out of memory, but before they do that.
1 GB on 64-bit, 250 MB on 32-bit.
That seems implausibly large, and it can be adjusted.
Fixes #2556 .
Fixes #4494 .
Fixes #5173 .
R=khr, r, dvyukov
CC=golang-dev
https://golang.org/cl/12541052
2013-08-15 22:34:06 -04:00
Dimitri Tcaciuc
205329aaf2
image: Inline example image data to make it runnable on playground.
...
Use more compressed image to reduce source clutter.
Fixes #5983 .
R=nigeltao, adg
CC=golang-dev
https://golang.org/cl/12513044
2013-08-16 11:43:43 +10:00
Nigel Tao
c06303bb79
A+C: Dimitri Tcaciuc (individual CLA)
...
Generated by addca.
R=gobot
CC=golang-dev
https://golang.org/cl/13024045
2013-08-16 11:40:56 +10:00
Nigel Tao
bc21265074
database/sql: make Rows.Next returning false always implicitly call
...
Rows.Close.
Previously, callers that followed the example code (but not call
rows.Close after "for rows.Next() { ... }") could leak statements if
the driver returned an error other than io.EOF.
R=bradfitz, alex.brainman
CC=golang-dev, rsc
https://golang.org/cl/12677050
2013-08-16 11:23:35 +10:00
Russ Cox
b75a08d03c
cmd/gc: ensure addable in checknil (fix race build)
...
TBR=dvyukov
CC=golang-dev
https://golang.org/cl/12791044
2013-08-15 21:05:05 -04:00
Brad Fitzpatrick
67a69bce6b
net/http: don't send an automatic Content-Length on a 304 Not Modified
...
Also start of some test helper unification, long overdue.
I refrained from cleaning up the rest in this CL.
Fixes #6157
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13030043
2013-08-15 17:40:05 -07:00
Rob Pike
9c248e3406
doc/go1.2.txt: delete 'go doc'
...
It's nearly useless and for plain 'go doc', 'godoc .' works fine.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13004044
2013-08-16 10:35:22 +10:00
Rob Pike
de2cf5113b
doc/go1.2.txt: three-index slices are going into 1.2
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/12931044
2013-08-16 10:30:31 +10:00
Rob Pike
71eae5a46a
cmd/go: delete 'go doc'
...
It's next to useless and confusing as well. Let's make godoc better instead.
Fixes #4849 .
R=golang-dev, dsymonds, adg, rogpeppe, rsc
CC=golang-dev
https://golang.org/cl/12974043
2013-08-16 10:30:05 +10:00
Brad Fitzpatrick
95e0a8c277
net/http: unify the confusingly-named serve_test and server_test
...
One was tiny. One was gigantic. Now one is gone and one is giganticer.
No code changes.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/13025043
2013-08-15 16:47:31 -07:00
Russ Cox
999a36f9af
cmd/gc: &x panics if x does
...
See golang.org/s/go12nil.
This CL is about getting all the right checks inserted.
A followup CL will add an optimization pass to
remove redundant checks.
R=ken2
CC=golang-dev
https://golang.org/cl/12970043
2013-08-15 14:38:32 -04:00
Russ Cox
5ce78b7cd2
spec: &x panics if x does
...
See golang.org/s/go12nil for the extended version.
R=golang-dev, r, adonovan
CC=golang-dev
https://golang.org/cl/12964043
2013-08-15 14:33:26 -04:00
Russ Cox
08fdf00906
tests: remove two misuses of nil pointers
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/12858044
2013-08-15 11:51:04 -04:00
Mikio Hara
ff86d222be
runtime: fix wrong syscall numbers on freebsd/386, openbsd/386
...
R=golang-dev, jsing
CC=golang-dev
https://golang.org/cl/12876044
2013-08-15 23:22:55 +09:00
Mikio Hara
cb3b292201
net: enable runtime-integrated network pollster on freebsd, openbsd
...
Fixes #5199 .
Benchmark results on freebsd/amd64 (virtual machine):
benchmark old ns/op new ns/op delta
BenchmarkTCP4OneShot-2 184566 187164 +1.41%
BenchmarkTCP4OneShotTimeout-2 215558 187722 -12.91%
BenchmarkTCP4Persistent-2 59686 41294 -30.81%
BenchmarkTCP4PersistentTimeout-2 60692 39974 -34.14%
BenchmarkTCP6OneShot-2 226595 223688 -1.28%
BenchmarkTCP6OneShotTimeout-2 253144 225161 -11.05%
BenchmarkTCP6Persistent-2 69157 55605 -19.60%
BenchmarkTCP6PersistentTimeout-2 70426 53805 -23.60%
BenchmarkTCP4ConcurrentReadWrite-2 53878 56087 +4.10%
BenchmarkTCP6ConcurrentReadWrite-2 66538 68190 +2.48%
benchmark old allocs new allocs delta
BenchmarkTCP4OneShot-2 39 36 -7.69%
BenchmarkTCP4OneShotTimeout-2 42 36 -14.29%
BenchmarkTCP4Persistent-2 1 0 -100.00%
BenchmarkTCP4PersistentTimeout-2 1 0 -100.00%
BenchmarkTCP6OneShot-2 41 36 -12.20%
BenchmarkTCP6OneShotTimeout-2 43 36 -16.28%
BenchmarkTCP6Persistent-2 1 0 -100.00%
BenchmarkTCP6PersistentTimeout-2 1 0 -100.00%
BenchmarkTCP4ConcurrentReadWrite-2 0 0 n/a%
BenchmarkTCP6ConcurrentReadWrite-2 0 0 n/a%
benchmark old bytes new bytes delta
BenchmarkTCP4OneShot-2 3084 2544 -17.51%
BenchmarkTCP4OneShotTimeout-2 3129 2519 -19.50%
BenchmarkTCP4Persistent-2 30 0 -100.00%
BenchmarkTCP4PersistentTimeout-2 31 0 -100.00%
BenchmarkTCP6OneShot-2 3297 2660 -19.32%
BenchmarkTCP6OneShotTimeout-2 3306 2655 -19.69%
BenchmarkTCP6Persistent-2 31 0 -100.00%
BenchmarkTCP6PersistentTimeout-2 29 0 -100.00%
BenchmarkTCP4ConcurrentReadWrite-2 2 0 -100.00%
BenchmarkTCP6ConcurrentReadWrite-2 7 0 -100.00%
R=dvyukov, minux.ma, dave, bradfitz, alex.brainman
CC=golang-dev
https://golang.org/cl/8264043
2013-08-15 21:10:03 +09:00
Dmitriy Vyukov
f195ae94ca
runtime: remove old preemption checks
...
runtime.gcwaiting checks are not needed anymore
R=golang-dev, khr
CC=golang-dev
https://golang.org/cl/12934043
2013-08-15 14:32:10 +04:00
Dmitriy Vyukov
67c79da857
runtime: fix plan9 build
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/12986043
2013-08-15 14:24:28 +04:00
Rémy Oudompheng
826a739658
doc: update go1.2.txt
...
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/12960043
2013-08-15 10:31:18 +02:00