1
0
mirror of https://github.com/golang/go synced 2024-11-24 23:07:56 -07:00

runtime: impose thread count limit

Actually working to stay within the limit could cause subtle deadlocks.
Crashing avoids the subtlety.

Fixes #4056.

R=golang-dev, r, dvyukov
CC=golang-dev
https://golang.org/cl/13037043
This commit is contained in:
Russ Cox 2013-08-16 22:25:26 -04:00
parent 3b4d792606
commit 665feeedcb
3 changed files with 74 additions and 1 deletions

View File

@ -125,6 +125,14 @@ func TestStackOverflow(t *testing.T) {
}
}
func TestThreadExhaustion(t *testing.T) {
output := executeTest(t, threadExhaustionSource, nil)
want := "runtime: program exceeds 10-thread limit\nfatal error: thread exhaustion"
if !strings.HasPrefix(output, want) {
t.Fatalf("output does not start with %q:\n%s", want, output)
}
}
const crashSource = `
package main
@ -243,3 +251,25 @@ func f(x []byte) byte {
return x[0] + f(buf[:])
}
`
const threadExhaustionSource = `
package main
import (
"runtime"
"runtime/debug"
)
func main() {
debug.SetMaxThreads(10)
c := make(chan int)
for i := 0; i < 100; i++ {
go func() {
runtime.LockOSThread()
c <- 0
select{}
}()
<-c
}
}
`

View File

@ -25,6 +25,7 @@ func enableGC(bool) bool
func setGCPercent(int) int
func freeOSMemory()
func setMaxStack(int) int
func setMaxThreads(int) int
// ReadGCStats reads statistics about garbage collection into stats.
// The number of entries in the pause history is system-dependent;
@ -114,3 +115,21 @@ func FreeOSMemory() {
func SetMaxStack(bytes int) int {
return setMaxStack(bytes)
}
// SetMaxThreads sets the maximum number of operating system
// threads that the Go program can use. If it attempts to use more than
// this many, the program crashes.
// SetMaxThreads returns the previous setting.
// The initial setting is 10,000 threads.
//
// The limit controls the number of operating system threads, not the number
// of goroutines. A Go program creates a new thread only when a goroutine
// is ready to run but all the existing threads are blocked in system calls, cgo calls,
// or are locked to other goroutines due to use of runtime.LockOSThread.
//
// SetMaxThreads is useful mainly for limiting the damage done by
// programs that create an unbounded number of threads. The idea is
// to take down the program before it takes down the operating system.
func SetMaxThreads(threads int) int {
return setMaxThreads(threads)
}

View File

@ -32,6 +32,7 @@ struct Sched {
int32 nmidle; // number of idle m's waiting for work
int32 nmidlelocked; // number of locked m's waiting for work
int32 mcount; // number of m's that have been created
int32 maxmcount; // maximum number of m's allowed (or die)
P* pidle; // idle P's
uint32 npidle;
@ -126,6 +127,8 @@ runtime·schedinit(void)
int32 n, procs;
byte *p;
runtime·sched.maxmcount = 10000;
m->nomemprof++;
runtime·mprofinit();
runtime·mallocinit();
@ -283,6 +286,16 @@ runtime·tracebackothers(G *me)
}
}
static void
checkmcount(void)
{
// sched lock is held
if(runtime·sched.mcount > runtime·sched.maxmcount) {
runtime·printf("runtime: program exceeds %d-thread limit\n", runtime·sched.maxmcount);
runtime·throw("thread exhaustion");
}
}
static void
mcommoninit(M *mp)
{
@ -295,7 +308,7 @@ mcommoninit(M *mp)
runtime·lock(&runtime·sched);
mp->id = runtime·sched.mcount++;
checkmcount();
runtime·mpreinit(mp);
// Add to runtime·allm so garbage collector doesn't free m
@ -2821,3 +2834,14 @@ runtime·topofstack(Func *f)
f->entry == (uintptr)runtime·lessstack ||
f->entry == (uintptr)_rt0_go;
}
void
runtimedebug·setMaxThreads(intgo in, intgo out)
{
runtime·lock(&runtime·sched);
out = runtime·sched.maxmcount;
runtime·sched.maxmcount = in;
checkmcount();
runtime·unlock(&runtime·sched);
FLUSH(&out);
}