Shenghou Ma
2bed8a7e95
go/build: cgo is supported on Linux/ARM
...
Last Part of CL 5601044 (cgo: Linux/ARM support)
Fixes #1880 .
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5988057
2012-05-04 18:34:04 +08:00
Shenghou Ma
e7a0a7595a
cmd/go: cgo for Linux/ARM
...
Part 4 of CL 5601044 (cgo: Linux/ARM support)
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5989058
2012-05-04 18:29:40 +08:00
Shenghou Ma
9602dd5e87
cmd/cgo: support Linux/ARM
...
Part 3 of CL 5601044 (cgo: Linux/ARM support)
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5991066
2012-05-04 18:26:16 +08:00
Shenghou Ma
5cffce611a
runtime: cgo support for Linux/ARM
...
Part 2 of CL 5601044 (cgo: Linux/ARM support)
R=dave, rsc
CC=golang-dev
https://golang.org/cl/5989057
2012-05-04 18:20:09 +08:00
Shenghou Ma
452a9e452b
cmd/5l, cmd/ld: dynamic linking library support
...
Part 1 of CL 5601044 (cgo: Linux/ARM support)
Limitation: doesn't support thumb library yet.
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/5991065
2012-05-04 18:14:26 +08:00
David Symonds
c44a22cc49
misc/dashboard/codereview: remove transitional code.
...
All current CLs have subject lines, so we don't need to check any more.
R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6196044
2012-05-04 16:40:24 +10:00
Michael Chaten
3fab2a97e4
encoding/json: Fix panic when trying to unmarshal the empty string into an integer
...
Fixes #3450 .
R=rsc, bradfitz
CC=golang-dev
https://golang.org/cl/6035050
2012-05-03 17:35:44 -04:00
Francisco Souza
61060acdc1
syscall: add Termios support on darwin
...
Update #3316 .
R=dave, kevlar, devon.odell, rsc, minux.ma
CC=golang-dev
https://golang.org/cl/6063053
2012-05-03 17:33:19 -04:00
Ian Lance Taylor
890be5ced0
test: add bug437, a test that used to fail with gccgo at link time
...
Updates #3391 .
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6177045
2012-05-03 14:25:11 -07:00
Adam Langley
c8e1946f33
crypto/x509: fix panic when using unavailable hash function.
...
crypto.Hash.New() changed to panicking when the hash function isn't
linked in, but crypto/x509 still expects it to return nil.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6175047
2012-05-03 16:39:57 -04:00
Shenghou Ma
278d4a583d
cmd/5c, cmd/5a, cmd/5l: ARM support for PREFETCH built-in
...
R=rsc
CC=golang-dev
https://golang.org/cl/6174049
2012-05-04 03:24:14 +08:00
Ian Lance Taylor
df64448932
test: add bug436, valid code that crashed gccgo
...
R=golang-dev, bsiegert, rsc
CC=golang-dev
https://golang.org/cl/6158046
2012-05-03 10:33:10 -07:00
Shenghou Ma
52ec4aa24a
cmd/dist: remove stray src/pkg/runtime/z* when cleaning
...
R=golang-dev, bradfitz, dave, rsc, lstoakes, rsc
CC=golang-dev
https://golang.org/cl/6180044
2012-05-04 00:58:48 +08:00
Andrew Gerrand
7a77645aa8
misc/dashboard/codereview: add copyright notices to Go files
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6177043
2012-05-03 09:22:45 +10:00
Russ Cox
d42495aa80
cmd/cc: add PREFETCH built-in (like SET, USED)
...
This makes it possible to inline the prefetch of upcoming
memory addresses during garbage collection, instead of
needing to flush registers, make a function call, and
reload registers. On garbage collection-heavy workloads,
this results in a 5% speedup.
Fixes #3493 .
R=dvyukov, ken, r, dave
CC=golang-dev
https://golang.org/cl/5990066
2012-05-02 16:22:56 -04:00
Marcel van Lohuizen
10838165d8
exp/locale/collate: fixed two bugs uncovered by regression tests.
...
The first bug was that tertiary ignorables had the same colElem as
implicit colElems, yielding unexpected results. The current encoding
ensures that a non-implicit colElem is never 0. This fix uncovered
another bug of the trie that indexed incorrectly into the null block.
This was caused by an unfinished optimization that would avoid the
need to max out the most-significant bits of continuation bytes.
This bug was also present in the trie used in exp/norm and has been
fixed there as well. The appearence of the bug was rare, as the lower
blocks happened to be nearly nil.
R=r
CC=golang-dev
https://golang.org/cl/6127070
2012-05-02 17:01:41 +02:00
Luuk van Dijk
81d9621534
cmd/gc: test for issue 3552
...
R=rsc
CC=golang-dev
https://golang.org/cl/6128051
2012-05-02 16:56:26 +02:00
Dmitriy Vyukov
c1c851bbe8
runtime: avoid unnecessary zeroization of huge memory blocks
...
+move zeroization out of the heap mutex
R=golang-dev, iant, rsc
CC=golang-dev
https://golang.org/cl/6094050
2012-05-02 18:01:11 +04:00
Alex Brainman
0d55d9832f
os/signal: run windows TestCtrlBreak during build
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6136054
2012-05-02 17:05:52 +10:00
Anthony Martin
90626864dc
os: conform to Go 1 API on Plan 9
...
R=golang-dev, r, bradfitz, r
CC=golang-dev
https://golang.org/cl/6117062
2012-05-01 22:44:38 -07:00
Anthony Martin
3859032980
build: dist-based build for Plan 9
...
R=rsc, iant, iant, seed
CC=golang-dev
https://golang.org/cl/5608059
2012-05-01 22:32:46 -07:00
Rob Pike
ce30769ce3
misc/dashboard/codereview: LGTM favicon
...
R=dsymonds
CC=golang-dev
https://golang.org/cl/6158043
2012-05-02 13:48:49 +10:00
Dave Cheney
d472d3faf1
bytes: add assembly version of Equal for ARM
...
BenchmarkEqual32 662 159 -75.98%
BenchmarkEqual4K 76545 13719 -82.08%
BenchmarkEqual4M 90136700 23588870 -73.83%
BenchmarkEqual64M 2147483647 1419616000 -42.63%
BenchmarkEqual32 48.32 201.15 4.16x
BenchmarkEqual4K 53.51 298.56 5.58x
BenchmarkEqual4M 46.53 177.81 3.82x
BenchmarkEqual64M 27.12 47.27 1.74x
R=golang-dev, qyzhai, minux.ma, rsc, iant, nigeltao
CC=golang-dev
https://golang.org/cl/6118049
2012-05-02 12:10:24 +10:00
Ian Lance Taylor
82e30c681c
cgo: rename C names for Go types to avoid conflicting with package
...
Fixes #3371 .
R=rsc, bsiegert, r, mtj, iant
CC=golang-dev
https://golang.org/cl/6131060
2012-05-01 09:04:13 -07:00
David Symonds
cc9a5c3be7
misc/dashboard/codereview: preserve CL ordering.
...
R=r
CC=golang-dev
https://golang.org/cl/6136056
2012-05-01 16:15:32 +10:00
Nigel Tao
86a91539b8
compress/flate: add a copy overrun test.
...
R=rsc, r
CC=golang-dev
https://golang.org/cl/6143043
2012-05-01 14:28:33 +10:00
David Symonds
83aa040c45
misc/dashboard/codereview: de-dup LGTMs.
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6127066
2012-05-01 11:41:32 +10:00
David Symonds
c3c8e35af2
encoding/json: don't match field name if a JSON struct tag is present.
...
Fixes #3566 .
R=rsc
CC=golang-dev
https://golang.org/cl/6139048
2012-05-01 11:37:44 +10:00
David Symonds
dae2992c98
misc/dashboard/codereview: send mail immediately, and fill in time.Time fields.
...
If we delay the mail sending, we can't send as the current user.
If we don't fill in the time.Time fields, datastore.Put will fail
because the zero time.Time value is out of its range.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6136053
2012-05-01 11:33:25 +10:00
Nigel Tao
4de15a5cda
compress/flate: optimize history-copy decoding.
...
The forwardCopy function could be re-written in asm, and the copyHuff
method could probably be rolled into huffmanBlock and copyHist, but
I'm leaving those changes for future CLs.
compress/flate benchmarks:
benchmark old ns/op new ns/op delta
BenchmarkDecoderBestSpeed1K 385327 435140 +12.93%
BenchmarkDecoderBestSpeed10K 1245190 1062112 -14.70%
BenchmarkDecoderBestSpeed100K 8512365 5833680 -31.47%
BenchmarkDecoderDefaultCompression1K 382225 421301 +10.22%
BenchmarkDecoderDefaultCompression10K 867950 613890 -29.27%
BenchmarkDecoderDefaultCompression100K 5658240 2466726 -56.40%
BenchmarkDecoderBestCompression1K 383760 421634 +9.87%
BenchmarkDecoderBestCompression10K 867743 614671 -29.16%
BenchmarkDecoderBestCompression100K 5660160 2464996 -56.45%
image/png benchmarks:
benchmark old ns/op new ns/op delta
BenchmarkDecodeGray 2540834 2389624 -5.95%
BenchmarkDecodeNRGBAGradient 10052700 9534565 -5.15%
BenchmarkDecodeNRGBAOpaque 8704710 8163430 -6.22%
BenchmarkDecodePaletted 1458779 1325017 -9.17%
BenchmarkDecodeRGB 7183606 6794668 -5.41%
Wall time for Denis Cheremisov's PNG-decoding program given in
https://groups.google.com/group/golang-nuts/browse_thread/thread/22aa8a05040fdd49
Before: 3.07s
After: 2.32s
Delta: -24%
Before profile:
Total: 304 samples
159 52.3% 52.3% 251 82.6% compress/flate.(*decompressor).huffmanBlock
58 19.1% 71.4% 76 25.0% compress/flate.(*decompressor).huffSym
32 10.5% 81.9% 32 10.5% hash/adler32.update
16 5.3% 87.2% 22 7.2% bufio.(*Reader).ReadByte
16 5.3% 92.4% 37 12.2% compress/flate.(*decompressor).moreBits
7 2.3% 94.7% 7 2.3% hash/crc32.update
7 2.3% 97.0% 7 2.3% runtime.memmove
5 1.6% 98.7% 5 1.6% scanblock
2 0.7% 99.3% 9 3.0% runtime.copy
1 0.3% 99.7% 1 0.3% compress/flate.(*huffmanDecoder).init
After profile:
Total: 230 samples
59 25.7% 25.7% 70 30.4% compress/flate.(*decompressor).huffSym
45 19.6% 45.2% 45 19.6% hash/adler32.update
35 15.2% 60.4% 35 15.2% compress/flate.forwardCopy
20 8.7% 69.1% 151 65.7% compress/flate.(*decompressor).huffmanBlock
16 7.0% 76.1% 24 10.4% compress/flate.(*decompressor).moreBits
15 6.5% 82.6% 15 6.5% runtime.memmove
11 4.8% 87.4% 50 21.7% compress/flate.(*decompressor).copyHist
7 3.0% 90.4% 7 3.0% hash/crc32.update
6 2.6% 93.0% 9 3.9% bufio.(*Reader).ReadByte
4 1.7% 94.8% 4 1.7% runtime.slicearray
R=rsc, rogpeppe, dave
CC=golang-dev, krasin
https://golang.org/cl/6127064
2012-05-01 10:51:34 +10:00
Robert Hencke
84ce0f7687
cmd/go: do not ignore DepsErrors in 'go run'
...
Fixes #3490 .
R=golang-dev, dave, rsc
CC=golang-dev
https://golang.org/cl/6040046
2012-04-30 17:00:24 -04:00
Shenghou Ma
44fd1d1a6a
runtime: give proper messages when user defined DYLD_INSERT_LIBRARIES on Darwin
...
also gives clear error when bsdthread_register fails on Darwin
Fixes #2992 .
R=rsc, krautz
CC=golang-dev
https://golang.org/cl/5966067
2012-04-30 15:55:07 -04:00
David Symonds
1bdb788b2e
misc/dashboard/codereview: record Message-ID of code review thread mails.
...
This will allow us to properly thread "R=..." mails at a later time.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135053
2012-04-30 22:47:51 +10:00
David Symonds
5d331964e7
misc/dashboard/codereview: add handy logout URL.
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6135052
2012-04-30 22:47:06 +10:00
David Symonds
4335ec9eeb
misc/dashboard/codereview: send mail to assigned reviewers if they aren't already looped in.
...
R=golang-dev, bradfitz, r
CC=golang-dev
https://golang.org/cl/6128054
2012-04-30 22:03:56 +10:00
Brad Fitzpatrick
ed90fbc747
encoding/base64: don't ignore underlying souce read error in decode
...
Fixes #3577
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6137054
2012-04-30 17:14:41 +10:00
Brad Fitzpatrick
fe2ce5285e
syscall: add a test for passing an fd over a unix socket
...
Re-submitting previously reverted change 160ec5506cb7.
R=golang-dev, r, r
CC=golang-dev
https://golang.org/cl/6129052
2012-04-30 15:31:14 +10:00
Dave Cheney
d5b299eda2
compress/flate: add Encoder/Decoder benchmarks
...
In CL 6127051, nigeltao suggested that further gains
were possible by improving the performance of flate.
This CL adds a set of benchmarks (based on compress/lzw)
that can be used to judge any future improvements.
R=nigeltao
CC=golang-dev
https://golang.org/cl/6128049
2012-04-29 20:41:13 +10:00
David Symonds
24cce5c60c
misc/dashboard/codereview: don't depend on map iteration order for unit calculation.
...
Fix auth requirements for /gc endpoint too.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6133049
2012-04-28 09:47:15 +10:00
Brian Dellisanti
a0f7c6c658
os/exec: close all internal descriptors when Cmd.Start() fails.
...
This closes any internal descriptors (pipes, etc) that Cmd.Start() had
opened before it failed.
Fixes #3468 .
R=golang-dev, iant, bradfitz
CC=golang-dev
https://golang.org/cl/5986044
2012-04-27 15:46:49 -07:00
Ian Lance Taylor
6d1face5ba
A+C: add Brian Dellisanti (individual CLA)
...
R=golang-dev, bsiegert, r
CC=golang-dev
https://golang.org/cl/6127056
2012-04-27 15:46:27 -07:00
David Symonds
fe252584f5
misc/dashboard/codereview: simplify parallel operations for front page, and capture timing info.
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6128044
2012-04-27 23:16:54 +10:00
Dave Cheney
f72c828c67
net: consolidate common socket functions
...
In resolving 3507, the fix had to be applied individually to
the four *Conn types, tcp, udp, rawip and unix, due to the
duplicate code in each Conn type.
This CL consolidates the common net.Conn methods that all four
*Conn types implement into a base conn type.
Pros:
* The fix for 3507 would have only needed to be applied to one
method. Further improvements, such as possibly removing the
c.fd != nil check in c.ok(), would benefit from this CL.
* Nearly 300 lines removed from the net package.
* The public interface and documentation are not changed.
* I think this is an excellent example of the power of embedding.
Cons:
* The net package is already distributed over many files, this
CL adds another place to look.
* The fix for 3507 was a total of 16 lines changed, this follow
up CL could be considered to be an overreaction as new Conn types
are unlikely to be added in the near future.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6098047
2012-04-27 22:17:08 +10:00
David Symonds
1a79053725
misc/dashboard/codereview: more abbreviated modification duration.
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6131044
2012-04-27 17:12:09 +10:00
David Symonds
0175e3f1e0
misc/dashboard/codereview: new app.
...
This is live at http://gocodereview.appspot.com/ .
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6134043
2012-04-27 16:36:02 +10:00
Nigel Tao
dd294fbd5a
image/png: speed up PNG decoding for common color models: Gray, NRGBA,
...
Paletted, RGBA.
benchmark old ns/op new ns/op delta
BenchmarkDecodeGray 3681144 2536049 -31.11%
BenchmarkDecodeNRGBAGradient 12108660 10020650 -17.24%
BenchmarkDecodeNRGBAOpaque 10699230 8677165 -18.90%
BenchmarkDecodePaletted 2562806 1458798 -43.08%
BenchmarkDecodeRGB 8468175 7180730 -15.20%
benchmark old MB/s new MB/s speedup
BenchmarkDecodeGray 17.80 25.84 1.45x
BenchmarkDecodeNRGBAGradient 21.65 26.16 1.21x
BenchmarkDecodeNRGBAOpaque 24.50 30.21 1.23x
BenchmarkDecodePaletted 25.57 44.92 1.76x
BenchmarkDecodeRGB 30.96 36.51 1.18x
$ file $GOROOT/src/pkg/image/png/testdata/bench*
benchGray.png: PNG image, 256 x 256, 8-bit grayscale, non-interlaced
benchNRGBA-gradient.png: PNG image, 256 x 256, 8-bit/color RGBA, non-interlaced
benchNRGBA-opaque.png: PNG image, 256 x 256, 8-bit/color RGBA, non-interlaced
benchPaletted.png: PNG image, 256 x 256, 8-bit colormap, non-interlaced
benchRGB.png: PNG image, 256 x 256, 8-bit/color RGB, non-interlaced
R=r
CC=golang-dev
https://golang.org/cl/6127051
2012-04-27 16:03:58 +10:00
David Symonds
9ce770afad
old/regexp, old/template: delete.
...
Both of these have replacements.
R=golang-dev, r, rsc, r, adg
CC=golang-dev
https://golang.org/cl/5979046
2012-04-27 15:12:24 +10:00
Anthony Martin
0bad08cbbb
path/filepath: fix typo
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/6117063
2012-04-27 10:25:19 +10:00
Andrew Gerrand
029d62f5c0
misc/dist: drop repetition in filenames, default to release tag
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6117066
2012-04-26 13:25:53 -07:00
Andrew Gerrand
d8443d2e41
re-tag go1.0.1
...
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/6115056
2012-04-26 12:51:55 -07:00