Robert Griesemer
1698934194
- replaced gofmt expression formatting algorithm with
...
rsc's algorithm
- applied gofmt -w misc src
- partial CL (remaining files in other CLs)
R=rsc, r
http://go/go-review/1024040
2009-11-09 21:09:34 -08:00
Rob Pike
7685a67fe8
add a q&a about google's internal use of go
...
R=rsc
CC=go-dev
http://go/go-review/1026035
2009-11-09 20:25:45 -08:00
Russ Cox
1a821b32da
noted by kaib: explicit assignment initialization
...
didn't match the composite literal initialization.
R=r
CC=kaib
http://go/go-review/1024039
2009-11-09 17:09:33 -08:00
Russ Cox
6c7f9f6340
add id tags to contribute.html
...
R=r
http://go/go-review/1025033
2009-11-09 16:56:17 -08:00
Robert Griesemer
c110269579
cleanup style:
...
- consistently remove all underbars from links
- this removes need for noline style
- removed unused info style
R=r, rsc
http://go/go-review/1025032
2009-11-09 16:19:38 -08:00
Rob Pike
0b4de7aa8a
comment out red TODO clauses except for the last one
...
R=rsc
CC=go-dev
http://go/go-review/1024037
2009-11-09 16:09:57 -08:00
Russ Cox
9f42ccb781
error rewording suggested by robert.
...
update comment.
R=ken
http://go/go-review/1025031
2009-11-09 15:25:18 -08:00
Robert Griesemer
93c3f5124e
make search box ever so slightly wider
...
R=rsc
http://go/go-review/1024036
2009-11-09 14:49:01 -08:00
Robert Griesemer
92743615fb
TBR:
...
fix typo that prevented function bodies from being indexed (ouch!)
R=rsc
http://go/go-review/1024035
2009-11-09 14:44:16 -08:00
Robert Griesemer
fb5fce5532
fix for incorrect composite literal grammar
...
(issue found by ken)
R=go-dev, rsc
http://go/go-review/1025030
2009-11-09 12:35:56 -08:00
Robert Griesemer
40621d5c0d
remove semis after statements in one-statement statement lists
...
R=rsc, r
http://go/go-review/1025029
2009-11-09 12:07:39 -08:00
Russ Cox
18ccbc69f8
tweak documentation of commands
...
so that first sentence is better for cmd page.
live at http://r45:3456/cmd/
R=gri, r
http://go/go-review/1024034
2009-11-09 11:45:15 -08:00
Robert Griesemer
81672e79e4
- rename Context to exprContext to remove it from public interface
...
(and to match the style of declContext)
R=rsc
http://go/go-review/1024033
2009-11-09 10:37:36 -08:00
Robert Griesemer
568c018fee
make search box width dynamically sized
...
R=rsc, agl
http://go/go-review/1024032
2009-11-09 10:27:07 -08:00
Rob Pike
0c7e20ba67
delete commented-out section; details now covered elsewhere
...
R=rsc
CC=go-dev
http://go/go-review/1025028
2009-11-09 09:46:10 -08:00
Robert Griesemer
53f485813e
fix for nodeSize computation, used to determine if
...
a node fits on one line:
- for purposes of measuring the node size in text,
don't generate html or use a styler that could
generate html as it will lead to overly large
sizes
A consequence of this bug is that source code displayed
with godoc may show functions that fit on one line in
the source on multiple lines.
This change causes no difference to the gofmt formatting
of any files in src or misc.
R=rsc
http://go/go-review/1026034
2009-11-09 09:34:55 -08:00
Robert Griesemer
aae64f8c81
- exit godoc w/o crashing if negative tabwidth is provided
...
- minor related cleanups
R=rsc
http://go/go-review/1025026
2009-11-08 23:42:00 -08:00
Russ Cox
8b04ceff62
copy help section to install doc,
...
since most people won't get to the second one.
R=r
http://go/go-review/1024031
2009-11-08 23:38:30 -08:00
Russ Cox
bb097d4649
change highlight color from green to yellow
...
(fits better in the color scheme).
eliminate background color on line numbers at
bottom of search results, now that they are grouped.
live at http://r45:3456/search?q=Reader
R=r, gri
http://go/go-review/1024030
2009-11-08 23:37:46 -08:00
Robert Griesemer
d731dc8e72
Addressing issue brought up by dsymonds:
...
- When providing alternative spellings to a query, do not
prefix it with a package qualifier as the suggestion may
not have any results. Correctly filtering is quite a bit
of work, and clicking the alternative spelling will always
also show the qualified hits if they exist (but also others).
Seems good enough for now.
- Give user feedback when the query syntax was wrong.
- Package names in search results are now links to the respective
package documentation.
- Experimented with excluding main packages and test files
from index with inconclusive results. Code is present and
can be enabled by changing a flag in the source. This needs
some more work.
R=rsc
CC=r, dsymonds
http://go/go-review/1026033
2009-11-08 23:34:08 -08:00
Russ Cox
71983af4a1
bug212, bug213.
...
R=ken
http://go/go-review/1026032
2009-11-08 23:22:06 -08:00
Russ Cox
b1a52ce4a3
make hg mail more forgiving:
...
create CL first, even if gofmt is needed
or no reviewers listed.
R=r
http://go/go-review/1025025
2009-11-08 22:13:10 -08:00
Russ Cox
6fff7b2399
mention license in install.html.
...
tighter nav list.
R=r
http://go/go-review/1024029
2009-11-08 22:12:51 -08:00
Rob Pike
0d93dbcf9b
link the course slides from early in the tutorial
...
R=rsc
CC=go-dev
http://go/go-review/1026031
2009-11-08 22:03:12 -08:00
Rob Pike
d10f1547b0
make "Go for it" link to install.html.
...
delete the unnecessary "Programming in Go. Watch Now" from the right box.
center the video picture in the right box.
R=rsc
CC=go-dev
http://go/go-review/1025027
2009-11-08 22:02:15 -08:00
Rob Pike
e02f2b51c5
delete a pointless todo in all_test.go.
...
address one in rpc/client.go
R=rsc
CC=go-dev
http://go/go-review/1026030
2009-11-08 21:57:59 -08:00
Robert Griesemer
c532940ecf
improved sentence extraction:
...
- don't forget first periods
- look at capitalization of last char before periods
R=rsc
http://go/go-review/1024027
2009-11-08 21:48:51 -08:00
Russ Cox
ed6eb5b577
a nagging inconsistency: capitalization of
...
HTML vs Html, URL vs Url, HTTP vs Http,
current source is 6:1 in favor of the former,
so change instances of the latter.
R=r
CC=go-dev
http://go/go-review/1024026
2009-11-08 21:46:20 -08:00
Russ Cox
830813f019
assorted cleanup
...
R=r, iant
CC=go-dev
http://go/go-review/1025024
2009-11-08 21:08:27 -08:00
Ian Lance Taylor
97a55a7485
Minor cleanups.
...
These are all fairly trivial and may be ignored.
R=r
CC=go-dev
http://go/go-review/1024025
2009-11-08 21:00:45 -08:00
Rob Pike
ceb6031ecd
delete TODO now that compiler is better at %
...
adjust an inconsistency in reflect/type.go's package comment
R=rsc
http://go/go-review/1026029
2009-11-08 20:45:39 -08:00
Robert Griesemer
7837dbfcb8
use grouping instead of colors to show non-global search hits:
...
- introduced a new run per file containing all spots belonging
to the same kind (e.g. var decl, const decl, etc.)
- more comments, better index.go file organization
R=rsc
http://go/go-review/1026028
2009-11-08 20:17:04 -08:00
Robert Griesemer
e8b580c9aa
fix sentence extraction
...
R=rsc
http://go/go-review/1026027
2009-11-08 18:19:06 -08:00
Robert Griesemer
202ede1240
- properly align package synopses
...
(this was surprisingly hard to get right in HTML)
- show modification times in source directory listings
- various tweaks
R=rsc
http://go/go-review/1024024
2009-11-08 16:47:32 -08:00
Rob Pike
40a7db3ee9
add top-level package comments for net, reflect, malloc.
...
reflect is a little more detailed than some because it affords an opportunity
to explain how to approach the library.
R=gri, rsc
CC=go-dev
http://go/go-review/1026026
2009-11-08 15:57:25 -08:00
Robert Griesemer
56b4515740
added package documentation
...
R=r, rsc
http://go/go-review/1025023
2009-11-08 15:04:30 -08:00
Russ Cox
d27fa9446d
add a README file, so that if someone finds a
...
go tar ball or finds themselves staring at
http://code.google.com/p/go/source/browse/ ,
there is an obvious path back to golang.org
R=r
http://go/go-review/1026024
2009-11-08 09:57:37 -08:00
Russ Cox
826e10ce64
links to Go Nuts, issue tracker,
...
source code browser on code.google.com
(where LICENSE file is visible)
R=r
http://go/go-review/1024023
2009-11-08 09:50:16 -08:00
Russ Cox
aa2a9e4796
another attempt at utf-8 uploads.
...
the last attempt broke uploads of binary files like .png
R=r
http://go/go-review/1026025
2009-11-08 09:49:13 -08:00
Russ Cox
2a63f5df98
go for c++ programmers; fixes.
...
the most substantial are the wording around semicolons
and around the channel manager nits. both were subtly
incorrect.
R=iant, r
CC=go-dev
http://go/go-review/1025018
2009-11-08 01:08:26 -08:00
Russ Cox
24ce19c71d
effective go: tiny fixes
...
one real bug: *[]float -> *[3]float
R=r
http://go/go-review/1024016
2009-11-08 01:07:53 -08:00
Robert Griesemer
a011480ff3
TBR
...
1st step of renaming dirList.html -> dirlist.html
(OS X filenames are not capitalization-sensitive)
R=rsc
http://go/go-review/1024021
2009-11-08 00:51:08 -08:00
Robert Griesemer
5de21eb1e9
TBR
...
step 2: adding renamed dirlist.html again
R=rsc
http://go/go-review/1024022
2009-11-08 00:49:56 -08:00
Robert Griesemer
89d0e2dbe3
- better support for text files: show them nicely formatted
...
instead of serving them raw
- path-related cleanups
R=rsc
http://go/go-review/1026021
2009-11-08 00:40:43 -08:00
Rob Pike
7ee3f3ddd1
make the visited color darker instead of lighter
...
R=rsc
CC=go-dev
http://go/go-review/1025022
2009-11-08 00:18:15 -08:00
Russ Cox
63c572c6b0
scaled bumpers
...
R=r
http://go/go-review/1026023
2009-11-08 00:16:25 -08:00
Robert Griesemer
1a9805adcb
- avoid division-by-zero crash in tabwriter
...
- correct tabwidth argument for some tabwriter test cases
- catch negative tabwidth flag in gofmt w/o crashing
R=rsc
http://go/go-review/1026022
2009-11-07 23:59:24 -08:00
Ian Lance Taylor
9bebe741d2
Adjust gccgo license references.
...
gccgo will be distributed under the same license as the rest
of the Go code.
R=r, rsc
http://go/go-review/1024019
2009-11-07 23:42:58 -08:00
Rob Pike
4fe4192ac9
fixes to spec. mostly minor but several of significance.
...
- carriage return is white space
- "" strings cannot span newlines
- f(g()) is ok if g is multivalue and matches f's args
R=rsc, gri
CC=go-dev
http://go/go-review/1024017
2009-11-07 22:00:59 -08:00
Robert Griesemer
642caacfa3
- added link to sources
...
- renamed listing.html -> dirList.html
(there is a dirs.html already, it should probably have a better name, too)
R=rsc
http://go/go-review/1025020
2009-11-07 21:24:48 -08:00