Russ Cox
146a703cd1
cmd/go: add -v flag to build and install
...
The -v flag prints the names of packages as they are built/installed.
Use -v in make.bash/run.bash to avoid a silent pause during
the build while Go code is being compiled.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5532055
2012-01-09 16:44:01 -08:00
Russ Cox
b8615a0931
go: add ... patterns in import path arguments
...
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5530058
2012-01-09 16:23:00 -08:00
Robert Griesemer
22dfc77c99
go/doc: first steps towards cleaning up go/doc
...
- separated exported data structures from doc reader
by extracting all exported data structures into doc.go
and moving the implementation into reader.go
- added missing documentation comments
- no API or semantic changes (but moved positions of
PackageDoc.Doc and TypeDoc.Decl field up for consistency)
- runs all tests
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5527063
2012-01-09 16:14:01 -08:00
Nigel Tao
748fab9d11
html: foreign element HTML integration points, tag name adjustment,
...
shorten the MathML namespace abbreviation from "mathml" to "math".
Python's html5lib uses "mathml", but I think that that is an internal
implementation detail; the test cases use "math".
Pass tests10.dat, test 30:
<div><svg><path><foreignObject><math></div>a
| <html>
| <head>
| <body>
| <div>
| <svg svg>
| <svg path>
| <svg foreignObject>
| <math math>
| "a"
R=andybalholm
CC=golang-dev
https://golang.org/cl/5529044
2012-01-10 11:06:09 +11:00
Russ Cox
0ad241dd55
cmd/go: fix import directory list for compilation
...
This fixes the most annoying bug in the go command,
that 'go build' sometimes ignored packages it had just
rebuilt in favor of stale installed ones.
This part of the code needs more thought, but this small
change is an important improvement.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5531053
2012-01-09 15:38:07 -08:00
Anthony Martin
1421b4ceff
syscall: ignore godefs input when building on Plan 9
...
R=golang-dev, akumar, rsc
CC=golang-dev
https://golang.org/cl/5534055
2012-01-09 15:09:40 -08:00
Russ Cox
cc02ef0258
os: add ModeCharDevice
...
This should make conversion from Unix mode
to os.FileMode and back not lossy.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5531052
2012-01-09 14:22:53 -08:00
Adam Langley
f942736495
crypto/openpgp: truncate hashes before checking DSA signatures.
...
I didn't believe that OpenPGP allowed > SHA-1 with DSA, but it does and
so we need to perform hash truncation.
R=golang-dev, rsc
CC=golang-dev
https://golang.org/cl/5510044
2012-01-09 16:57:51 -05:00
Rémy Oudompheng
f5d024a746
text/template: handle panic values that are not errors.
...
The recover code assumes that the panic() argument was
an error, but it is usually a simple string.
Fixes #2663 .
R=golang-dev, r, r, gri
CC=golang-dev, remy
https://golang.org/cl/5527046
2012-01-09 12:54:31 -08:00
Alexey Borzenkov
793768e9d5
encoding/gob: fix panic when decoding []byte to incompatible slice types
...
Fixes #2662 .
R=golang-dev, rogpeppe, r, r
CC=golang-dev, r, rogpeppe
https://golang.org/cl/5515050
2012-01-09 12:52:03 -08:00
Luuk van Dijk
41806ec26d
gc: remove now redundant typecheck of ->ninit on switches.
...
Fixes #2576 .
R=rsc
CC=golang-dev
https://golang.org/cl/5498105
2012-01-09 21:42:24 +01:00
Ian Lance Taylor
900b8becb3
cgo: if value for constant did not parse, get it from DWARF info
...
R=rsc, borman
CC=golang-dev
https://golang.org/cl/5525043
2012-01-09 11:22:26 -08:00
Robert Griesemer
b4be65bc7f
math/big: simplify fast string conversion
...
- use slice ops for convertWords instead of lo/hi boundaries
- always compute leading zeroes (simplifies logic significantly),
but remove them once, at the end (since leafSize is small, the
worst-case scenario is not adding significant overhead)
- various comment cleanups (specifically, replaced direct -> iterative,
and indirect -> recursive)
- slightly faster overall for -bench=String
(This CL incorporates the changes re: my comments to CL 5418047
https://golang.org/cl/5418047/ )
benchmark old ns/op new ns/op delta
big.BenchmarkString10Base2 519 527 +1.54%
big.BenchmarkString100Base2 2279 2158 -5.31%
big.BenchmarkString1000Base2 18475 17323 -6.24%
big.BenchmarkString10000Base2 178248 166219 -6.75%
big.BenchmarkString100000Base2 1548494 1431587 -7.55%
big.BenchmarkString10Base8 415 422 +1.69%
big.BenchmarkString100Base8 1025 978 -4.59%
big.BenchmarkString1000Base8 6822 6428 -5.78%
big.BenchmarkString10000Base8 64598 61065 -5.47%
big.BenchmarkString100000Base8 593788 549150 -7.52%
big.BenchmarkString10Base10 654 645 -1.38%
big.BenchmarkString100Base10 1863 1835 -1.50%
big.BenchmarkString1000Base10 12099 11981 -0.98%
big.BenchmarkString10000Base10 57601 56888 -1.24%
big.BenchmarkString100000Base10 20123120 19827890 -1.47%
big.BenchmarkString10Base16 358 362 +1.12%
big.BenchmarkString100Base16 815 776 -4.79%
big.BenchmarkString1000Base16 4710 4421 -6.14%
big.BenchmarkString10000Base16 43938 40968 -6.76%
big.BenchmarkString100000Base16 406307 373930 -7.97%
R=michael.jones, mtj
CC=golang-dev
https://golang.org/cl/5432090
2012-01-09 11:20:09 -08:00
Russ Cox
8a4bd094a0
undo CL 5504108 / 0edee03791f4
...
breaks 386 build
««« original CL description
gc: put limit on size of exported recursive interface
Prevents edge-case recursive types from consuming excessive memory.
Fixes #1909 .
R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5504108
»»»
R=lvd, lvd
CC=golang-dev
https://golang.org/cl/5534049
2012-01-09 09:45:08 -08:00
Lorenzo Stoakes
aa63a928ea
gc: put limit on size of exported recursive interface
...
Prevents edge-case recursive types from consuming excessive memory.
Fixes #1909 .
R=golang-dev, lvd, rsc
CC=golang-dev
https://golang.org/cl/5504108
2012-01-09 11:48:53 -05:00
Albert Strasheim
2cb6fcf63f
syscall: Linux-only support for parent death signal
...
As discussed in this thread:
https://groups.google.com/group/golang-dev/browse_thread/thread/5b76b7700265a787
I've tried to come up with a solution that is minimally invasive for the platforms that don't support "parent death signal", without splitting up exec_unix.go.
See also: http://www.win.tue.nl/~aeb/linux/lk/lk-5.html#ss5.8
R=rsc, dave, borman, iant, mikioh.mikioh
CC=golang-dev
https://golang.org/cl/5487061
2012-01-09 21:37:46 +09:00
Andrew Gerrand
c7e91724c0
go/build: handle and warn of duplicate GOPATH entries
...
R=golang-dev, alex.brainman
CC=golang-dev
https://golang.org/cl/5519050
2012-01-09 14:24:05 +11:00
Wei Guangjing
9569c67a6b
windows: use ArbitraryUserPointer as TLS slot
...
R=hectorchu, alex.brainman
CC=golang-dev
https://golang.org/cl/5519054
2012-01-09 11:23:07 +11:00
Florian Weimer
0448ce13a0
encoding/asn1: document support for *big.Int
...
Also add basic tests.
R=golang-dev
CC=golang-dev
https://golang.org/cl/5533045
2012-01-08 10:02:23 -05:00
Sameer Ajmani
1379d90651
time: fix godoc for After and NewTicker.
...
R=golang-dev, gri, bradfitz, iant
CC=golang-dev, rsc
https://golang.org/cl/5523049
2012-01-07 20:53:53 -05:00
Ryan Hitchman
a15448d65e
gc: improve unsafe.Pointer type-check error messages
...
Fixes #2627 .
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5498088
2012-01-06 14:34:16 -08:00
Robert Griesemer
e36acdfb56
sort: eliminate extra Len() call
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5521052
2012-01-05 18:40:17 -08:00
Robert Hencke
a3baccefd6
various: fix prints
...
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5516049
2012-01-05 18:38:01 -08:00
Andrew Gerrand
2c459f14e9
goinstall: fix test data
...
R=gri
CC=golang-dev
https://golang.org/cl/5519048
2012-01-06 09:48:03 +11:00
Eric Eisner
fd1322828c
cmd/go: Pass arguments to command for run
...
Command arguments are separated from input .go file arguments
by a -- separator.
R=rsc, golang-dev, adg
CC=golang-dev
https://golang.org/cl/5514046
2012-01-06 09:23:00 +11:00
Andrew Gerrand
c2ea412296
goinstall: use correct checkout URL for Google Code svn repos
...
Fixes #2655 .
R=golang-dev, gri
CC=golang-dev
https://golang.org/cl/5510045
2012-01-06 09:20:59 +11:00
Roger Peppe
5f5a7eb4bc
go test: don't try to print package with error message.
...
If there's a error compiling a _test.go file, the error
message tries to print a *Package with %s. There's no String
method on *Package, so the error message looks bad.
Since the error messages identify the file in question
anyway, this CL removes the package from the error message.
R=rsc, gri
CC=golang-dev
https://golang.org/cl/5520045
2012-01-05 13:19:25 -08:00
Charles L. Dorian
149d3f06d8
math: fix typo in all_test.go
...
Logb errors were reported as Ilogb errors.
R=rsc, golang-dev, gri
CC=golang-dev
https://golang.org/cl/5517045
2012-01-05 11:04:14 -08:00
Mikio Hara
bab56ecb4d
net: fix incorrect mode on ListenIP, ListenUDP
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5523044
2012-01-05 09:44:25 -08:00
Jeff R. Allen
c581ec4918
crypto/tls: Improve TLS Client Authentication
...
Fix incorrect marshal/unmarshal of certificateRequest.
Add support for configuring client-auth on the server side.
Fix the certificate selection in the client side.
Update generate_cert.go to new time package
Fixes #2521 .
R=krautz, agl, bradfitz
CC=golang-dev, mikkel
https://golang.org/cl/5448093
2012-01-05 12:05:38 -05:00
Andrew Gerrand
2469a817ba
net: update DialIP comments to mention protocols
...
Fixes #2637 .
R=golang-dev, mikioh.mikioh, iant
CC=golang-dev
https://golang.org/cl/5508043
2012-01-05 15:18:08 +11:00
Alex Brainman
b682da32b3
make.bash: remove old dregs
...
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5522043
2012-01-05 14:17:32 +11:00
Sanjay Menakuru
2693232f16
cmd/go: include external test files in the files sent to gofmt, govet, and gofix
...
Also, add XTestGoFiles to the go command's public api.
Fixes #2649 .
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502102
2012-01-05 10:37:15 +11:00
Robert Griesemer
3f1eb94ef2
runtime: fix typo in comment
...
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5511047
2012-01-04 14:06:54 -08:00
Adam Langley
d5e6b8d016
crypto/tls: update generate_cert.go for new time package
...
Fixes #2635 .
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5512043
2012-01-04 14:56:16 -05:00
Dave Cheney
424f53fa0c
exp/ssh: fix two flow control bugs in chanWriter
...
This CL fixes two issues sending data to the remote peer.
The first bug occurs when the size of the buffer passed to
Write is larger than the current window, in this case, w.rwin
can become negative.
The second issue is more problematic than the first as the
amount of data passed to writePacket was not limited to w.rwin.
In this case the remote peer could silently drop the additional
data, or drop the connection.
Credit to Jacek Masiulaniec for the bug report.
R=agl, jacek.masiulaniec
CC=golang-dev
https://golang.org/cl/5511043
2012-01-04 10:36:21 -05:00
Andrew Gerrand
9d92676f63
unsafe: refer to correct reflect functions
...
Fixes #2641 .
R=golang-dev, dsymonds
CC=golang-dev
https://golang.org/cl/5509043
2012-01-04 17:14:56 +11:00
Andrew Balholm
99fed2be27
html: parse <frameset> inside body
...
Pass tests6.dat, test 47:
<param><frameset></frameset>
| <html>
| <head>
| <frameset>
Also pass remaining tests in tests6.dat.
R=nigeltao
CC=golang-dev
https://golang.org/cl/5489136
2012-01-04 09:51:15 +11:00
Sanjay Menakuru
7ccd505dc4
cmd/go: include test files in the files sent to gofmt, govet, and gofix
...
Also, add TestGoFiles to the go command's public api.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5505083
2012-01-03 14:12:54 +11:00
Evan Shaw
c20c09251c
encoding/json: don't marshal special float values
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5500084
2012-01-03 12:30:18 +11:00
Michael Shields
38ff98b4c6
encoding/xml: use strings.Reader in tests.
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5502083
2012-01-03 12:22:02 +11:00
Christoph Hack
a274798d6e
cmd/go: refer to the right command in the doc description.
...
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5501072
2012-01-03 12:06:12 +11:00
Benny Siegert
8e9e75f008
gotest: make _testmain.go conform to gofmt rules
...
Otherwise, running "gofmt -d ." after "gotest" gives some
spurious changes.
R=golang-dev, adg
CC=golang-dev
https://golang.org/cl/5504101
2012-01-03 12:00:39 +11:00
Dave Cheney
7f20bcbbcb
exp/ssh: various small fixes
...
transport.go:
* remove unused nil check.
doc.go:
* improve documentation about supported auth
methods and update Run example.
Thanks Jacek Masiulaniec for both reports.
R=jacek.masiulaniec, agl
CC=golang-dev
https://golang.org/cl/5501075
2011-12-27 09:49:19 -05:00
Rob Pike
6a88f1c4cb
bytes.Buffer: read of 0 bytes at EOF shouldn't be an EOF
...
This corner case arose doing an RPC with a empty-slice payload. Ouch.
R=golang-dev, iant
CC=golang-dev
https://golang.org/cl/5505073
2011-12-26 23:49:24 -08:00
Vadim Vygonets
f71c03af90
log/syslog: add Alert method
...
Alert logs a message using the LOG_ALERT priority.
Fixes #2325 .
R=mikioh.mikioh, rsc
CC=golang-dev
https://golang.org/cl/5504058
2011-12-26 09:34:27 +09:00
David Symonds
98b90475ac
flag: change Set method Value interface to return error instead of bool.
...
This yields much better error messages when a bad flag value is given.
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/5498078
2011-12-25 16:12:26 +11:00
David Symonds
57c9bb4a07
testing: use flag.Duration for -timeout flag.
...
R=golang-dev, gustavo, r
CC=golang-dev
https://golang.org/cl/5498077
2011-12-25 16:07:05 +11:00
Nigel Tao
d5e45e3a8a
html: adjust foreign attributes.
...
Pass tests10.dat, test 22:
<!DOCTYPE html><body xlink:href=foo><svg xlink:href=foo></svg>
| <!DOCTYPE html>
| <html>
| <head>
| <body>
| xlink:href="foo"
| <svg svg>
| xlink href="foo"
Also pass tests through test 29:
<div><svg><path></svg><path>
R=andybalholm
CC=golang-dev
https://golang.org/cl/5489117
2011-12-25 12:42:47 +11:00
Andrew Balholm
b28f017537
html: "in select in table" insertion mode.
...
Pass tests10.dat, test 16:
<!DOCTYPE
html><body><table><tr><td><select><svg><g>foo</g><g>bar</g><p>baz</table><p>quux
| <!DOCTYPE html>
| <html>
| <head>
| <body>
| <table>
| <tbody>
| <tr>
| <td>
| <select>
| "foobarbaz"
| <p>
| "quux"
Also pass tests through test 21:
<!DOCTYPE html><frameset></frameset><svg><g></g><g></g><p><span>
R=nigeltao
CC=golang-dev
https://golang.org/cl/5505069
2011-12-24 11:07:14 +11:00
