qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-06 19:46:20 -07:00
Code Releases Activity

Revert "cmd/vet: ignore printf failures in cmd"

Browse Source 
This reverts commit f15915af4e.

CL 32851 fixed cmd/vet's handling of fmt.Formatter.

Updates #17057.

Change-Id: I3409100d16037645946fe7fe78fbb173e1648494
Reviewed-on: https://go-review.googlesource.com/33166
Run-TryBot: Josh Bleecher Snyder <josharian@gmail.com>
TryBot-Result: Gobot Gobot <gobot@golang.org>
Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
This commit is contained in:
Josh Bleecher Snyder 2016-11-13 12:59:07 -08:00 committed by Brad Fitzpatrick
parent 7c9f910607
commit f8dc4f20f8
1 changed files with 0 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/cmd/vet/all/main.go
View File

@ -265,15 +265,6 @@ NextLine:
} }
} }
// Temporarily ignore unrecognized printf verbs from cmd.
// The compiler now has several fancy verbs (CL 28339)
// used with types implementing fmt.Formatters,
// and I believe gri has plans to add many more.
// TODO: remove when issue 17057 is fixed.
if strings.HasPrefix(file, "cmd/") && strings.HasPrefix(msg, "unrecognized printf verb") {
continue
}
key := file + ": " + msg key := file + ": " + msg
if w[key] == 0 { if w[key] == 0 {
// Vet error with no match in the whitelist. Print it. // Vet error with no match in the whitelist. Print it.