From f8dc4f20f8f8cb2ac8ee14b15ed4bf5201b61e81 Mon Sep 17 00:00:00 2001 From: Josh Bleecher Snyder Date: Sun, 13 Nov 2016 12:59:07 -0800 Subject: [PATCH] Revert "cmd/vet: ignore printf failures in cmd" This reverts commit f15915af4effbbe6895ae69be02d22ac016927d5. CL 32851 fixed cmd/vet's handling of fmt.Formatter. Updates #17057. Change-Id: I3409100d16037645946fe7fe78fbb173e1648494 Reviewed-on: https://go-review.googlesource.com/33166 Run-TryBot: Josh Bleecher Snyder TryBot-Result: Gobot Gobot Reviewed-by: Brad Fitzpatrick --- src/cmd/vet/all/main.go | 9 --------- 1 file changed, 9 deletions(-) diff --git a/src/cmd/vet/all/main.go b/src/cmd/vet/all/main.go index bcf97777dad..f4ee8fe15ae 100644 --- a/src/cmd/vet/all/main.go +++ b/src/cmd/vet/all/main.go @@ -265,15 +265,6 @@ NextLine: } } - // Temporarily ignore unrecognized printf verbs from cmd. - // The compiler now has several fancy verbs (CL 28339) - // used with types implementing fmt.Formatters, - // and I believe gri has plans to add many more. - // TODO: remove when issue 17057 is fixed. - if strings.HasPrefix(file, "cmd/") && strings.HasPrefix(msg, "unrecognized printf verb") { - continue - } - key := file + ": " + msg if w[key] == 0 { // Vet error with no match in the whitelist. Print it.