qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-11 18:21:40 -07:00
Code Releases Activity

[release-branch.go1.17] runtime: skip TestGdbBacktrace flakes matching a known GDB internal error

Browse Source 
TestGdbBacktrace occasionally fails due to a GDB internal error.
We have observed the error on various linux builders since at least
October 2020, and it has been reported upstream at least twice.¹²

Since the bug is external to the Go project and does not appear to be
fixed upstream, this failure mode can only add noise.

¹https://sourceware.org/bugzilla/show_bug.cgi?id=24628
²https://sourceware.org/bugzilla/show_bug.cgi?id=28551

Fixes #53049
Updates #43068

Change-Id: I6c92006a5d730f1c4df54b0307f080b3d643cc6b
Reviewed-on: https://go-review.googlesource.com/c/go/+/384234
Trust: Bryan Mills <bcmills@google.com>
Run-TryBot: Bryan Mills <bcmills@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
(cherry picked from commit 275aedccd4)
Reviewed-on: https://go-review.googlesource.com/c/go/+/408054
Reviewed-by: Alex Rakoczy <alex@golang.org>
This commit is contained in:
Bryan C. Mills 2022-02-08 15:07:21 -05:00 committed by Alex Rakoczy
parent a9003376d5
commit e846f3f2d6
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
src/runtime/runtime-gdb_test.go
View File

@ -427,6 +427,9 @@ func TestGdbBacktrace(t *testing.T) {
got, err := exec.Command("gdb", args...).CombinedOutput() got, err := exec.Command("gdb", args...).CombinedOutput()
t.Logf("gdb output:\n%s", got) t.Logf("gdb output:\n%s", got)
if err != nil { if err != nil {
if bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")) {
testenv.SkipFlaky(t, 43068)
}
t.Fatalf("gdb exited with error: %v", err) t.Fatalf("gdb exited with error: %v", err)
} }