From e846f3f2d602ec5fd4689e14d7530d894b807e70 Mon Sep 17 00:00:00 2001 From: "Bryan C. Mills" Date: Tue, 8 Feb 2022 15:07:21 -0500 Subject: [PATCH] [release-branch.go1.17] runtime: skip TestGdbBacktrace flakes matching a known GDB internal error MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit TestGdbBacktrace occasionally fails due to a GDB internal error. We have observed the error on various linux builders since at least October 2020, and it has been reported upstream at least twice.¹² Since the bug is external to the Go project and does not appear to be fixed upstream, this failure mode can only add noise. ¹https://sourceware.org/bugzilla/show_bug.cgi?id=24628 ²https://sourceware.org/bugzilla/show_bug.cgi?id=28551 Fixes #53049 Updates #43068 Change-Id: I6c92006a5d730f1c4df54b0307f080b3d643cc6b Reviewed-on: https://go-review.googlesource.com/c/go/+/384234 Trust: Bryan Mills Run-TryBot: Bryan Mills Reviewed-by: Michael Pratt TryBot-Result: Gopher Robot (cherry picked from commit 275aedccd4f2beae82dbf96c94a6c1c9b365a647) Reviewed-on: https://go-review.googlesource.com/c/go/+/408054 Reviewed-by: Alex Rakoczy --- src/runtime/runtime-gdb_test.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index 8c76a9123c..097d1b5c6a 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -427,6 +427,9 @@ func TestGdbBacktrace(t *testing.T) { got, err := exec.Command("gdb", args...).CombinedOutput() t.Logf("gdb output:\n%s", got) if err != nil { + if bytes.Contains(got, []byte("internal-error: wait returned unexpected status 0x0")) { + testenv.SkipFlaky(t, 43068) + } t.Fatalf("gdb exited with error: %v", err) }