mirror of
https://github.com/golang/go
synced 2024-11-18 13:44:48 -07:00
internal/lsp/source: disable fillstruct by default
The discussion on golang/vscode-go#299 has uncovered the fact that go/printer is very expensive, and we're calling it frequently on file changes. Analyzers whose suggested fixes require the original file content are generally posing issues; this is being discussed on golang/go#40110. Updates golang/vscode-go#299 Change-Id: I5cb370c9cb508203e463e7243fc781e75876fe30 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241321 Run-TryBot: Rebecca Stambler <rstambler@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Heschi Kreinick <heschi@google.com>
This commit is contained in:
parent
065b96d36c
commit
d5a745333d
@ -659,7 +659,7 @@ func convenienceAnalyzers() map[string]Analyzer {
|
|||||||
return map[string]Analyzer{
|
return map[string]Analyzer{
|
||||||
fillstruct.Analyzer.Name: {
|
fillstruct.Analyzer.Name: {
|
||||||
Analyzer: fillstruct.Analyzer,
|
Analyzer: fillstruct.Analyzer,
|
||||||
enabled: true,
|
enabled: false,
|
||||||
},
|
},
|
||||||
}
|
}
|
||||||
}
|
}
|
||||||
|
Loading…
Reference in New Issue
Block a user