From d5a745333dac1eb2a0fc10ac9cc193e7f2a28b9b Mon Sep 17 00:00:00 2001 From: Rebecca Stambler Date: Tue, 7 Jul 2020 18:14:12 -0400 Subject: [PATCH] internal/lsp/source: disable fillstruct by default The discussion on golang/vscode-go#299 has uncovered the fact that go/printer is very expensive, and we're calling it frequently on file changes. Analyzers whose suggested fixes require the original file content are generally posing issues; this is being discussed on golang/go#40110. Updates golang/vscode-go#299 Change-Id: I5cb370c9cb508203e463e7243fc781e75876fe30 Reviewed-on: https://go-review.googlesource.com/c/tools/+/241321 Run-TryBot: Rebecca Stambler TryBot-Result: Gobot Gobot Reviewed-by: Heschi Kreinick --- internal/lsp/source/options.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/internal/lsp/source/options.go b/internal/lsp/source/options.go index 51c0199b6a..b8fde36b01 100644 --- a/internal/lsp/source/options.go +++ b/internal/lsp/source/options.go @@ -659,7 +659,7 @@ func convenienceAnalyzers() map[string]Analyzer { return map[string]Analyzer{ fillstruct.Analyzer.Name: { Analyzer: fillstruct.Analyzer, - enabled: true, + enabled: false, }, } }