qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 07:14:40 -07:00
Code Releases Activity

misc/dashboard/codereview: remove transitional code.

Browse Source 
All current CLs have subject lines, so we don't need to check any more.

R=golang-dev, bradfitz
CC=golang-dev
https://golang.org/cl/6196044
This commit is contained in:
David Symonds 2012-05-04 16:40:24 +10:00
parent 3fab2a97e4
commit c44a22cc49
1 changed files with 13 additions and 17 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

30
misc/dashboard/codereview/dashboard/cl.go
View File

@ -183,23 +183,19 @@ func handleAssign(w http.ResponseWriter, r *http.Request) {
http.Error(w, err.Error(), 500)
return
}
// The current data does not have the subject/recipient information.
// TODO(dsymonds): Remove this if when all the CLs have subject lines.
if cl.Subject != "" {
msg := &mail.Message{
Sender: u.Email,
To: []string{preferredEmail[rev]},
Cc: cl.Recipients,
// Take care to match Rietveld's subject line
// so that Gmail will correctly thread mail.
Subject: cl.Subject + " (issue " + n + ")",
Body: "R=" + rev + "\n\n(sent by gocodereview)",
}
// TODO(dsymonds): Use cl.LastMessageID as the In-Reply-To header
// when the appengine/mail package supports that.
if err := mail.Send(c, msg); err != nil {
c.Errorf("mail.Send: %v", err)
}
msg := &mail.Message{
Sender: u.Email,
To: []string{preferredEmail[rev]},
Cc: cl.Recipients,
// Take care to match Rietveld's subject line
// so that Gmail will correctly thread mail.
Subject: cl.Subject + " (issue " + n + ")",
Body: "R=" + rev + "\n\n(sent by gocodereview)",
}
// TODO(dsymonds): Use cl.LastMessageID as the In-Reply-To header
// when the appengine/mail package supports that.
if err := mail.Send(c, msg); err != nil {
c.Errorf("mail.Send: %v", err)
}
}
}