From c44a22cc495c10f96e9842d433af7aec6f713243 Mon Sep 17 00:00:00 2001 From: David Symonds Date: Fri, 4 May 2012 16:40:24 +1000 Subject: [PATCH] misc/dashboard/codereview: remove transitional code. All current CLs have subject lines, so we don't need to check any more. R=golang-dev, bradfitz CC=golang-dev https://golang.org/cl/6196044 --- misc/dashboard/codereview/dashboard/cl.go | 30 ++++++++++------------- 1 file changed, 13 insertions(+), 17 deletions(-) diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go index 669c49cdb56..e92b4e1a468 100644 --- a/misc/dashboard/codereview/dashboard/cl.go +++ b/misc/dashboard/codereview/dashboard/cl.go @@ -183,23 +183,19 @@ func handleAssign(w http.ResponseWriter, r *http.Request) { http.Error(w, err.Error(), 500) return } - // The current data does not have the subject/recipient information. - // TODO(dsymonds): Remove this if when all the CLs have subject lines. - if cl.Subject != "" { - msg := &mail.Message{ - Sender: u.Email, - To: []string{preferredEmail[rev]}, - Cc: cl.Recipients, - // Take care to match Rietveld's subject line - // so that Gmail will correctly thread mail. - Subject: cl.Subject + " (issue " + n + ")", - Body: "R=" + rev + "\n\n(sent by gocodereview)", - } - // TODO(dsymonds): Use cl.LastMessageID as the In-Reply-To header - // when the appengine/mail package supports that. - if err := mail.Send(c, msg); err != nil { - c.Errorf("mail.Send: %v", err) - } + msg := &mail.Message{ + Sender: u.Email, + To: []string{preferredEmail[rev]}, + Cc: cl.Recipients, + // Take care to match Rietveld's subject line + // so that Gmail will correctly thread mail. + Subject: cl.Subject + " (issue " + n + ")", + Body: "R=" + rev + "\n\n(sent by gocodereview)", + } + // TODO(dsymonds): Use cl.LastMessageID as the In-Reply-To header + // when the appengine/mail package supports that. + if err := mail.Send(c, msg); err != nil { + c.Errorf("mail.Send: %v", err) } } }