qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-21 21:54:40 -07:00
Code Releases Activity

exp/draw/x11: mouse location is a signed integer.

Browse Source 
R=r
CC=golang-dev
https://golang.org/cl/2192043
This commit is contained in:
Nigel Tao 2010-09-20 10:18:09 +10:00
parent 1e4b1f9337
commit afbee9d87d
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/pkg/exp/draw/x11/conn.go
View File

@ -218,19 +218,18 @@ func (c *conn) readSocket() {
c.mouseState.Nsec = time.Nanoseconds()
c.eventc <- c.mouseState
case 0x06: // Motion notify.
c.mouseState.Loc.X = int(c.buf[25])<<8 | int(c.buf[24])
c.mouseState.Loc.Y = int(c.buf[27])<<8 | int(c.buf[26])
c.mouseState.Loc.X = int(int16(c.buf[25])<<8 | int16(c.buf[24]))
c.mouseState.Loc.Y = int(int16(c.buf[27])<<8 | int16(c.buf[26]))
c.mouseState.Nsec = time.Nanoseconds()
c.eventc <- c.mouseState
case 0x0c: // Expose.
// A single user action could trigger multiple expose events (e.g. if moving another
// window with XShape'd rounded corners over our window). In that case, the X server
// will send a count (in bytes 16-17) of the number of additional expose events coming.
// window with XShape'd rounded corners over our window). In that case, the X server will
// send a uint16 count (in bytes 16-17) of the number of additional expose events coming.
// We could parse each event for the (x, y, width, height) and maintain a minimal dirty
// rectangle, but for now, the simplest approach is to paint the entire window, when
// receiving the final event in the series.
count := int(c.buf[17])<<8 | int(c.buf[16])
if count == 0 {
if c.buf[17] == 0 && c.buf[16] == 0 {
// TODO(nigeltao): Should we ignore the very first expose event? A freshly mapped window
// will trigger expose, but until the first c.FlushImage call, there's probably nothing to
// paint but black. For an 800x600 window, at 4 bytes per pixel, each repaint writes about