qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 02:04:42 -07:00
Code Releases Activity

cmd/compile/internal/syntax: use strings.LastIndexByte in trailingDigits

Browse Source 
Previously, strings.LastIndexByte couldn't be used because it was only
added in Go 1.5 but Go 1.4 was required for bootstrapping. In Go 1.18,
the bootstrap toolchain was bumped to Go 1.17 (see #44505), thus
strings.LastIndexByte can be used now.

Change-Id: I01a70a59dbfc853cf03d49747a2dd62d21ba74e9
Reviewed-on: https://go-review.googlesource.com/c/go/+/522197
Reviewed-by: Ian Lance Taylor <iant@google.com>
Run-TryBot: Tobias Klauser <tobias.klauser@gmail.com>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Auto-Submit: Tobias Klauser <tobias.klauser@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Daniel Martí <mvdan@mvdan.cc>
This commit is contained in:
Tobias Klauser 2023-08-24 11:58:58 +02:00 committed by Gopher Robot
parent e63be91667
commit 96b6e78ea9
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/cmd/compile/internal/syntax/parser.go
View File

@ -181,10 +181,9 @@ func commentText(s string) string {
} }
func trailingDigits(text string) (uint, uint, bool) { func trailingDigits(text string) (uint, uint, bool) {
// Want to use LastIndexByte below but it's not defined in Go1.4 and bootstrap fails. i := strings.LastIndexByte(text, ':') // look from right (Windows filenames may contain ':')
i := strings.LastIndex(text, ":") // look from right (Windows filenames may contain ':')
if i < 0 { if i < 0 {
return 0, 0, false // no ":" return 0, 0, false // no ':'
} }
// i >= 0 // i >= 0
n, err := strconv.ParseUint(text[i+1:], 10, 0) n, err := strconv.ParseUint(text[i+1:], 10, 0)