qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-18 22:44:48 -07:00
Code Releases Activity

cmd/go: clarify promotion of C warnings to errors

Browse Source 
CL 23005 (back in 2016!) added logic to promote C compiler warnings to
errors when running on the Go builders.

CL 437298 kept the logic to promote warnings to errors on the
builders, but dropped the explanatory message, I believe
unintentionally. Indeed, now there isn't even a comment in the code
explaining what's going on.

This CL adds back an explanatory message to the printed output, which
also serves as a explanation in the code as to why we're checking
$GO_BUILDER_NAME.

Change-Id: I769c55d213f96f73d20a41ab926fb91e71a5a22c
Reviewed-on: https://go-review.googlesource.com/c/go/+/522775
Run-TryBot: Austin Clements <austin@google.com>
Reviewed-by: Bryan Mills <bcmills@google.com>
Auto-Submit: Austin Clements <austin@google.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
This commit is contained in:
Austin Clements 2023-08-24 15:14:44 -04:00 committed by Gopher Robot
parent f0b05092fd
commit e63be91667
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/cmd/go/internal/work/exec.go
View File

@ -2683,7 +2683,11 @@ func (b *Builder) ccompile(a *Action, p *load.Package, outfile string, flags []s
}
}
if err != nil || os.Getenv("GO_BUILDER_NAME") != "" {
if err == nil && os.Getenv("GO_BUILDER_NAME") != "" {
output = append(output, "C compiler warning promoted to error on Go builders\n"...)
err = errors.New("warning promoted to error")
}
if err != nil {
err = formatOutput(b.WorkDir, p.Dir, p.ImportPath, p.Desc(), b.processOutput(output))
} else {
b.showOutput(a, p.Dir, p.Desc(), b.processOutput(output))