qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-26 23:11:24 -07:00
Code Releases Activity

cmd/compile: fix wrong dict param when getting dict type

Browse Source 
CL 338129 added getDictionaryType to get the dictionary type from the
specified dict param, but still using the one in info.dictParam, which
is wrong.

Fixes #51413

Change-Id: Ie13460c1e5751c4c5fc44479a44f6eed8b3b06e4
Reviewed-on: https://go-review.googlesource.com/c/go/+/391994
Trust: Cuong Manh Le <cuong.manhle.vn@gmail.com>
Run-TryBot: Cuong Manh Le <cuong.manhle.vn@gmail.com>
TryBot-Result: Gopher Robot <gobot@golang.org>
Reviewed-by: Matthew Dempsky <mdempsky@google.com>
Trust: Matthew Dempsky <mdempsky@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
This commit is contained in:
Cuong Manh Le 2022-03-13 00:04:46 +07:00
parent 676858f3d4
commit 8419ec295c
2 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/cmd/compile/internal/noder/stencil.go
View File

@ -898,7 +898,7 @@ func getDictionaryType(info *instInfo, dictParam *ir.Name, pos src.XPos, i int)
base.Fatalf(fmt.Sprintf("bad dict index %d", i)) base.Fatalf(fmt.Sprintf("bad dict index %d", i))
} }
r := getDictionaryEntry(pos, info.dictParam, i, info.dictInfo.startSubDict) r := getDictionaryEntry(pos, dictParam, i, info.dictInfo.startSubDict)
// change type of retrieved dictionary entry to *byte, which is the // change type of retrieved dictionary entry to *byte, which is the
// standard typing of a *runtime._type in the compiler // standard typing of a *runtime._type in the compiler
typed(types.Types[types.TUINT8].PtrTo(), r) typed(types.Types[types.TUINT8].PtrTo(), r)

2
test/typeparam/mdempsky/13.go
View File

@ -1,4 +1,4 @@
// run -gcflags="" // run
// Copyright 2021 The Go Authors. All rights reserved. // Copyright 2021 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style // Use of this source code is governed by a BSD-style