From 8419ec295cd86a3d26cd360ef5f919a51fe33ebb Mon Sep 17 00:00:00 2001 From: Cuong Manh Le Date: Sun, 13 Mar 2022 00:04:46 +0700 Subject: [PATCH] cmd/compile: fix wrong dict param when getting dict type CL 338129 added getDictionaryType to get the dictionary type from the specified dict param, but still using the one in info.dictParam, which is wrong. Fixes #51413 Change-Id: Ie13460c1e5751c4c5fc44479a44f6eed8b3b06e4 Reviewed-on: https://go-review.googlesource.com/c/go/+/391994 Trust: Cuong Manh Le Run-TryBot: Cuong Manh Le TryBot-Result: Gopher Robot Reviewed-by: Matthew Dempsky Trust: Matthew Dempsky Reviewed-by: Keith Randall --- src/cmd/compile/internal/noder/stencil.go | 2 +- test/typeparam/mdempsky/13.go | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/cmd/compile/internal/noder/stencil.go b/src/cmd/compile/internal/noder/stencil.go index cd586cab784..c78a169d310 100644 --- a/src/cmd/compile/internal/noder/stencil.go +++ b/src/cmd/compile/internal/noder/stencil.go @@ -898,7 +898,7 @@ func getDictionaryType(info *instInfo, dictParam *ir.Name, pos src.XPos, i int) base.Fatalf(fmt.Sprintf("bad dict index %d", i)) } - r := getDictionaryEntry(pos, info.dictParam, i, info.dictInfo.startSubDict) + r := getDictionaryEntry(pos, dictParam, i, info.dictInfo.startSubDict) // change type of retrieved dictionary entry to *byte, which is the // standard typing of a *runtime._type in the compiler typed(types.Types[types.TUINT8].PtrTo(), r) diff --git a/test/typeparam/mdempsky/13.go b/test/typeparam/mdempsky/13.go index bf37a64177a..8e11352b514 100644 --- a/test/typeparam/mdempsky/13.go +++ b/test/typeparam/mdempsky/13.go @@ -1,4 +1,4 @@ -// run -gcflags="" +// run // Copyright 2021 The Go Authors. All rights reserved. // Use of this source code is governed by a BSD-style