qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-25 13:17:56 -07:00
Code Releases Activity

misc/dashboard/codereview: de-dup LGTMs.

Browse Source 
R=golang-dev, r
CC=golang-dev
https://golang.org/cl/6127066
This commit is contained in:
David Symonds 2012-05-01 11:41:32 +10:00
parent c3c8e35af2
commit 83aa040c45
1 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
misc/dashboard/codereview/dashboard/cl.go
View File

@ -304,6 +304,7 @@ func updateCL(c appengine.Context, n string) error {
if i := strings.Index(cl.FirstLine, "\n"); i >= 0 { if i := strings.Index(cl.FirstLine, "\n"); i >= 0 {
cl.FirstLine = cl.FirstLine[:i] cl.FirstLine = cl.FirstLine[:i]
} }
lgtm := make(map[string]bool)
rcpt := make(map[string]bool) rcpt := make(map[string]bool)
for _, msg := range apiResp.Messages { for _, msg := range apiResp.Messages {
s, rev := msg.Sender, false s, rev := msg.Sender, false
@ -320,14 +321,16 @@ func updateCL(c appengine.Context, n string) error {
} }
if msg.Approval { if msg.Approval {
// TODO(dsymonds): De-dupe LGTMs. lgtm[s] = true
cl.LGTMs = append(cl.LGTMs, s)
} }
for _, r := range msg.Recipients { for _, r := range msg.Recipients {
rcpt[r] = true rcpt[r] = true
} }
} }
for l := range lgtm {
cl.LGTMs = append(cl.LGTMs, l)
}
for r := range rcpt { for r := range rcpt {
cl.Recipients = append(cl.Recipients, r) cl.Recipients = append(cl.Recipients, r)
} }