From 83aa040c450a6f1af22a61c2691e42e481b87beb Mon Sep 17 00:00:00 2001 From: David Symonds Date: Tue, 1 May 2012 11:41:32 +1000 Subject: [PATCH] misc/dashboard/codereview: de-dup LGTMs. R=golang-dev, r CC=golang-dev https://golang.org/cl/6127066 --- misc/dashboard/codereview/dashboard/cl.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/misc/dashboard/codereview/dashboard/cl.go b/misc/dashboard/codereview/dashboard/cl.go index bafef439bdb..13ff8f645cb 100644 --- a/misc/dashboard/codereview/dashboard/cl.go +++ b/misc/dashboard/codereview/dashboard/cl.go @@ -304,6 +304,7 @@ func updateCL(c appengine.Context, n string) error { if i := strings.Index(cl.FirstLine, "\n"); i >= 0 { cl.FirstLine = cl.FirstLine[:i] } + lgtm := make(map[string]bool) rcpt := make(map[string]bool) for _, msg := range apiResp.Messages { s, rev := msg.Sender, false @@ -320,14 +321,16 @@ func updateCL(c appengine.Context, n string) error { } if msg.Approval { - // TODO(dsymonds): De-dupe LGTMs. - cl.LGTMs = append(cl.LGTMs, s) + lgtm[s] = true } for _, r := range msg.Recipients { rcpt[r] = true } } + for l := range lgtm { + cl.LGTMs = append(cl.LGTMs, l) + } for r := range rcpt { cl.Recipients = append(cl.Recipients, r) }