qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 07:14:40 -07:00
Code Releases Activity

cmd/8g: fix miscompilation due to BADWIDTH.

Browse Source 
Fixes #3899.

R=rsc
CC=golang-dev, remy
https://golang.org/cl/6453084
This commit is contained in:
Rémy Oudompheng 2012-08-03 22:05:51 +02:00
parent f4f1ba2b1e
commit 823962c521
2 changed files with 29 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/cmd/8g/gsubr.c
View File

@ -1853,6 +1853,7 @@ naddr(Node *n, Addr *a, int canemitcode)
a->width = 0; a->width = 0;
if(n->type != T) { if(n->type != T) {
a->etype = simtype[n->type->etype]; a->etype = simtype[n->type->etype];
dowidth(n->type);
a->width = n->type->width; a->width = n->type->width;
a->gotype = ngotype(n); a->gotype = ngotype(n);
} }

28
test/fixedbugs/bug450.go Normal file
View File

@ -0,0 +1,28 @@
// run
// Copyright 2012 The Go Authors. All rights reserved.
// Use of this source code is governed by a BSD-style
// license that can be found in the LICENSE file.
// Issue 3899: 8g incorrectly thinks a variable is
// "set but not used" and elides an assignment, causing
// variables to end up with wrong data.
//
// The reason is a miscalculation of variable width.
package main
func bar(f func()) {
f()
}
func foo() {
f := func() {}
if f == nil {
}
bar(f)
}
func main() {
foo()
}