qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-19 15:34:47 -07:00
Code Releases Activity

runtime: skip gdb tests earlier before blocking goroutines in a t.Parallel

Browse Source 
Minor.

Makes reading failing runtime test stacktraces easier (by having fewer
goroutines to read) on machines where these gdb tests wouldn't have
ever run anyway.

Change-Id: I3fab0667e017f20ef3bf96a8cc4cfcc614d25b5c
Reviewed-on: https://go-review.googlesource.com/81575
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Run-TryBot: Ian Lance Taylor <iant@golang.org>
TryBot-Result: Gobot Gobot <gobot@golang.org>
This commit is contained in:
Brad Fitzpatrick 2017-12-01 19:26:33 +00:00
parent 2e5011d802
commit 7b57e21a07
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/runtime/runtime-gdb_test.go
View File

@ -110,8 +110,8 @@ func testGdbPython(t *testing.T, cgo bool) {
t.Skip("skipping because cgo is not enabled") t.Skip("skipping because cgo is not enabled")
} }
t.Parallel()
checkGdbEnvironment(t) checkGdbEnvironment(t)
t.Parallel()
checkGdbVersion(t) checkGdbVersion(t)
checkGdbPython(t) checkGdbPython(t)
@ -266,8 +266,8 @@ func TestGdbBacktrace(t *testing.T) {
testenv.SkipFlaky(t, 15603) testenv.SkipFlaky(t, 15603)
} }
t.Parallel()
checkGdbEnvironment(t) checkGdbEnvironment(t)
t.Parallel()
checkGdbVersion(t) checkGdbVersion(t)
dir, err := ioutil.TempDir("", "go-build") dir, err := ioutil.TempDir("", "go-build")
@ -336,8 +336,8 @@ func main() {
// TestGdbAutotmpTypes ensures that types of autotmp variables appear in .debug_info // TestGdbAutotmpTypes ensures that types of autotmp variables appear in .debug_info
// See bug #17830. // See bug #17830.
func TestGdbAutotmpTypes(t *testing.T) { func TestGdbAutotmpTypes(t *testing.T) {
t.Parallel()
checkGdbEnvironment(t) checkGdbEnvironment(t)
t.Parallel()
checkGdbVersion(t) checkGdbVersion(t)
dir, err := ioutil.TempDir("", "go-build") dir, err := ioutil.TempDir("", "go-build")
@ -401,8 +401,8 @@ func main() {
` `
func TestGdbConst(t *testing.T) { func TestGdbConst(t *testing.T) {
t.Parallel()
checkGdbEnvironment(t) checkGdbEnvironment(t)
t.Parallel()
checkGdbVersion(t) checkGdbVersion(t)
dir, err := ioutil.TempDir("", "go-build") dir, err := ioutil.TempDir("", "go-build")