From 7b57e21a075b876903c735b3988a5be86c01f078 Mon Sep 17 00:00:00 2001 From: Brad Fitzpatrick Date: Fri, 1 Dec 2017 19:26:33 +0000 Subject: [PATCH] runtime: skip gdb tests earlier before blocking goroutines in a t.Parallel Minor. Makes reading failing runtime test stacktraces easier (by having fewer goroutines to read) on machines where these gdb tests wouldn't have ever run anyway. Change-Id: I3fab0667e017f20ef3bf96a8cc4cfcc614d25b5c Reviewed-on: https://go-review.googlesource.com/81575 Reviewed-by: Ian Lance Taylor Run-TryBot: Ian Lance Taylor TryBot-Result: Gobot Gobot --- src/runtime/runtime-gdb_test.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/runtime/runtime-gdb_test.go b/src/runtime/runtime-gdb_test.go index 1a70a5d7a1..5e0508631f 100644 --- a/src/runtime/runtime-gdb_test.go +++ b/src/runtime/runtime-gdb_test.go @@ -110,8 +110,8 @@ func testGdbPython(t *testing.T, cgo bool) { t.Skip("skipping because cgo is not enabled") } - t.Parallel() checkGdbEnvironment(t) + t.Parallel() checkGdbVersion(t) checkGdbPython(t) @@ -266,8 +266,8 @@ func TestGdbBacktrace(t *testing.T) { testenv.SkipFlaky(t, 15603) } - t.Parallel() checkGdbEnvironment(t) + t.Parallel() checkGdbVersion(t) dir, err := ioutil.TempDir("", "go-build") @@ -336,8 +336,8 @@ func main() { // TestGdbAutotmpTypes ensures that types of autotmp variables appear in .debug_info // See bug #17830. func TestGdbAutotmpTypes(t *testing.T) { - t.Parallel() checkGdbEnvironment(t) + t.Parallel() checkGdbVersion(t) dir, err := ioutil.TempDir("", "go-build") @@ -401,8 +401,8 @@ func main() { ` func TestGdbConst(t *testing.T) { - t.Parallel() checkGdbEnvironment(t) + t.Parallel() checkGdbVersion(t) dir, err := ioutil.TempDir("", "go-build")