qbit/go
1
0
Fork 0
mirror of https://github.com/golang/go synced 2024-11-22 06:04:39 -07:00
Code Releases Activity

codereview: drop Author: line on self-clpatch

Browse Source 
Right now if a Go developer makes a patch on one machine
and then clpatches it onto another machine, changes
subsequently made to the description are kept only
locally, under the assumption that you are running
clpatch because someone else wrote the CL, so you
don't have permission to update the web.

This change makes clpatch discard the "this was a
clpatch" information from the metadata when you
clpatch your own CLs from one machine to another.

This should eliminate some confusion (for example
in CL 4314054) but will no doubt introduce other
confusion.

R=golang-dev, r2
CC=golang-dev
https://golang.org/cl/4387041
This commit is contained in:
Russ Cox 2011-04-07 13:03:06 -04:00
parent b3a4d58ba8
commit 710028d3a4
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
lib/codereview/codereview.py
View File

@ -1787,7 +1787,9 @@ def DownloadCL(ui, repo, clname):
email = match.group(1) email = match.group(1)
# Print warning if email is not in CONTRIBUTORS file. # Print warning if email is not in CONTRIBUTORS file.
FindContributor(ui, repo, email) him = FindContributor(ui, repo, email)
me = FindContributor(ui, repo, None)
if him != me:
cl.copied_from = email cl.copied_from = email
return cl, diffdata, "" return cl, diffdata, ""